Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Feature envy detected, so move execute_command to Subscriptions | David Heinemeier Hansson | 2015-06-22 | 2 | -27/+27 |
| | |||||
* | Use delegated logger | David Heinemeier Hansson | 2015-06-22 | 1 | -2/+3 |
| | |||||
* | Style | David Heinemeier Hansson | 2015-06-22 | 1 | -3/+1 |
| | |||||
* | Extract execute_command method and centralize exception handling | David Heinemeier Hansson | 2015-06-22 | 2 | -14/+10 |
| | |||||
* | Spacing | David Heinemeier Hansson | 2015-06-22 | 1 | -1/+4 |
| | |||||
* | Style | David Heinemeier Hansson | 2015-06-22 | 1 | -5/+1 |
| | |||||
* | Use private accessor | David Heinemeier Hansson | 2015-06-22 | 1 | -8/+9 |
| | |||||
* | Fix reference | David Heinemeier Hansson | 2015-06-22 | 1 | -1/+1 |
| | |||||
* | Slim down the web socket respond blocks | David Heinemeier Hansson | 2015-06-22 | 1 | -17/+12 |
| | | | | | Move heartbeat into on_open/close and add a similarly named on_message to handle that callback. | ||||
* | Rename Processor to MessageBuffer | David Heinemeier Hansson | 2015-06-22 | 4 | -61/+58 |
| | |||||
* | Extract helper method | David Heinemeier Hansson | 2015-06-22 | 1 | -2/+6 |
| | |||||
* | Finish Processor class extraction | David Heinemeier Hansson | 2015-06-22 | 3 | -24/+10 |
| | |||||
* | WIP: Extract processor | David Heinemeier Hansson | 2015-06-22 | 2 | -11/+56 |
| | |||||
* | Wrap message queueing in a more welcoming API | David Heinemeier Hansson | 2015-06-21 | 1 | -5/+21 |
| | |||||
* | Add logging for when message isn't a string | David Heinemeier Hansson | 2015-06-21 | 1 | -0/+2 |
| | |||||
* | Centralize logging in process and enhance method name | David Heinemeier Hansson | 2015-06-21 | 1 | -4/+5 |
| | |||||
* | Extract Heartbeat class to perform periodical ping | David Heinemeier Hansson | 2015-06-21 | 3 | -12/+33 |
| | |||||
* | Extracted Subscriptions class | David Heinemeier Hansson | 2015-06-21 | 3 | -37/+64 |
| | |||||
* | Remove anemic indirection | David Heinemeier Hansson | 2015-06-21 | 2 | -6/+1 |
| | |||||
* | Don't namespace methods with the class we are already in | David Heinemeier Hansson | 2015-06-21 | 2 | -3/+3 |
| | |||||
* | Rename callback hooks to match setup | David Heinemeier Hansson | 2015-06-21 | 1 | -4/+6 |
| | | | | And make it all private | ||||
* | Styling | David Heinemeier Hansson | 2015-06-21 | 1 | -5/+8 |
| | |||||
* | Consolidate all identification logic in a single concern | David Heinemeier Hansson | 2015-06-21 | 4 | -12/+19 |
| | |||||
* | Order of appearance | David Heinemeier Hansson | 2015-06-21 | 1 | -7/+10 |
| | |||||
* | Match transmit. No need to qualify _data | David Heinemeier Hansson | 2015-06-21 | 1 | -3/+3 |
| | |||||
* | Styling | David Heinemeier Hansson | 2015-06-21 | 1 | -6/+3 |
| | |||||
* | Clarify that the incoming data is JSON | David Heinemeier Hansson | 2015-06-21 | 1 | -2/+2 |
| | |||||
* | Add logging for when data is received without a live web socket | David Heinemeier Hansson | 2015-06-21 | 1 | -18/+21 |
| | | | | And make cleanup_subscriptions private | ||||
* | Homogenize lifecycle method names | David Heinemeier Hansson | 2015-06-21 | 1 | -5/+5 |
| | | | | Active, present voice. | ||||
* | Spacing | David Heinemeier Hansson | 2015-06-21 | 1 | -2/+2 |
| | |||||
* | Space | David Heinemeier Hansson | 2015-06-21 | 1 | -1/+0 |
| | |||||
* | Style | David Heinemeier Hansson | 2015-06-20 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:basecamp/action_cable | David Heinemeier Hansson | 2015-06-20 | 5 | -23/+34 |
|\ | |||||
| * | Update request to do the env_config merge and add cookies helper | David Heinemeier Hansson | 2015-06-20 | 1 | -4/+8 |
| | | |||||
| * | More logging improvements | David Heinemeier Hansson | 2015-06-20 | 3 | -5/+5 |
| | | |||||
| * | Assume channel names include the _channel extension | David Heinemeier Hansson | 2015-06-20 | 1 | -1/+1 |
| | | |||||
| * | Rename broadcast to transmit for the connection/channel->subscriber ↵ | David Heinemeier Hansson | 2015-06-20 | 3 | -10/+9 |
| | | | | | | | | | | | | | | | | | | communication Disambiguate it from the broadcast to channel method used by the broadcaster (which actually has several listeners, whereas a connection/channel instance only ever has one listener – hence not much of a BROADcast). | ||||
| * | TOC order | David Heinemeier Hansson | 2015-06-20 | 1 | -5/+6 |
| | | |||||
| * | Add new convention method for performing channel actions | David Heinemeier Hansson | 2015-06-20 | 1 | -0/+7 |
| | | |||||
* | | No need to double string it | David Heinemeier Hansson | 2015-06-20 | 1 | -1/+1 |
|/ | |||||
* | Log when receiving unrecognized commands | David Heinemeier Hansson | 2015-06-20 | 1 | -0/+2 |
| | |||||
* | Improve logging | David Heinemeier Hansson | 2015-06-19 | 3 | -18/+26 |
| | |||||
* | Refactor perform_action via extract methods | David Heinemeier Hansson | 2015-06-19 | 1 | -5/+21 |
| | | | | And improve logging | ||||
* | Better spacing | David Heinemeier Hansson | 2015-06-19 | 1 | -0/+2 |
| | |||||
* | Nix space | David Heinemeier Hansson | 2015-06-19 | 1 | -1/+0 |
| | |||||
* | Log connection | David Heinemeier Hansson | 2015-06-19 | 1 | -1/+2 |
| | |||||
* | Stop logging all send data, but do log broadcasting | David Heinemeier Hansson | 2015-06-19 | 2 | -1/+1 |
| | | | | We basically want to quiet the pings. | ||||
* | Making running of subscribe callbacks a private matter | David Heinemeier Hansson | 2015-06-19 | 1 | -5/+4 |
| | |||||
* | Add #perform_disconnection to have a place for both callbacks and logging | David Heinemeier Hansson | 2015-06-19 | 2 | -7/+10 |
| | | | | And using an unlikely-to-clash name. | ||||
* | Use a perform_action router to handle incoming data | David Heinemeier Hansson | 2015-06-19 | 2 | -5/+9 |
| | | | | Similar to a controller in ActionPack. |