| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
42 compatibility - use int instead of bigint
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Add headless chrome driver to System Tests
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|_|_|_|/
|/| | | | | | |
Update mailing list URL in I18n guide [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix `to_s(:db)` for range comprising of alphabets.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Remove association(true) references from docs [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Passing `true` to force an association to reload its records from the
database was deprecated in 5.0 and removed in 5.1.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up of #30862.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
yhirano55/remove_needless_space_in_action_view_guide
Remove a needless space in Action View Guide [ci skip]
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Capitalize "sprockets" in Engine guide [ci skip]
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`exists?`
This test covers the case of 02da8aea.
Previously `exists?` was always eager-loading the includes values. But
now it is eager-loaded only when necessary since 07a611e0.
So the case of the eager-loading had not covered in the test.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We already found the longer sequence name, but we could not consider
whether it was the sequence name created by serial type due to missed a
max identifier length limitation. I've addressed the sequence name
consideration to respect the max identifier length.
Fixes #28332.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update Gemfile with comment for Active Storage group
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently `AUTO_INCREMENT` is implicitly used in the default primary key
definition. But `AUTO_INCREMENT` is not only used for single column
primary key, but also for composite primary key. In that case,
`auto_increment: true` should be dumped explicitly in the
`db/schema.rb`.
Fixes #30894.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unused `before_filters`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This method added by 1008511. It is unnecessary because it is no longer called
by 19c3495.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add accept-charset to the output of form_with in JS guide [ci skip]
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This is the fix for the regression of #29848.
In #29848, I've kept existing select list in the subquery for the count
if ORDER BY is given. But it had accidentally affect to GROUP BY
queries also. It should keep the previous behavior in that case.
Fixes #30886.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For investigating the cause of failure.
https://travis-ci.org/rails/rails/jobs/287474883#L797-L799
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
yhirano55/add_unpermitted_parameters_hook_to_instrument_guide
Add unpermitted_parameters hook to instrumentation guide [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix test name for daemon option test
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In this test file, "server option" refers to the server used to start
Rails(e.g. `puma`, `thin`).
But this test, "server option" is not specified. Therefore, I think that
it is incorrect that `server_option` is included in the test name.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove unsued `jquery-rails`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This has been added by 8f8cb1baa3b5609969805fcdd7295f3d7de2bd6b.
But now it is unnecessary because it is not used in the test.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use __dir__ in activestorage/
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Related to #29417
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Related to #29176
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added test case for starting rails with daemon option
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
option[:daemonize] to true, otherwise the option[:daemonize] will be set to false
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
yhirano55/add_action_cable_notifications_to_instrument_guide
Add Action Cable notifications to instrument guide [ci skip]
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
yhirano55/add_mailer_notification_in_instrumentation_guide
Add process.action_mailer notification to Instrument guide [ci skip]
|
|/ / / / / / |
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Bump RuboCop 0.50.0
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
RuboCop 0.50.0 was released.
https://github.com/bbatsov/rubocop/releases/tag/v0.50.0
And `rubocop-0-50` channel is available in Code Climate.
https://github.com/codeclimate/codeclimate-rubocop/issues/107#issuecomment-336234260
This commit will bump RuboCop to 0.50.0.
There are no new offences in this change.
```console
% bundle exec rubocop --version
0.50.0
% bundle exec rubocop
Inspecting 2350 files
(snip)
2350 files inspected, no offenses detected
```
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Yield with an error instance instead of error class
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|