aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix query attribute method on user-defined attribute to be aware of ↵kamille-3212019-03-113-2/+78
| | | | | | | | | | typecasted value change the line to check an attribute has user-defined type ref: https://github.com/rails/rails/pull/35320#discussion_r257924552 check query attribute method is working when given value does not respond to to_i method
* Merge pull request #35449 from pjrebsch/quoting-empty-rangeRyuta Kamizono2019-03-113-2/+20
|\ | | | | Quote empty ranges like other empty enumerables
| * Quote empty ranges like other empty enumerablesPatrick Rebsch2019-03-073-2/+20
| |
* | Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_blockKasper Timm Hansen2019-03-109-18/+18
|\ \ | | | | | | Ruby 2.7 warning: creating a Proc without a block
| * | ActionPack Proc.new without a blockutilum2019-02-132-4/+4
| | | | | | | | | | | | | | | | | | This commit fixes cases that use pre Ruby [r66772](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) syntax that are not tickled by the test suite.
| * | Ruby 2.7 warning: creating a Proc without a blockutilum2019-02-137-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191
* | | Merge pull request #35549 from r7kamura/feature/response-charsetRyuta Kamizono2019-03-102-4/+37
|\ \ \ | | | | | | | | Support other optional parameters and quoted-strings on Content-Type parser
| * | | Support other optional parameters and quoted-strings on Content-Type parserr7kamura2019-03-102-4/+37
| | | |
* | | | Merge pull request #35559 from ↵Kasper Timm Hansen2019-03-098-1/+14
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | ashishprajapati/ashishprajapati/important_textual_improvements Added missing guide links in documentation and minor wording fix
| * | | | Added missing guide links in README documentation and minor wording fix [ci ↵ashishprajapati2019-03-108-1/+14
| | | | | | | | | | | | | | | | | | | | skip]
* | | | | PostgreSQL: Add `add_pg_encoders` and `add_pg_decoders` in `connect`Ryuta Kamizono2019-03-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is to work that on `reconnect!` after `disconnect!`. https://buildkite.com/rails/rails/builds/59378#1efea538-cfca-4d43-8b7e-ae78e97227c8
* | | | | Don't test `disconnect!` if in memory dbRyuta Kamizono2019-03-101-8/+8
| | | | | | | | | | | | | | | | | | | | `disconnect!` will lose all tables and fixtures if in memory db.
* | | | | Merge pull request #35557 from sharang-d/revert-jquery-changeXavier Noria2019-03-091-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Revert an incorrect change in jquery-2.2.0.js
| * | | | | Revert an incorrect change in jquery-2.2.0.jsSharang Dashputre2019-03-101-2/+2
|/ / / / /
* | | | | SQLite3: Set `busy_timeout` in `configure_connection`Ryuta Kamizono2019-03-101-2/+2
| | | | | | | | | | | | | | | | | | | | It is to work that on `reconnect!` after `disconnect!`
* | | | | Fix `reconnect!` to work after `disconnect!`Ryuta Kamizono2019-03-103-11/+25
| | | | |
* | | | | Merge pull request #35555 from ↵Ryuta Kamizono2019-03-101-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | shailesh-kalamkar/fix-autosave-association-test-typo Fix autosave_association_test.rb typo
| * | | | | Fixed autosave association test typoShailesh Kalamkar2019-03-091-1/+1
|/ / / / /
* | | | | Merge pull request #35552 from abhaynikam/fix-remaining-set-of-links-in-gemspecRyuta Kamizono2019-03-1019-33/+33
|\ \ \ \ \ | | | | | | | | | | | | Update some more links to https
| * | | | | Fix links in gemspec and docs from http to https.Abhay Nikam2019-03-0919-33/+33
| | | | | |
* | | | | | Merge pull request #35553 from sharang-d/update-upsert_all-docRyuta Kamizono2019-03-091-3/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update upsert_all documentation [ci skip]
| * | | | | | Update upsert_all documentation [ci skip]Sharang Dashputre2019-03-091-3/+2
|/ / / / / /
* | | | | | Merge pull request #35527 from tight/improve_doc_of_automatic_inverse_ofRyuta Kamizono2019-03-091-2/+3
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Improve doc of automatic inverse_of detection [ci skip]
| * | | | | Improve doc of automatic inverse_of detectionFrançois D2019-03-081-2/+3
| | | | | |
* | | | | | Merge pull request #35531 from boblail/issue-35519Ryuta Kamizono2019-03-091-3/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update documentation on upsert_all so that it is correct for Postgres [ci skip]
| * | | | | | Update documentation on upsert_all so that it is correct for PostgresBob Lail2019-03-081-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Details in https://github.com/rails/rails/issues/35519 In short, MySQL and Sqlite3 allow a record to be both inserted _and_ replaced in the same operation. Postgres (and the SQL-2003 rules for MERGE) do not. Postgres's rationale seems to be that the operation would be nondeterministic. I think it's OK for Rails users to have a different experience with this feature depending on their database; but I think you should be able to follow the examples in the docs on any database.
* | | | | | | Merge pull request #35529 from ↵Ryuta Kamizono2019-03-0926-34/+34
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | abhaynikam/35492-follow-up-to-updates-links-to-https Updated links from http to https in guides, docs, etc
| * | | | | | | Updated links from http to https in guides, docs, etcAbhay Nikam2019-03-0926-34/+34
| |/ / / / / /
* | | | | | | Merge pull request #35550 from shailesh-kalamkar/minor-documentation-fixesXavier Noria2019-03-094-4/+4
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | [ci skip] Minor documentation fixes for consistency
| * | | | | | [ci skip] Minor documentation fixes for consistencyShailesh Kalamkar2019-03-094-4/+4
|/ / / / / /
* | | | | | Merge pull request #35548 from vishaltelangre/patch-1Vipul A M2019-03-091-10/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | Minor documentation fixes related to bulk insert [ci skip]
| * | | | | | Minor documentation fixes related to bulk insert [skip ci]Vishal Telangre2019-03-091-10/+13
| | | | | | |
* | | | | | | Guides: Fix parent class of model test example (#35065)Sean Abrahams2019-03-091-1/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix parent class of model test example * include ActiveJob::TestHelper [ci skip]
* | | | | | Merge pull request #35545 from sharang-d/relax-webpacker-versionYuji Yaginuma2019-03-093-3/+3
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Don't lock the webpacker gem by its patch version
| * | | | | Don't lock the webpacker gem by its patch versionSharang Dashputre2019-03-093-3/+3
|/ / / / /
* | | | | Fix "DEPRECATION WARNING: ActionView::Template#initialize requires a locals ↵yuuji.yaginuma2019-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | parameter" Ref: #35411
* | | | | Merge pull request #35538 from sharang-d/use-latest-webpackerGuillermo Iguaran2019-03-087-4663/+7691
|\ \ \ \ \ | | | | | | | | | | | | Use the latest stable release of webpacker
| * | | | | Upgrade webpack-dev-server version in test appsSharang Dashputre2019-03-094-870/+458
| | | | | |
| * | | | | Use the latest stable release of webpackerSharang Dashputre2019-03-097-4005/+7445
| |/ / / /
* | | | | Merge pull request #35539 from sharang-d/replant-text-changesXavier Noria2019-03-081-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Minor text changes to the db:seed:replant tests
| * | | | | Minor text changes to the db:seed:replant testsSharang Dashputre2019-03-091-2/+2
|/ / / / /
* | | | | Read the CSP nonce on page loadGeorge Claghorn2019-03-082-4/+10
| | | | | | | | | | | | | | | Turbolinks replaces the CSP nonce <meta> tag on page change, but inline scripts inserted by UJS need the nonce from the initial page load. In general, it doesn't matter to UJS if the nonce changes after the page loads: only the initial value is relevant.
* | | | | Merge pull request #35537 from ↵Xavier Noria2019-03-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | iarobinson/iarobinson/remove_painfully_from_action_mailer_basics Remove the word painfully from documentation
| * | | | | - Remove the word painfully from documentationiarobinson2019-03-081-1/+1
|/ / / / /
* | | | | Merge pull request #35536 from alexander-lazarov/improve-cache-docsXavier Noria2019-03-081-5/+5
|\ \ \ \ \ | | | | | | | | | | | | Improve wording in cache documentation
| * | | | | Improve wording in cache documentation [ci skip]Alexander Lazarov2019-03-081-5/+5
| | |/ / / | |/| | |
* | | | | moves a require to the file that needs itXavier Noria2019-03-082-1/+2
| | | | |
* | | | | Merge pull request #35533 from Shopify/zeitwerk-custom-inflectorsXavier Noria2019-03-084-6/+13
|\ \ \ \ \ | |_|/ / / |/| | | | Allow autoloader inflectors to be swaped out
| * | | | Allow autoloader inflectors to be swaped outJean Boussier2019-03-084-6/+13
|/ / / /
* | | | Merge pull request #35522 from gmcgibbon/rails_db_system_change_versioningKasper Timm Hansen2019-03-082-5/+30
|\ \ \ \ | |/ / / |/| | | Add version awareness to rails db:system:change
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 18:03:29 +0000