| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Fixed issue w/custom accessors + reserved name + inheritance
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixed an issue where custom accessor methods (such as those generated by
`enum`) with the same name as a global method are incorrectly overridden
when subclassing.
This was partially fixed in 4155431 then broken again by e5f15a8.
Fixes #16288.
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Cookies digest config option (pt. 2)
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_dispatch/middleware/cookies.rb
|
| | | |
| | |
| | |
| | |
| | |
| | | |
You can now configure custom digest for cookies in the same way as `serializer`:
config.action_dispatch.cookies_digest = 'SHA256'
|
| |\ \ \
| | | |
| | | | |
Remove redundant NullSerializer
|
| | |/ /
| | |
| | |
| | | |
Use one from ActiveSupport::MessageEncryptor module.
|
| |\ \ \
| | | |
| | | | |
Move respond_with to the responders gem
|
| | | | | |
|
| | | | | |
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
respond_with (and consequently the class-level respond_to)
are being removed from Rails. Instead of moving it to a 3rd
library, the functionality will be moved to responders gem
(at github.com/plataformatec/responders) which already provides
some responders extensions.
|
| |\ \ \
| | | |
| | | | |
[ci skip] Fix sample code in Layouts and Rendering guide
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| |\ \ \ \
| | | | |
| | | | | |
Avoid relying on error messages when rescuing
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When we are rescuing from an error, it's a brittle approach to do checks
with regular expressions on the raised message because it may change in
in the future and error messages are different across implementations.
The NameError API could be improved at the MRI level but for now we need
to rely on its #name. A #== check will only pass for top level constants
or only when the last constant of the path is missing so we need to rely
on #include? instead. For instance:
begin
Namespace::Foo
rescue NameError => e
e.name # => :Namespace
end
However, if the name-space already exists, only the name of the first
missing constant in the path is returned (e.g. for Math::PHI, the name
would be :PHI). JRuby will return a fully qualified name (:"Math::PHI").
We need to keep the == check for 1.9 compatibility since const_get will
raise a NameError with a name attribute set to the given string if it's
one of "::" or "".
See http://git.io/jnSN7g for further information.
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
When your templates change, browser caches bust automatically.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
New default: the template digest is automatically included in your ETags.
When you call `fresh_when @post`, the digest for `posts/show.html.erb`
is mixed in so future changes to the HTML will blow HTTP caches for you.
This makes it easy to HTTP-cache many more of your actions.
If you render a different template, you can now pass the `:template`
option to include its digest instead:
fresh_when @post, template: 'widgets/show'
Pass `template: false` to skip the lookup. To turn this off entirely, set:
config.action_controller.etag_with_template_digest = false
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Implement `_was` and `changes` for in-place mutations of AR attributes
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
WARNING: don't use them! They might change or go away between future beta/RC/
patch releases!
Also added a CHANGELOG entry for this.
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Implement `==` on `Type::Value` and `Attribute`
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was a small self contained piece of the refactoring that I am
working on, which required these objects to be comparable.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] re-worded section on CookieStore to make it more readable.
|
| |/ / / / / |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
arthurnn/after_commit_run_on_top_level_trans_master
Fix regression on after_commit in nested transactions. (master)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
after_commit should not run in nested transactions, however they should
run once the outermost transaction gets committed. This patch fixes the
problem copying the records from the Savepoint to its parent. So the
RealTransaction will have all records that needs to run callbacks on it.
[fixes #16425]
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Use `commit_transaction`/`rollback_transaction` on
`within_new_transaction` method, so they make sure they `pop` the
transaction from the stack before calling the methods `commit`/`rollback`.
|
| | | | |
| | | |
| | | |
| | | | |
The rails repository is not the official plugin anymore
|
| | | | |
| | | |
| | | |
| | | | |
closes #16512
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Follow up to the discussion on #16505.
|
| |\ \ \ \
| | | | |
| | | | | |
Use the method for determining attribute methods rather than duplicating
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I've been trying to reduce the number of places that care about
`attributes`, and its existence. We have a method for this check, let's
use it instead.
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Spelling errors
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Perf optimization for `url_for` called w/ Hash
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Benchmarking the existing code:
```ruby
{ :only_path => options[:host].nil? }.merge!(options.symbolize_keys))
```
Against optimized code, that does not require a new hash or a merge:
```ruby
options = options.symbolize_keys
options[:only_path] = options[:host].nil? unless options.key?(:only_path)
options
```
We see a statistically significant performance gain:
Updated to not mutate incoming parameters
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
