aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* test, reset changed state in PG's uuid tests.Yves Senn2014-05-081-2/+4
| | | | | | | | | | | | | This resulted in some unrelated errors on Traivs: 1) Error: PostgresqlUUIDTest#test_treat_blank_uuid_as_nil: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "thingy" of relation "uuid_data_type" does not exist LINE 1: INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNIN... ^ : INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNING "id" /cc @zuhao
* pg guide, inet code example. [ci skip]Yves Senn2014-05-081-3/+29
|
* Merge pull request #15020 from ivantsepp/contributing_to_rails_guide_fixGodfrey Chan2014-05-071-1/+1
|\ | | | | Mismatch branch name between text and code example [ci skip]
| * Branch name should match in text and code example.Ivan Tse2014-05-081-1/+1
|/ | | | [ci skip]
* Merge pull request #15016 from arthurnn/dup_attr_on_save_stateGodfrey Chan2014-05-071-1/+1
|\ | | | | Dup the changed_attributes otherwise we could lose them
| * Dup the changed_attributes otherwise we could lose themArthur Neves2014-05-071-1/+1
|/
* Merge pull request #15015 from pothibo/database-configurationRafael Mendonça França2014-05-073-1/+22
|\ | | | | Use Rails::Paths::Path#existent in database_configuration
| * Use Rails::Paths::Path#existent in database_configurationPier-Olivier Thibault2014-05-073-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | Database configuration was trying to load the first path that config.paths['config/database'] was returning even if the path didn't exist in the filesystem. Because Rails::Paths::Path has the possibility to return more than 1 path (as an array), database_configuration should filter down the paths to the existing one and then load the first one. This would make it possible to move the database.yml file and add the new path to paths['config/database'] and still load the configurations.
* | Add CHANGELOG entry for #14989Rafael Mendonça França2014-05-071-0/+5
| | | | | | | | Closes #14989
* | Return a non zero code when db has never been setup on statusPaul B2014-05-072-3/+2
| |
* | Merge pull request #12746 from coreyward/masterRafael Mendonça França2014-05-072-15/+36
|\ \ | | | | | | | | | Fix Hash#deep_merge bug and improve documentation — resolves #12738
| * | Fix Hash#deep_merge bug and improve documentation — resolves #12738Corey Ward2013-12-092-11/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously merging into a hash with a falsy value would not result in the merge-block being called. The fix is simply to check for presence of the key in the hash. The documentation example for `deep_merge` now appropriately demonstrates what a deep merge does.
* | | Merge branch 'rm-trasaction-fix-13166'Rafael Mendonça França2014-05-073-0/+52
|\ \ \ | |_|/ |/| |
| * | Keep track of dirty attrs after after rollback.Arthur Neves2014-05-074-20/+11
| | | | | | | | | | | | [related #13166]
| * | Merge pull request #13166 from bogdan/transaction-magicRafael Mendonça França2014-05-073-1/+62
|/| | | | | | | | | | | [Regression 3.2 -> 4.0] Fix bugs with changed attributes tracking when transaction gets rollback
| * | Fix bugs with changed attributes tracking when transaction gets rollbackBogdan Gusiev2013-12-043-1/+62
| | |
* | | Merge pull request #15012 from schneems/schneems/headers-keyYves Senn2014-05-072-1/+5
|\ \ \ | | | | | | | | HTTP::Headers#key? correctly converts
| * | | HTTP::Headers#key? correctly convertsschneems2014-05-072-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence
* | | | test for inconsistency between String and Symbol url_for handlingAaron Patterson2014-05-071-0/+4
| | | |
* | | | add tests for symbols passed to polymorphic_urlAaron Patterson2014-05-071-0/+12
|/ / /
* | | test, persist inherited class with different table name. Refs #14971.Yves Senn2014-05-071-0/+14
| | | | | | | | | | | | | | | This case prevents against regressions. The change was suggested in a recent PR but the all our tests passed.
* | | Merge pull request #15002 from vanderhoop/masterArthur Neves2014-05-071-2/+2
|\ \ \ | | | | | | | | | | | | typo fixes in active_record_basics.md [skip ci]
| * | | fixed typos in active_record basics [skip ci]vanderhoop2014-05-071-2/+2
|/ / /
* | | Merge pull request #14964 from zuhao/refactor_actionmailer_testsYves Senn2014-05-071-102/+157
|\ \ \ | | | | | | | | WIP: Make ActionMailer tests order-independent.
| * | | Fix state leaks in actionmailer/test/base_test.rb.Zuhao Wan2014-05-071-102/+157
| | | |
* | | | Merge pull request #15007 from vipulnsward/fix-scrubber-overshadowYves Senn2014-05-071-1/+1
|\ \ \ \ | | | | | | | | | | rename var to fix overshadowing of variable
| * | | | rename `str` to `string` to fix overshadowing of variableVipul A M2014-05-071-1/+1
| | | | |
* | | | | Merge pull request #14993 from jonatack/patch-7Yves Senn2014-05-071-10/+9
|\ \ \ \ \ | | | | | | | | | | | | Follow-up to #14990 [ci skip]
| * | | | | Follow-up to #14990 [ci skip]Jon Atack2014-05-071-10/+9
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rewrite to avoid 'we'/'you', add missing period, and keep lines at 80 chars. Cheers :) Improve readability with help from @senny [ci skip]
* / / / / Update links to new rails version in guides [ci skip]Arun Agrawal2014-05-071-1/+1
|/ / / /
* | | | Merge pull request #15004 from JuanitoFatas/patch/ar-pgYves Senn2014-05-071-3/+12
|\ \ \ \ | | | | | | | | | | [ci skip] Add feature section and normalize prologue with other guides.
| * | | | [ci skip] Add feature section and normalize prologue with other guides.Juanito Fatas2014-05-071-3/+12
|/ / / / | | | | | | | | | | | | | | | | | | | | Also change Json => JSON. Fill Ruby's Range & IPAddr link.
* | | | apparently passing a string to polymorphic_url is something we supportAaron Patterson2014-05-061-0/+12
| | | | | | | | | | | | | | | | o_O
* | | | make sure url_for works similar to polymorphic_urlAaron Patterson2014-05-061-38/+43
| | | |
* | | | add a test for the parameters sent to the url helper for new recordsAaron Patterson2014-05-061-0/+15
| | | |
* | | | Merge pull request #15000 from gregmolnar/guides_fixArthur Nogueira Neves2014-05-061-1/+4
|\ \ \ \ | | | | | | | | | | fix guides mobile nav issue
| * | | | fix guides mobile nav issue [ci skip]Greg Molnar2014-05-061-1/+4
|/ / / /
* | | | typo [ci skip]Xavier Noria2014-05-061-1/+1
| | | |
* | | | Merge pull request #14997 from jpcody/nested_value_i18nRafael Mendonça França2014-05-064-2/+44
|\ \ \ \ | | | | | | | | | | Include label value in i18n attribute lookup
| * | | | Include label value in i18n attribute lookupJoshua Cody2014-05-064-2/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post".
* | | | | Merge pull request #14998 from arthurnn/tests_for_process_returnRafael Mendonça França2014-05-062-9/+13
|\ \ \ \ \ | | | | | | | | | | | | Ensure that .process return the method return
| * | | | | Ensure that .process return the method returnArthur Neves2014-05-062-9/+13
| | | | | |
* | | | | | several enhancements to humanize [closes #12288]Xavier Noria2014-05-064-19/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Strips leading underscores. * Changes some unnecessary gsub!s to sub!s. * Replaces some anchors ^, $ with \A, \z. * Documents that human inflection rules are applied. * Documents that words are downcased except acronyms. * Adds an example with an acronym. * Rewords docs.
* | | | | | Merge pull request #14982 from eric-chahin/GBV_refactorRafael Mendonça França2014-05-062-8/+6
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Refactored AssociationScope#get_bind_values
| * | | | | Refactor AssociationScope#get_bind_valuesEric Chahin2014-05-052-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | Added #join_id_for(owner) to reflection to avoid accessing the source_macro
* | | | | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactorRafael Mendonça França2014-05-063-6/+34
|\ \ \ \ \ \ | | | | | | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and...
| * | | | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵Tom Kadwill2014-05-063-6/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | improved tests.
* | | | | | | Only accept actions without File::SEPARATOR in the name.Rafael Mendonça França2014-05-062-4/+41
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb
* | | | | | Merge pull request #14990 from fredwu/has_many_through_association_doc_grammarYves Senn2014-05-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixed grammar [ci skip]
| * | | | | | Fixed grammarFred Wu2014-05-061-1/+1
|/ / / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 22:58:21 +0000