aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Correctly use the response's status code calling headRobin Dupret2014-12-314-5/+23
| | | | | | | | | | | | | | | | Commit 20fece1 introduced the `_status_code` method to fix calls to `head :ok`. This method has been added on both ActionController::Metal and ActionDispatch::Response. As for the latter, this method is just equivalent to the `response_code` one so commit aefec3c removed it from the `Reponse` object so call to the `_status_code` method on an ActionController::Base instance would be handled by the `Metal` class (which `Base` inherits from) but the status code is not updated according to the response at this level. The fix is to actually rely on `response_code` for ActionController::Base instances but this method doesn't exist for bare Metal controllers so we need to define it.
* Merge pull request #18274 from rajcybage/spell_fixRobin Dupret2014-12-312-4/+4
|\ | | | | Fix spell life cycle on activejob docs [ci skip]
| * Fix spell life cycle on activejob docs [ ci skip]Rajarshi Das2014-12-312-4/+4
| |
* | Merge pull request #18269 from cuppincake/getting-started-migration-updateYves Senn2014-12-311-0/+3
|\ \ | | | | | | Update Getting Started guide to reflect foreign key in migration [ci skip]
| * | Update Getting Started guide to reflect foreign key in migration [ci skip]Jennifer Wollesen2014-12-301-0/+3
| | |
* | | Merge pull request #18270 from prathamesh-sonpatki/activejobs-is-not-actionjobCristian Bica2014-12-311-1/+1
|\ \ \ | |/ / |/| | ActiveJob is not ActionJob [ci skip] :smile:
| * | ActiveJob is not ActionJob [ci skip] :smile:Prathamesh Sonpatki2014-12-311-1/+1
|/ /
* | Add Profiling guide skeleton [ci skip]Zachary Scott2014-12-302-0/+22
| |
* | Extract the index length validation to a auxiliar methodRafael Mendonça França2014-12-303-9/+12
| |
* | Merge pull request #18264 from yahonda/rename_index_mysqlRafael Mendonça França2014-12-301-0/+3
|\ \ | | | | | | Raise a better exception for renaming long indexes for mysql adapters
| * | Raise a better exception for renaming long indexes for mysql adaptersYasuo Honda2014-12-301-0/+3
| | |
* | | Merge pull request #18266 from cristianbica/ajfixesRafael Mendonça França2014-12-306-12/+21
|\ \ \ | | | | | | | | ActiveJob testing improvements
| * | | ActiveJob testing improvementsCristian Bica2014-12-306-12/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. The :test adapter wasn't going through a full cycle of serialize/deserialize when performing jobs. Now it does 2. Regular AJ tests were not run for the :test adapter. Now they are 3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires the file that implements that method. Now it does
* | | | Fix error message when trying to create an associated recordRafael Mendonça França2014-12-304-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This error only happens when the foreign key is missing. Before this fix the following exception was being raised: NoMethodError: undefined method `val' for #<Arel::Nodes::BindParam:0x007fc64d19c218> Now the message is: ActiveRecord::UnknownAttributeError: unknown attribute 'foreign_key' for Model.
* | | | Merge pull request #18260 from isaacseymour/active-job-delegate-deserializeDavid Heinemeier Hansson2014-12-302-4/+53
|\ \ \ \ | | | | | | | | | | ActiveJob: delegate deserialization to the job class
| * | | | ActiveJob: delegate full deserialization to classIsaac Seymour2014-12-302-4/+53
| | | | |
* | | | | stop referencing `env` in url_forAaron Patterson2014-12-302-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | encapsulate env in the request so that we can eventually move away from the env hash
* | | | | use methods on the request rather than direct hash accessAaron Patterson2014-12-302-2/+10
| | | | | | | | | | | | | | | | | | | | this will help decouple us from using the rack env hash
* | | | | Merge pull request #18242 from brainopia/has_one_loading_for_new_recordSean Griffin2014-12-306-43/+71
|\ \ \ \ \ | | | | | | | | | | | | Load a has_one target for a new record if possible
| * | | | | Share foreign_key_present? implementation in _has_ associationsbrainopia2014-12-316-43/+71
| | |_|/ / | |/| | |
* | | | | Merge pull request #18219 from jaroslawr/masterAaron Patterson2014-12-301-74/+116
|\ \ \ \ \ | |/ / / / |/| | | | Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.
| * | | | Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.Jaroslaw Rzeszotko2014-12-271-74/+116
| | | | |
* | | | | Merge pull request #17680 from larskanis/fix_bytea_change_detectionSean Griffin2014-12-302-1/+9
|\ \ \ \ \ | | | | | | | | | | | | PostgreSQL, Fix change detection caused by superfluous bytea unescaping
| * | | | | PostgreSQL, Fix change detection caused by wrong data for bytea unescaping.Lars Kanis2014-12-292-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This showed up when running BinaryTest#test_load_save with the more restrictive input string handling of pg-0.18.0.pre20141117110243.gem . Bytea values sent to the server are in binary format, but are returned back as escaped text. To fulfill the assumption that type_cast_from_database(type_cast_for_database(binary)) == binary we unescape only, if the value was really received from the server.
* | | | | | Move Engines guide under Extending Rails [ci skip]Zachary Scott2014-12-301-5/+5
| | | | | |
* | | | | | Merge pull request #18262 from benwoody/fix-cycle-doc-missprintZachary Scott2014-12-301-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixes simple missprint in docs for #cyle in text_helper [ci skip]
| * | | | | | Fixes simple missprint in docs for #cyle in text_helperBen Woodall2014-12-301-1/+1
| | | | | | |
* | | | | | | Merge pull request #18263 from mntj/fix_typo_in_commentZachary Scott2014-12-301-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix comment typo in debugger.rb [ci skip]
| * | | | | | Fix comment typo in debugger.rbmntj2014-12-301-1/+1
|/ / / / / /
* | | | | | The Guide to Testing Rails Applications is published! :tada: :tada: [ci skip]Zachary Scott2014-12-302-5/+9
| | | | | |
* | | | | | Replace exhaustive list of methods with pointer to API docs. [ci skip]Zachary Scott2014-12-301-11/+1
| | | | | |
* | | | | | Add result of running articles_routes_test and point to more information forZachary Scott2014-12-301-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | RoutingAssertions. [ci skip]
* | | | | | Move request tests after functional and before views, and move helper testsZachary Scott2014-12-301-50/+50
| | | | | | | | | | | | | | | | | | | | | | | | after views. [ci skip]
* | | | | | Merge branch 'master' of github.com:rails/rails [ci skip]Zachary Scott2014-12-301-3/+4
|\ \ \ \ \ \
| * \ \ \ \ \ Merge pull request #18261 from prathamesh-sonpatki/update-changelogRafael Mendonça França2014-12-301-3/+4
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Update CHANGELOG entry for #18070 [ci skip]
| | * | | | | | Update CHANGELOG entry for #18070 [ci skip]Prathamesh Sonpatki2014-12-311-3/+4
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | - Improved wording of CHANGELOG entry for https://github.com/arthurnn/rails/commit/5acd24bbeae0e9e5e81e87b5929e17f35527b2ea.
* / / / / / / Make "Testing Views" separate section, move "Setup and Teardown" intoZachary Scott2014-12-301-88/+85
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | functional testing section and implement :show, :destroy, and :update tests. [ci skip]
* | | | | | Merge pull request #18259 from arthurnn/return_nil_on_multi_pkSean Griffin2014-12-306-8/+33
|\ \ \ \ \ \ | | | | | | | | | | | | | | Ensures that primary_key method will return nil when multi-pk
| * | | | | | Ensures that primary_key method will return nil when multi-pkArthur Neves2014-12-306-8/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When table has a composite primary key, the `primary_key` method for sqlite3 and postgresql was only returning the first field of the key. Ensures that it will return nil instead, as AR dont support composite pks.
* | | | | | | Add implement integration test to Testing Guide. [ci skip]Zachary Scott2014-12-301-0/+75
| |_|_|/ / / |/| | | | |
* | | | | | Replace exhaustive list of helper methods with pointers to helper classes foundZachary Scott2014-12-301-16/+7
| | | | | | | | | | | | | | | | | | | | | | | | in the Action Dispatch Integration module. [ci skip]
* | | | | | Remove this line which was added by accident [ci skip]Zachary Scott2014-12-301-2/+0
| | | | | |
* | | | | | Merge pull request #18256 from rohit/secure-password-tweakRafael Mendonça França2014-12-301-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use more semantic method to authenticate password in SecurePassword
| * | | | | | Use more semantic method to check passwordRohit Arondekar2014-12-301-1/+1
| | |_|_|/ / | |/| | | |
* | | | | | Merge pull request #18258 from ↵Rafael Mendonça França2014-12-301-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | prathamesh-sonpatki/fix-application-name-description Fix description for application_name method - change simple to simply [ci skip]
| * | | | | Fix description for application_name method - change simple to simplyPrathamesh Sonpatki2014-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Tiny documentation fixes [ci skip]Robin Dupret2014-12-302-4/+5
| | | | | |
* | | | | | Merge pull request #18130 from claudiob/better-record-identifier-docRobin Dupret2014-12-301-18/+42
|\ \ \ \ \ \ | | | | | | | | | | | | | | Better docs for AV::RecordIdentifier [ci skip]
| * | | | | | Better docs for AV::RecordIdentifierclaudiob2014-12-231-18/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit intends to clarify the scope of ActionView::RecordIdentifier methods `dom_id` and `dom_class`. Most of the current documentation comes from da257eb8 (7 years ago) when the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern. Since then, steps have been taken to reach such decoupling, especially 8ca17926 which duplicated ActionController::ModelNaming into ActionView::ModelNaming explaining that: > These are just a simple helpers for decoupling Active Model, so it does not > make sense to extract it to Active Support, but the point is to decouple also > Action View and Action Pack As of today, ActionView::RecordIdentifier only includes `dom_id` and `dom_class` so it makes sense to explicitly document those two methods, and leaving the details of helpers like `div_for` in the corresponding files. Moreover, I think it's important to mention in the documentation that ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work. [ci skip]
* | | | | | | Merge pull request #18255 from prathamesh-sonpatki/fix-single-space-for-headRafael Mendonça França2014-12-303-5/+17
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Remove single space response body for head request
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 23:06:11 +0000