| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The string returned here will ultimately get used as a key of a hash in
the attribute set once the attributes are being built. When you give a
non-frozen string to `Hash#[]`, it will be duped. Be freezing we can
significantly reduce the number of times we end up allocating
`"user_id"`
This does not include any additional tests, as this should not have any
public facing implications. If you are mutating the result of
`Reflection#foreign_key`, please stop.
|
| |\ |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
[ci skip] Fix <tt> in doc around +maximum(:updated_at)
|
| |/ / |
|
| |\ \
| | |
| | | |
Added warning on coding engine controllers [ci skip]
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
[ci skip] Fix CHANGELOG.md format from list to italic.
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | | |
Respect value of `:object` if `:object` is false when rendering
|
| |/ / /
| | |
| | |
| | |
| | | |
This commit fixes the bug convering `false` to `locals[as]` when
`options[:object]` is `false` (close #22260).
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When running tests, the Rails test runner would report the start of the test method as the test failure.
For this test:
```ruby
1 require 'test_helper
2
3 class BunnyTest < ActiveSupport::TestCase
4 test "something failing" do
5 assert false, 'This failed'
6 end
7 end
```
The runner outputs 5 instead of 4:
```
............................................F
This failed
bin/rails test test/models/bunny_test.rb:5
........
```
|
| | | |
| | |
| | |
| | | |
The overall syntax of the file path is more important, not the exact line it was on.
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Fix typo [ci skip]
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | | |
remove unnecessary @compiled_root from static.rb
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
All `AR::ConnectionAdapters#tables` return only tables(exclude views)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Reported on #21509, how views is treated by `#tables` are differ
by each adapters. To fix this different behavior, after Rails 5.0
is released, deprecate `#tables`.
And `#table_exists?` would check both tables and views.
To make their behavior consistent with `#tables`, after Rails 5.0
is released, deprecate `#table_exists?`.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
JuanitoFatas/patch/fix-a-warning-in-active-support-test-suite
Fix instance variable not defined warning from Active Support test suite
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Before
./Users/Juan/dev/rails/activesupport/test/file_update_checker_shared_tests.rb:20: warning: instance variable @tmpdir not initialized
After
No warnings
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A small rewrite in a last attempt at writing obvious and portable code
without manual string manipulation.
Note that Pathname#== uses string comparison on Windows, so if client
code passes "C:\foo" and "c:/foo/bar" the predicate won't see the
former is an ascendant of the latter. Risky business.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Use the file watcher defined by the app config
|
| |/ / / / /
| | | | |
| | | | | |
This can make use of the FileEventedUpdateChecker, if available.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Whatever the inner loop selects, we already know is a descendant and
can be filtered out right away from dirs_sorted_by_nparts to skip
useless iterations.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Show middleware classes on /rails/info/properties
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #21230 by following the indication of @rafaelfranca:
> I think the output change would be simpler.
> What is really important to show is the class of the middleware, so we should change the output to show that.
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
Fix typo: "in" should be "is"
|
| | | | | | |
|
| |/ / / / |
|
| | | | | |
|
| |\ \ \ \ |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
According to the W3 spec[1] the value should use a 1-based index
and not a 0-based index for the week number.
[1]: http://www.w3.org/TR/html-markup/datatypes.html#form.data.week
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
I spent a decent amount of time the other day trying to figure out why my active model including class wasn't generating the properly localized validation messages, and a note like this would have saved me a lot of time.
|
| | | | | | |
|
| | | | | | |
|
