| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #12638.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
SQLite3: Always close statements.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
SQLite3 adapter must make sure to close statements after queries.
Fixes: #13631
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Avoid unnecessary conditional block
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
GeneratedAttribute#column_name checks already for reference? on the
attribute returning the right name to use as symbol for label and field.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
rizwanreza/add-selected-documentation-to-select-tag
Add documentation to select_tag for :selected option
|
| | |_|_|_|/ /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
moktin/real_privacy_for_functions_in_predicate_builder
Give real privacy to class methods in AR::PredicateBuilder
|
|/ / / / / / |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |_|_|/ /
|/| | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
this reduces the number of comparisons and method calls `url_for`
requires. The nil case no longer calls `symbolize_keys`, we already
know options is nil, so no more ||=, and since it is nil we already know
that options[:host] will be nil too.
|
|\ \ \ \
| | | | |
| | | | | |
the use of ... in place >> using ... instead
|
|/ / / /
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Motivated by #14907.
|
|\ \ \ \
| | | | |
| | | | | |
Update the Getting Started tutorial
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Update the Getting Started tutorial to clarify where and how to add
controller actions, and fix some grammar.
This PR is an improved version of #14828, #14822 and #14815.
[skip ci]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
eileencodes/fix-delete-all-with-nil-dependency-to-not-produce-in-statement
Fix delete all with nil (:nullify) dependency to not produce in statement
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Test checks that SQL is the same for a loaded vs not loaded
association (category.categorizations, category.categorization.delete_all
vs category.cartegroization.delete_al). This was fixed for delete_all
dependency but was not fixed for no (:nullify, or nil) dependency).
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since clear shouldn't fire callbacks the order doesn't
matter since it was never updated. Remove the portion
of this test that tests for order after clear.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Clear should not call callbacks because it clear calls
delete_all and then returns self. It should behave the same
as delete_all. This test clarifies the goal of the test and
tests the correct outcome.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Nullify (or nil dependency) was doing the same thing delete_all
was doing in issue #14546, creating a large IN statement if
the association was loaded. Loaded and not loaded associations
should behave the same. The IN statement is also not great because
it's inefficient.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
[ci skip] updating active_record/associations to demonstrate where conflict with eager loading.
|
| | | | |
| | | | |
| | | | |
| | | | | |
with eager loading.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
eileencodes/breakup-complex-conditionals-on-delete
Breakup complex conditionals on delete
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
After reviewing this code I realized the conditional that was
there previously was basically saying if the dependency is not
delete all. This is a better, cleaner, and clearer way to write
this method.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now that we have a new method delete_all_with_dependency this
coupled conditional is no longer needed.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The delete method is very coupled with delete all even
though only a portion of the conditionals apply. Decoupling
this will make the code easier to understand and manipulate.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Added a missing `end`
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove double declaration of memcache services on travis
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit fd6d7835.
We are back on arel master, see b395265f.
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 28bd442034e0974d0a4d664076dafb8e9555816d.
Reason: Existing text was clearer imo.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 2aef9fddf8b4487a05638ea3341dfd65ceb229ef.
Reason: The added change isn't clear in terms of explaining the
arguments. Will ask the author to provide a PR and take it forward.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Revert Festival!
I reverted a reverted commit, undo.
This reverts commit 07ea37763d62e57d5709ab37da01b2848d12edd5.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reason: docrails policy is very strict about code. No matter how
innocent the change, if it is not documentation it needs to go
through a PR to rails/rails.
Plase see the warning box at the bottom of
http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation
This reverts commit e1c5d24369440857de1402d61c85d982b29d8019.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 9b1c077c91f09b64b8105f31fdf5240cd12c2e16.
my bad.
`assert_template` only accepts a String, Symbol, Hash, Regexp or nil.
`false`(layout: false) is provided as a Hash.
|
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|