aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Ensure `ToSql` collector returns a UTF-8 stringSean Griffin2017-07-212-1/+9
| | | | | | | | Switching from `''.dup` to `String.new` had the side effect of changing the encoding on Ruby 2.4 and later. Oddly, `String.new(encoding: Encoding::UTF_8)` is significantly slower than `''.dup`. This seems like a bug in Ruby, but not something we're going to address right now. A test has been added to ensure this regression doesn't occur again.
* Refactor `substitute_binds` to perform substitution immediatelySean Griffin2017-07-216-68/+35
| | | | | | | | | | | | | | | | | | I'm honestly not sure if replacing bind params with their concrete values is something that belongs in Arel at all, as it's something that will need to be coupled to the quoting mechanism of the caller, and could just be accomplished by using `Quoted` instead. Still, with the new structure we can provide a much simpler API around substitution. The expectation of the quoter responding to `quote` is a reasonably minimal API. I originally used `DelegateClass` here, with the one line override of `add_bind`, but realized that we have some funky code going on where the collector returns the next collector to use (in practice `self` is always returned, and I don't see why we'd ever want to do this). Removing that would likely be worthwhile, but would be a larger refactoring
* Add a value field `Nodes::BindParam`Sean Griffin2017-07-2114-125/+37
| | | | | | | | | | | | | | | | | | | | This is part of a greater refactoring to have the `BindParam` nodes hold onto their values. We want to generally keep the AST decoupled from what you're actually doing with those values, but ultimately the usage of `BindParam` is almost identical to how you'd use `Casted` or `Quoted`. Forcing consumers of Arel's API to maintain the bind values separately from the AST makes manipulating the AST essentially impossible, as you would need to perform a full walk of the AST to determine whether a given node contains bind parameters, and which value it maps to. By storing the value on the bind parameter directly, we can collect them in another AST pass (realistically it'll be part of the same pass that performs SQL construction for performance reasons). This will dramatically simplify AST manipulation for Rails or any other consumers that work with bind params. As part of this change I've removed the `BindVisitor`, which appears to be dead code, and had tests break from this change.
* Rename `Collectors::Bind`Sean Griffin2017-07-215-15/+4
| | | | | | The "bind collector" does not actually collect bind params at all, it substitutes them out of the final AST, replacing them with a quoted value.
* Merge pull request #484 from kirs/multiple-insert-v2Rafael França2017-06-155-0/+94
|\ | | | | Support INSERT with multiple values (v2)
| * Support INSERT with multiple valuesKir Shatrov2017-05-225-0/+94
| |
* | Merge pull request #472 from film42/masterMatthew Draper2017-06-055-4/+57
|\ \ | |/ |/| Make Visitor visit thread safe by holding dispatch method reference
| * Test concurrency of visitor superclass fallbackMatthew Draper2017-06-053-0/+51
| |
| * Make Visitor visit thread safe by holding dispatch method referenceGarrett Thornburg2017-02-172-4/+6
| |
* | Merge pull request #483 from kamipo/remove_unused_engineRafael França2017-05-052-3/+3
|\ \ | | | | | | Remove unused `engine`
| * | Remove unused `engine`Ryuta Kamizono2017-05-042-3/+3
| | | | | | | | | | | | | | | | | | Follow up of 98fc25991137ee09b6800578117f8c1c322680f2. `engine` is only used for `to_sql` and `where_sql` now.
* | | Add regression testRafael Mendonça França2017-05-041-0/+11
| | |
* | | Revert "Merge pull request #482 from kirs/multiple-insert"Rafael Mendonça França2017-05-047-54/+5
| | | | | | | | | | | | | | | | | | | | | This reverts commit 6d105c7f891a14316eab47dfff3bf1b94f3204e7, reversing changes made to 437aa3a4bb8ad4f3f4eba299dbb1112852f9c7ac. This broke Active Record when the values are sql literals
* | | Merge pull request #482 from kirs/multiple-insertRafael França2017-05-047-5/+54
|\ \ \ | |/ / |/| | Support multiple inserts
| * | Support multiple insertsKir Shatrov2017-05-017-5/+54
|/ /
* | Merge pull request #475 from PedroSena/chainable-insertRafael França2017-02-282-0/+8
|\ \ | | | | | | Made InsertManager#insert chainable
| * | Made InsertManager#insert chainablePedro Sena2017-02-282-0/+8
|/ /
* | Merge pull request #474 from JaKXz/patch-1Rafael França2017-02-221-1/+8
|\ \ | | | | | | docs: add distinct example to README
| * | docs(distinct): tweaks [skip ci]Jason Kurian2017-02-221-1/+1
| | |
| * | docs(distinct): fix distinct example [skip ci]Jason Kurian2017-02-221-2/+2
| | |
| * | docs: add distinct to READMEJason Kurian2017-02-221-1/+8
|/ /
* | Prepare to 8.0.0Rafael Mendonça França2017-02-212-1/+4
| |
* | Merge pull request #470 from kmmndr/named_function_eq_nilRafael França2017-02-211-0/+6
|\ \ | |/ |/| named functions compared to nil
| * named functions compared to nilThomas Kienlen2017-02-021-0/+6
| |
* | Merge pull request #471 from rails/frozen-string-literalRafael França2017-02-14132-1/+138
|\ \ | |/ |/| Enable frozen_string_literal in all files in arel
| * Enable frozen_string_literal in all files in arelRafael Mendonça França2017-02-13132-1/+138
|/
* Merge pull request #468 from zhufenggood/masterRafael França2017-01-301-4/+4
|\ | | | | Update to_sql.rb. Little performance improvement.
| * Performance improvement.zhufenggood2017-01-271-4/+4
|/
* Merge pull request #467 from composerinteralia/custom-errorsRafael França2017-01-176-2/+27
|\ | | | | Raise custom error on empty join
| * Raise custom error on empty joinDaniel Colson2017-01-176-2/+27
|/
* Merge pull request #463 from yahonda/use_assert_nilKasper Timm Hansen2016-12-301-2/+2
|\ | | | | Address `Use assert_nil if expecting nil` warnings
| * Address `Use assert_nil if expecting nil` warningsYasuo Honda2016-12-301-2/+2
|/
* Remove dead code now that attr is not used anymoreRafael Mendonça França2016-12-291-1/+1
|
* Merge pull request #462 from rails/arel-without-deprecationRafael França2016-12-299-157/+23
|\ | | | | Remove deprecated type cast support from Arel
| * Test with Ruby 2.4Rafael Mendonça França2016-12-291-0/+1
| |
| * Fix identationRafael Mendonça França2016-12-291-7/+7
| |
| * Bump arel to 8.0.0Rafael Mendonça França2016-12-291-1/+1
| |
| * Remove deprecated type cast support in ArelRafael Mendonça França2016-12-296-137/+14
| |
| * Remove dead codeRafael Mendonça França2016-12-291-12/+0
|/
* Arel master is alre 7.2Rafael Mendonça França2016-12-281-1/+1
| | | | closes #461
* Merge pull request #459 from danielpclark/patch-1Rafael França2016-12-191-1/+1
|\ | | | | missing asterisk
| * missing asteriskDaniel P. Clark2016-12-191-1/+1
|/
* Merge pull request #458 from mcls/patch-1Rafael França2016-12-011-0/+1
|\ | | | | Link to the API docs
| * Link to the API docsMaarten Claes2016-12-011-0/+1
|/
* Merge pull request #451 from kbrock/ignore_rbxMatthew Draper2016-10-151-0/+1
|\ | | | | Fix Build: Allow failures from rubinius
| * Allow failures from rubiniusKeenan Brock2016-10-141-0/+1
|/ | | | | | | | | | | | Per https://github.com/travis-ci/travis-ci/issues/5294 It looks like rvm is having trouble installing rubinius ``` rvm use rbx-2 --install --binary --fuzzy ``` I think this is the culpret for all builds failing since September
* Merge pull request #446 from abonec/deprecated_table_existsRafael França2016-10-102-2/+2
|\ | | | | use #data_source_exists? if possible instead of deprecated #table_exi…
| * use #data_source_exists? instead of deprecated #table_exists?Alexander Baronec2016-10-082-2/+2
|/
* Merge pull request #443 from mgbatchelor/masterRafael França2016-10-072-1/+12
|\ | | | | remove union mapping as :binary node when performing DepthFirst enumeration
| * remove union mapping as :binary node when performing DepthFirst enumerationMichael Batchelor2016-08-192-1/+12
| |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-16 06:28:58 +0000