| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| | |
Tell how to Create a Database in Error Message
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently if you attempt to use a database that does not exist you get an error:
```
PG::ConnectionBad FATAL: database "db_error" does not exist
```
The solution is easy, create and migrate your database however new developers may not know these commands by memory. Instead of requiring the developer to search for a solution, tell them how to fix the problem in the error message:
```
ActiveRecord::NoDatabase: FATAL: database "db_error" does not exist
Run `$ bin/rake db:create db:migrate` to create your database
```
Active Record should not know about `rake db:migrate` so this additional information needs to come from the railtie. Potential alternative implementation suggestions are welcome.
|
| | |
|
| |\
| |
| | |
On destroying do not touch destroyed belongs to association.
|
| |/
|
|
| |
Fixes: #13445
|
| |\
| |
| | |
Resolver test cases
|
| | | |
|
| |\ \
| | |
| | | |
Add missing av/railtie require
|
| |/ / |
|
| | | |
|
| |\ \
| | |
| | | |
Fix typecasting array of integers
|
| |/ /
| |
| |
| | |
Closes #13444
|
| | | |
|
| |/ |
|
| |\
| |
| | |
Fix DB Console tests
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
| |
The build is broken: https://travis-ci.org/rails/rails/builds/15824530
This commit fixes it.
The problem: Sqlite expects the `database` part to be an absolute path. That prompted this change to be committed to master: https://github.com/rails/rails/commit/fbb79b517f3127ba620fedd01849f9628b78d6ce
This change provides correct behavior. Unfortunately tests were introduced in https://github.com/rails/rails/commit/971d5107cd4cd08c22a85d34546f4ba03ed5c925 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as `mysql` or `postgresql`
In addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value.
|
| |\
| |
| | |
Enable memcached service on travis for running cache tests.
|
| | | |
|
| |\ \
| | |
| | | |
Add missing changelog entries and fix few typos
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ / |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
AC::Parameters#fetch was refactored in 7171111 to prevent self mutation, but
in doing so it hardcodes logic #convert_hashes_to_parameters is supposed to
encapsulate.
Better leave the delegation, and add a way to avoid mutating self in there.
|
| | | |
|
| |\ \
| | |
| | | |
Generates html and text templates for mailers by default.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
#13382]
|
| |/ / |
|
| |\ \
| | |
| | | |
Bump Jbuilder version to 2.0.0
|
| |/ / |
|
| |\ \
| | |
| | | |
Do not expect database user with app name to exist
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
By default when creating a project with `--database=postgresql` the `config/database.yml` file that is generated has a user specified that is the same as the app name
```
development:
adapter: postgresql
encoding: unicode
database: <%= app_name %>_development
pool: 5
username: <%= app_name %>
password:
```
This is counterintuitive and would rarely be valid. By default postgres creates a user with the current user name (http://www.postgresql.org/docs/9.3/static/database-roles.html) "it will have the same name as the operating system user that initialized the database cluster":
```
$ whoami
schneems
```
If the `username` is left out postgresql will assume that you wish to log in as the default user
```
$ psql -c '\du'
List of roles
Role name | Attributes | Member of
-----------+------------------------------------------------+-----------
schneems | Superuser, Create role, Create DB, Replication | {}
```
A good sensible default then for auto generated `database.yml` files is to remove the `username`, and have postgres attempt to connect to the database as the currently logged in user.
Instead of submitting with a blank password, don't submit a password.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
before:
ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
=> "3.14158999999999988261834005243144929409027099609375"
after:
ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
=> "3.14159000000000000000000000000000000000000000000000"
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add configuration option to optionally disable deep_munge
Conflicts:
actionpack/CHANGELOG.md
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Use sass-rails 4.0.0
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
fix CollectionAssociation's comments
|
| | | | | |
| | | | |
| | | | |
| | | | | |
AssociationProxy to match changes for 3.1 removing Association proxy.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Flag `config.assets.raise_runtime_errors` in dev
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
By default `config.assets.raise_runtime_errors` should be set to `true` in development for new apps.
Source: https://github.com/rails/sprockets-rails/pull/100
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Describe precision + scale in migrations guide
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Telling somebody that "precision sets the precision" is not very helpful.
Newbies want to know what precision is *for*, likewise with scale.
So I've added a very brief description for each.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
quoting: Check if id is a valid method before using it
|
| | | |_|_|_|/ /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Need to check if valud also respond_to :id before calling it, otherwise
things could explode.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Make `rails runner` command options more obvious
|
