Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Merge pull request #18149 from arthurnn/byebug_on_mri | Sean Griffin | 2014-12-22 | 2 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Only add debugger/byebug if on MRI | |||||
| * | | | | Only add debugger/byebug if on MRI | Arthur Neves | 2014-12-22 | 2 | -2/+2 | |
| | | | | | ||||||
* | | | | | Add `force: true` to table created in tests | Sean Griffin | 2014-12-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the test is interrupted in a way that the teardown block fails to run, the tests will fail to run until the table is removed manually without this option. | |||||
* | | | | | Correctly handle limit on int4 and int8 types in PG | Sean Griffin | 2014-12-22 | 2 | -2/+27 | |
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PG doesn't register it's types using the `int(4)` format that others do. As such, if we alias `int8` to the other integer types, the range information is lost. This is fixed by simply registering it separately. The other option (which I specifically chose to avoid) is to pass the information of the original type that was being aliased as an argument. I'd rather avoid that, since an alias should truly be treated the same. If we need different behavior for a different type, we should explicitly register it with that, and not have a conditional based on aliasing. Fixes #18144 [Sean Griffin & ysbaddaden] | |||||
* | | | | Merge branch 'master' of github.com:rails/rails | Zachary Scott | 2014-12-22 | 2 | -2/+2 | |
|\| | | | ||||||
| * | | | Use serve_static_files in guides, take 2 [skip ci] | Arthur Neves | 2014-12-22 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | Use serve_static_files in guides [skip ci] | Arthur Neves | 2014-12-22 | 2 | -2/+2 | |
| | | | | ||||||
* | | | | Remove this section, it adds no real value [ci skip] | Zachary Scott | 2014-12-22 | 1 | -4/+0 | |
|/ / / | ||||||
* | | | Add subheadings for these sections [ci skip] | Zachary Scott | 2014-12-22 | 1 | -0/+4 | |
| | | | ||||||
* | | | I'm sorry but I would rather not link to a 7 year old blog post [ci skip] | Zachary Scott | 2014-12-22 | 1 | -2/+0 | |
| | | | ||||||
* | | | Remove this line since we are using Rake to run our tests [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | s/are edited and rerun/required modifications [ci skip] | Zachary Scott | 2014-12-22 | 1 | -2/+2 | |
| | | | ||||||
* | | | document the return of `db:test:prepare`. Closes #18136. [ci skip] | Yves Senn | 2014-12-22 | 1 | -1/+10 | |
| | | | | | | | | | | | | | | | | | | This is a doc follow-up to #17739. /cc @zzak | |||||
* | | | Correctly handle Float -> BigDecimal with unspecified precision | Sean Griffin | 2014-12-22 | 2 | -1/+14 | |
| | | | | | | | | | | | | Fixes #18122 | |||||
* | | | Merge pull request #18099 from robsonmarques/fix_active_model_errors_add_docs | Zachary Scott | 2014-12-22 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | Fix inaccurate docs in active_model errors [ci skip] | |||||
| * | | | Fix inaccurate docs in active_model errors [ci skip] | Robson Marques | 2014-12-22 | 1 | -2/+2 | |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default value for the argument `message` in `ActiveModel::Errors#add` has a new behavior since ca99ab2481d44d67bc392d0ec1125ff1439e9f94. Before person.errors.add(:name, nil) # => ["is invalid"] After person.errors.add(:name, nil) # => [nil] | |||||
* | | | s/a unobtrusive/an unobtrusive [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #18105 from andreynering/guides-csrf | Zachary Scott | 2014-12-22 | 1 | -1/+8 | |
|\ \ \ | | | | | | | | | Add note about Ajax and CSRF-Token [ci skip] | |||||
| * | | | Add note about Ajax and CSRF-Token [ci skip] | Andrey Nering | 2014-12-20 | 1 | -1/+8 | |
| | | | | ||||||
* | | | | Merge pull request #18125 from codeodor/master | Zachary Scott | 2014-12-22 | 2 | -6/+11 | |
|\ \ \ \ | | | | | | | | | | | Clarify ActiveRecord testing guidelines [ci skip] | |||||
| * | | | | Clarify ActiveRecord testing guidelines [ci skip] | Sammy Larbi | 2014-12-21 | 2 | -6/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Specify that you need to create the test databases, and that no special Rails command needs to be run to do that. 2. Although the underscore style of `rake test_mysql` works, make the documentation of running the tests in RUNNING_UNIT_TESTS.rdoc consistent with the "Contributing..." guide. 3. Promote "Testing Active Record" to not be a subsection of "Running a Single Test," since it doesn't make sense as a subsection of that. | |||||
* | | | | | Merge pull request #18131 from y-yagi/fix_command_in_plugins_guide | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | `bin/rake` does not exist in plugin directory [ci skip] | |||||
| * | | | | | `bin/rake` does not exist in plugin directory [ci skip] | yuuji.yaginuma | 2014-12-22 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Better explain number of assertions per test [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Remove duplicate description of the previous line [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Fix NOTE for method naming in Ruby and add intro sentence to next section. | Zachary Scott | 2014-12-22 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | Removed run-on sentence and replace with sectional comments [ci skip] | Zachary Scott | 2014-12-22 | 1 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Better explain how test() methods get defined and kill this run-on sentence. | Zachary Scott | 2014-12-22 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | We may only look at some of the methods available from TestCase [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Better explain what `test_helper.rb` is designed for [ci skip] | Zachary Scott | 2014-12-22 | 1 | -1/+1 | |
| |_|_|/ / |/| | | | | ||||||
* | | | | | Merge pull request #18132 from rochefort/fix-typo-nodoc | Yves Senn | 2014-12-22 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix typo in nodoc [ci skip] | |||||
| * | | | | | Fix typo in nodoc | rochefort | 2014-12-22 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #18129 from ↵ | Guillermo Iguaran | 2014-12-21 | 2 | -14/+0 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | claudiob/remove-unused-sheep-fixture-from-action-view Remove unused Sheep fixture from AV | |||||
| * | | | | Remove unused Sheep fixture from AV | claudiob | 2014-12-22 | 2 | -14/+0 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `Sheep` fixture was added in eb23754e when moving template tests from actionpack to actionview, but it's not actually used in ActionView tests. The `Sheep` fixture is only used to test `uncountable` in ActiveModel tests, and is already defined in activemodel/test/models/sheep.rb | |||||
* | | | | Merge pull request #18126 from Decagon/patch-1 | Xavier Noria | 2014-12-21 | 1 | -1/+1 | |
|\ \ \ \ | |_|_|/ |/| | | | Remove extra bullet in README.md [ci skip] | |||||
| * | | | Remove bullet | Decagon | 2014-12-21 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #18118 from vipulnsward/fix-validation-message | Carlos Antonio da Silva | 2014-12-21 | 1 | -3/+2 | |
|\ \ \ | | | | | | | | | Validation test fixes | |||||
| * | | | - Fixed unused variable | Vipul A M | 2014-12-21 | 1 | -3/+2 | |
| | | | | | | | | | | | | | | | | - Changed test to verify complete message instead of verifying if message contains text. | |||||
* | | | | Merge pull request #18119 from joker1007/add_require_core_ext_hash_to_activejob | Sean Griffin | 2014-12-21 | 1 | -0/+2 | |
|\ \ \ \ | |_|/ / |/| | | | Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb | |||||
| * | | | Add 'require' for Hash#with_indifferent_access | joker1007 | 2014-12-21 | 1 | -0/+2 | |
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | ActiveJob::Arguments uses Hash#with_indifferent_access. But, activejob gem does not require Hash extension library. When we use activejob as standalone, we need extra require statement. This is unhandy. This commit fixes it. | |||||
* | | | Merge pull request #18124 from jonatack/patch-8 | Abdelkader Boudih | 2014-12-21 | 1 | -1/+1 | |
|\ \ \ | |/ / |/| | | Testing guide grammar fix | |||||
| * | | Testing guide grammar fix | Jon Atack | 2014-12-21 | 1 | -1/+1 | |
|/ / | | | | | [skip ci] | |||||
* | | We will be using the application already created in the Getting Started guide. | Zachary Scott | 2014-12-20 | 1 | -4/+2 | |
| | | | | | | | | [ci skip] | |||||
* | | Merge pull request #18114 from jonatack/patch-8 | Zachary Scott | 2014-12-20 | 1 | -1/+1 | |
|\ \ | | | | | | | Follow-up to d971021 [skip ci] | |||||
| * | | Follow-up to d9710212 [skip ci] | Jon Atack | 2014-12-21 | 1 | -1/+1 | |
|/ / | ||||||
* | | Fixture data is accessible by a local method, and not a variable [ci skip] | Zachary Scott | 2014-12-20 | 1 | -2/+2 | |
| | | ||||||
* | | Shorten the explaination of this to fit on one line [ci skip] | Zachary Scott | 2014-12-20 | 1 | -1/+1 | |
| | | ||||||
* | | s/folder/directory [ci skip] | Zachary Scott | 2014-12-20 | 1 | -7/+7 | |
| | | ||||||
* | | "In PostgreSQL, just superusers.." => "In PostgreSQL, only superusers.." | Zachary Scott | 2014-12-20 | 1 | -1/+1 | |
| | | | | | | | | [ci skip] | |||||
* | | Make sure this section is rendered as a `NOTE` and remove redundant sentence. | Zachary Scott | 2014-12-20 | 1 | -5/+1 | |
| | | | | | | | | [ci skip] |