aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | release notes, use past tense. [ci skip]Yves Senn2015-12-221-15/+15
| | | | |
* | | | | release notes, extract notable changes from Action Pack CHANGELOG.Yves Senn2015-12-222-24/+139
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | [ci skip] Steal `ActionCable.server` mounting from routes template.Kasper Timm Hansen2015-12-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Mounting it as prescribed here: https://github.com/rails/rails/blob/0d1d50c2db40ea1a9d3bebfb0c35da43bbd4d27f/railties/lib/rails/generators/rails/app/templates/config/routes.rb#L5
* | | | | release notes, extract notable changes from Railties CHANGELOG.Yves Senn2015-12-222-9/+53
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | guides, restructure Rails 5.0 release notes. [ci skip]Yves Senn2015-12-222-91/+160
|/ / / / | | | | | | | | | | | | | | | | xref #22701. xref #20612.
* | | | Merge pull request #22701 from maclover7/rails-5-release-notesYves Senn2015-12-221-0/+188
|\ \ \ \ | | | | | | | | | | [WIP] Rails 5 release notes [ci skip]
| * | | | Add Rails 5.0 Release NotesJon Moss2015-12-211-0/+188
| | |/ / | |/| | | | | | | | | | [ci skip]
* | | | Merge pull request #22483 from y-yagi/use_bin_test_in_plugins_guideYves Senn2015-12-221-32/+67
|\ \ \ \ | | | | | | | | | | use `bin/test` in plugins guide [ci skip]
| * | | | use `bin/test` in plugins guide [ci skip]yuuji.yaginuma2015-12-221-32/+67
| |/ / / | | | | | | | | | | | | | | | | `bin/test` can use the same API as the `bin/rails test`, since it is possible to run a flexible test than rake, I think better to use a guide even `bin/test`.
* | | | Merge pull request #22752 from y-yagi/remove_div_for_from_docMatthew Draper2015-12-221-8/+9
|\ \ \ \ | | | | | | | | | | do not use `div_for` in example [ci skip]
| * | | | do not use `div_for` in example [ci skip]yuuji.yaginuma2015-12-221-8/+9
| |/ / / | | | | | | | | | | | | `div_for` removed in 01e94ef
* | | | Merge pull request #22754 from ryohashimoto/151222_remove_content_tag_forMatthew Draper2015-12-221-7/+5
|\ \ \ \ | | | | | | | | | | remove content_tag_for example
| * | | | remove content_tag_for exampleRyo Hashimoto2015-12-221-7/+5
| | |/ / | |/| |
* | | | Merge pull request #22753 from gwincr11/keeps-options-breaks-assetsMatthew Draper2015-12-221-1/+1
|\ \ \ \ | |/ / / |/| | | Fix .keep file issue with ActionCable
| * | | Fix .keep file issue with ActionCableCory Gwin2015-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #22708 Make sure the channels file is create in assets/javascript/ so require tree works in asset pipeline.
* | | | Merge pull request #22746 from davidenglishmusic/masterGuillermo Iguaran2015-12-211-1/+1
|\ \ \ \ | | | | | | | | | | corrects a typo [ci-skip]
| * | | | corrects a typoDavid English2015-12-211-1/+1
|/ / / /
* | | | Merge pull request #22709 from ↵Rafael França2015-12-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jonatack/clarify-explanation-for-new-config-halt-callback-chains Clarify config settings for AS::halt_callback_chains_on_return_false
| * | | | Clarify config settings for AS::halt_callback_chains_on_return_falseJon Atack2015-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | [skip ci]
* | | | | Merge pull request #22745 from claudiob/fix-hartl-linkClaudio B2015-12-211-1/+1
|\ \ \ \ \ | |_|_|/ / |/| | | | Fix Rails tutorial link
| * | | | Fix Rails tutorial linkclaudiob2015-12-211-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] The old link is 404 not found. The link matches what the rest of the documentation already points to: * https://github.com/rails/rails/blame/2de2263118d6763c11a02db05079a5b7a97a0a34/guides/source/getting_started.md#L2052 * https://github.com/rails/rails/blame/2de2263118d6763c11a02db05079a5b7a97a0a34/README.md#L74
* | | | Merge pull request #22739 from akshay-vishnoi/fix-docsRafael França2015-12-211-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Fix typo
| * | | | [ci skip] Fix typoAkshay Vishnoi2015-12-221-1/+1
|/ / / /
* | | | Merge pull request #22685 from jeyb/remove_cable_files_for_skip_action_cableRafael França2015-12-212-0/+11
|\ \ \ \ | | | | | | | | | | Ensure Action Cable files are removed when `skip_action_cable` is set.
| * | | | Ensure Action Cable files are removed when `skip_action_cable` is set.Jey Balachandran2015-12-212-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Action Cable generators creates four files which need to be removed if `skip_action_cable` is set. 1. `app/assets/javascripts/cable.coffee` 2. `app/channels/application_cable/channel.rb` 3. `app/channels/application_cable/connection.rb` 4. `config/redis/cable.yml` Fixes #22669.
* | | | | Use the generators options to not generate channel assetsRafael Mendonça França2015-12-212-7/+6
| | | | |
* | | | | Merge pull request #22727 from prathamesh-sonpatki/fix-masterKasper Timm Hansen2015-12-211-1/+4
|\ \ \ \ \ | | | | | | | | | | | | Ensure that assets are enabled back after the test that tests assets are disabled
| * | | | | Ensure that assets are enabled back after the test that tests assets are ↵Prathamesh Sonpatki2015-12-211-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | disabled
* | | | | | Merge pull request #22736 from akshay-vishnoi/fix-changelogsRafael França2015-12-212-6/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] No more no changes entries in the CHANGELOGs (cases left in #22718)
| * | | | | | [ci skip] No more no changes entries in the CHANGELOGs (cases left in #22718)Akshay Vishnoi2015-12-222-6/+0
|/ / / / / /
* | | | | | Merge pull request #22735 from reshleman/patch-1Claudio B2015-12-211-2/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update "Support" in ActionCable README [ci skip]
| * | | | | | Update "Support" in ActionCable README [ci skip]Robert Eshleman2015-12-211-2/+10
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | * Add link to API documentation * Link to issue tracker for rails/rails (instead of rails/actioncable) * Add link to rails-core mailing list for feature requests
* | | | | | Remember the parameter hash we returnMatthew Draper2015-12-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Callers expect to be able to manipulate it.
* | | | | | Merge pull request #22693 from yui-knk/use_appropriate_rebuild_taskYves Senn2015-12-211-1/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use an appropriate rebuild task on Travis
| * | | | | | Use an appropriate rebuild task on Travisyui-knk2015-12-221-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use `db:mysql:rebuild` when testing mysql2, `db:postgresql:rebuild` when testing postgresql and no rebuild task when testing others.
* | | | | | | Merge pull request #22684 from ↵Yves Senn2015-12-213-1/+14
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | teknofire/fix-using-add_resource-with-a-block-after-gem-call Fix using add_resource with a block after gem in custom generators
| * | | | | | Fixes using `add_source` with a block after using `gem` in a custom railsWill Fisher2015-12-213-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | generator template.
* | | | | | | Merge pull request #22722 from k0kubun/use-cgi-html-escapeMatthew Draper2015-12-221-4/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Use CGI.escapeHTML for html escape
| * | | | | | | Use CGI.escapeHTML for html escapeTakashi Kokubun2015-12-211-4/+2
| | | | | | | |
* | | | | | | | Merge pull request #22717 from nning/actioncable-readme-fixesDavid Heinemeier Hansson2015-12-211-5/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | ActionCable README.md fixes
| * | | | | | | | One long dash in headline.henning mueller2015-12-211-1/+1
| | | | | | | | |
| * | | | | | | | Use default cable path in (in-app) server config example.henning mueller2015-12-211-3/+3
| | | | | | | | |
| * | | | | | | | Replaced "Cable" by "ActionCable" in CoffeeScript examples.henning mueller2015-12-211-2/+2
| | | | | | | | |
* | | | | | | | | Merge pull request #22692 from ryohashimoto/22669_api_generatorDavid Heinemeier Hansson2015-12-212-1/+33
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | Action Cable channel generator doesn't create JS assets if options[:rails][:assets] is false
| * | | | | | | | Action Cable channel generator should not create JS assets in --api modeRyo Hashimoto2015-12-192-1/+33
| | |_|_|/ / / / | |/| | | | | |
* | | | | | | | Merge pull request #22698 from y-yagi/display_detail_info_on_inline_reportKasper Timm Hansen2015-12-215-7/+19
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | display detailed information in inline reporting
| * | | | | | | | display detailed information in inline reportingyuuji.yaginuma2015-12-215-7/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The errors message only was not displayed, as if it did not use the inline reporting, modified to also information the method name and the like in error are displayed. ``` # before Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ``` ``` # after Failure: UserTest#test_the_truth: Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ```
* | | | | | | | | Revert "Merge pull request #22486 from ↵Yves Senn2015-12-213-26/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | methyl/fix-includes-for-groupped-association" This reverts commit 537ac7d6ade61e95f2b70685ff2236b7de965bab, reversing changes made to 9c9c54abe08d86967efd3dcac1d65158a0ff74ea. Reason: The way we preload associations will change the meaning of GROUP BY operations. This is illustrated in the SQL generated by the added test (failing on PG): Association Load: D, [2015-12-21T12:26:07.169920 #26969] DEBUG -- : Post Load (0.7ms) SELECT "posts".* FROM "posts" LEFT JOIN comments ON comments.post_id = posts.id WHERE "posts"."author_id" = $1 GROUP BY posts.id ORDER BY SUM(comments.tags_count) [["author_id", 1]] Preload: D, [2015-12-21T12:26:07.128305 #26969] DEBUG -- : Post Load (1.3ms) SELECT "posts".* FROM "posts" LEFT JOIN comments ON comments.post_id = posts.id WHERE "posts"."author_id" IN (1, 2, 3) GROUP BY posts.id ORDER BY SUM(comments.tags_count)
* | | | | | | | | Merge pull request #22719 from akshay-vishnoi/fix-docsYves Senn2015-12-211-3/+3
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [ci skip] `rails new project` generates README.md now
| * | | | | | | | | [ci skip] `rails new project` generates README.md nowAkshay Vishnoi2015-12-211-3/+3
| | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 18:33:04 +0000