aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | Renamed ‘Return’ to ‘Returns’ [ci skip]Ronak Jangir2015-09-287-9/+9
| | | | | | | | | |
| * | | | | | | | | Add a missing period to ActionMailer Base docs [ci skip]amitkumarsuroliya2015-09-281-1/+1
| | | | | | | | | |
| * | | | | | | | | [ci skip] Fix document of `ActionController::RequestForgeryProtection`yui-knk2015-09-281-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add `end` to end of class definition * add a blank line between explanation and example code
| * | | | | | | | | [ci skip] Add `:` before code blocks.yui-knk2015-09-251-1/+1
| | | | | | | | | |
| * | | | | | | | | Add a missing period to layouts_and_rendering.md [ci skip]Juanito Fatas2015-09-241-1/+1
| | | | | | | | | |
| * | | | | | | | | Documentation typoAkira Matsuda2015-09-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | Merge pull request #21861 from jeremy/rack-add-headerJeremy Daer2015-10-036-34/+37
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Introduce `Headers#add`. Move `Response#add_header` upstream.
| * | | | | | | | | | Introduce `Headers#add`. Move `Response#add_header` upstream.Jeremy Daer2015-10-036-34/+37
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Introduce `ActionDispatch::Http::Headers#add` to add a value to a multivalued header. * Move `Response#add_header` upstream: https://github.com/rack/rack/pull/957 * Match upstream `Response#have_header?` -> `#has_header?` name change.
* | | | | | | | | | Missed Gemfile change in f849cfe36c585fbc58c4a5fd91b0ae1571d38bcbJeremy Daer2015-10-031-4/+0
| | | | | | | | | |
* | | | | | | | | | YAGNI concurrent-ruby master branch now that 1.0.0.pre3 is released with ↵Jeremy Daer2015-10-031-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes for warnings and circular require
* | | | | | | | | | Revert "removing Rack::Runtime from the default stack."Aaron Patterson2015-10-037-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8. Jeremy is right that we shouldn't remove this. The fact is that many engines are depending on this middleware to be in the default stack. This ties our hands and forces us to keep the middleware in the stack so that engines will work. To be extremely clear, I think this is another smell of "the rack stack" that we have in place. When manipulating middleware, we should have meaningful names for places in the req / res lifecycle **not** have engines depend on a particular constant be in a particular place in the stack. This is a weakness of the API that we have to figure out a way to address before removing the constant. As far as timing attacks are concerned, we can reduce the granularity such that it isn't useful information for hackers, but is still useful for developers.
* | | | | | | | | | Merge pull request #21860 from vngrs/wrong_usage_of_a_in_docEileen M. Uchitelle2015-10-035-5/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Wrong usage of 'a' in docs fixed [ci skip]
| * | | | | | | | | | Wrong usage of 'a' in docs fixed [ci skip]Mehmet Emin İNAÇ2015-10-035-5/+5
| | |_|/ / / / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #21855 from acapilleri/save_perfSean Griffin2015-10-032-1/+3
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Add Singleton in NullMutationTracker class
| * | | | | | | | | | Add Singleton in NullMutationTracker classacapilleri2015-10-032-1/+3
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to reduce allocation of same object
* | | | | | | | | | Merge pull request #21853 from amitsuroliya/deprecated_string_middlewareKasper Timm Hansen2015-10-031-1/+1
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | Fixed deprecated string to specify the middleware [ci skip]
| * | | | | | | | | Fixed deprecated string to specify the middleware [ci skip]amitkumarsuroliya2015-10-031-1/+1
|/ / / / / / / / /
* | | | | | | | | Merge pull request #21852 from ↵Kasper Timm Hansen2015-10-033-1/+23
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | morgoth/support-array-in-assert_enqueued_jobs-for-only-option Support passing array to `assert_enqueued_jobs` in `:only` option
| * | | | | | | | | Support passing array to `assert_enqueued_jobs` in `:only` optionWojciech Wnętrzak2015-10-033-1/+23
|/ / / / / / / / /
* | | | | | | | | Merge pull request #21851 from y-yagi/use_class_to_specify_middlewareKasper Timm Hansen2015-10-032-6/+6
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | use class to specify the middleware [ci skip]
| * | | | | | | | use class to specify the middleware [ci skip]yuuji.yaginuma2015-10-032-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
* | | | | | | | | removing Rack::Runtime from the default stack.Aaron Patterson2015-10-027-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The runtime header is a potential target for timing attacks since it returns the amount of time spent on the server (eliminating network speed). Total time is also not accurate for streaming responses. The middleware can be added back via: ```ruby config.middleware.ues ::Rack::Runtime ```
* | | | | | | | | Merge pull request #21842 from morgoth/mark-private-methods-as-nodocRafael Mendonça França2015-10-021-5/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Do not document private methods in AJ::TestHelper
| * | | | | | | | | Do not document private methods in AJ::TestHelperWojciech Wnętrzak2015-10-021-5/+5
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | [CI skip]
* | | | | | | | | Merge pull request #21809 from yui-knk/fix_doc_am_serializationSean Griffin2015-10-021-3/+3
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [ci skip] Fix explanation of `ActiveModel::Serialization`
| * | | | | | | | | [ci skip] Fix explanation of `ActiveModel::Serialization`yui-knk2015-10-021-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This explanation was change by https://github.com/rails/rails/commit/7a27de2b. This change reversed the including module (`ActiveModel::Serializers::JSON`) and the included module (`ActiveModel::Serialization`) by mistake.
* | | | | | | | | | Merge pull request #21839 from andyatkinson/remove-unusued-scopesSean Griffin2015-10-023-10/+0
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Remove unused scopes
| * | | | | | | | | | Remove unused scopesAndy Atkinson2015-10-013-10/+0
| | | | | | | | | | |
* | | | | | | | | | | Build the `AttributeMutationTracker` lazilySean Griffin2015-10-022-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For reads, we never need to construct this object. The double `defined?` check is to avoid errors in tests
* | | | | | | | | | | Merge pull request #20600 from ↵Andrew White2015-10-022-7/+6
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/xmlschema-should-display-more-than-6-digits TimeWithZone#xmlschema should be able to display more than 6 digits
| * | | | | | | | | | | TimeWithZone#xmlschema should be able to display more than 6 digitsFumiaki MATSUSHIMA2015-09-302-7/+6
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #21539 from tgxworld/parameters_not_sanitizedSean Griffin2015-10-024-7/+64
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Fix AC::Parameters not being sanitized for query methods.
| * | | | | | | | | | | | Fix AC::Parameters not being sanitized for query methods.Guo Xiang Tan2015-10-024-7/+64
| | |_|_|/ / / / / / / / | |/| | | | | | | | | |
* | | | | | | | | | | | 💣Sean Griffin2015-10-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I misread this test in https://github.com/rails/rails/commit/1a693c79c32cba070256fdb7bd1990c3d07d554f
* | | | | | | | | | | | Fix test failures on MySQLSean Griffin2015-10-023-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were a few places where I missed a `create` vs `new` before_type_cast check, and the semantics of `reload` became wrong.
* | | | | | | | | | | | Further encapsulate dirty checking on `Attribute`Sean Griffin2015-10-026-51/+99
|/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can skip the allocation of a full `AttributeSet` by changing the semantics of how we structure things. Instead of comparing two separate `AttributeSet` objects, and `Attribute` is now a singly linked list of every change that has happened to it. Since the attribute objects are immutable, to apply the changes we simply need to copy the head of the list. It's worth noting that this causes one subtle change in the behavior of AR. When a record is saved successfully, the `before_type_cast` version of everything will be what was sent to the database. I honestly think these semantics make more sense, as we could have just as easily had the DB do `RETURNING *` and updated the record with those if we had things like timestamps implemented at the DB layer. This brings our performance closer to 4.2, but we're still not quite there.
* | | | | | | | | | | Merge pull request #21838 from jeremy/response-add-headerJeremy Daer2015-10-012-0/+79
|\ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / |/| | | | | | | | | | Response#add_header for adding to multi-valued headers like Vary
| * | | | | | | | | | Response#add_header for adding to multi-valued headers like VaryJeremy Daer2015-10-012-0/+79
|/ / / / / / / / / /
* | | | | | | | | | Merge pull request #21836 from jeremy/no-nil-set-cookie-headersJeremy Daer2015-10-012-75/+96
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Don't set a nil Set-Cookie header when there aren't any cookies
| * | | | | | | | | | Don't set a nil Set-Cookie header when there aren't any cookies. Omit the ↵Jeremy Daer2015-10-012-75/+96
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | header.
* | | | | | | | | | Merge pull request #21757 from Gaurav2728/gaurav-adding_x_frame_testKasper Timm Hansen2015-10-011-1/+11
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | adding test for content type with default charset
| * | | | | | | | | | adding test for content type with default charsetGaurav Sharma2015-10-021-1/+11
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * first test is for `default_charset` i.e `ActionDispatch::Response.default_charset = “utf-8”` * In below test we are passing `ActionDispatch::Response.default_charset = 'utf-16’` so name of the test is irrelevant — “read content type without charset”
* | | | | | | | | | Merge pull request #20599 from aliaksandrb/regex_fix_for_mattr_accessorArthur Nogueira Neves2015-10-012-2/+16
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Regex fix for mattr_accessor validation
| * | | | | | | | | | Regex fix for mattr_accessor validationAliaksandr Buhayeu2015-10-012-2/+16
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change ^ and $ operators to \A and \z to prevent code injection after the line breaks
* | | | | | | | | | Merge pull request #21760 from repinel/refactor-as-callbacks-halt-configKasper Timm Hansen2015-10-019-36/+38
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Refactor AS::Callbacks halt config and fix the documentation
| * | | | | | | | | | Refactor AS::Callbacks halt config and fix the documentationRoque Pinel2015-10-019-36/+38
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false` to `AS::Callbacks.halt_and_display_warning_on_return_false` base on [this discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580) Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
* | | | | | | | | | Merge pull request #21823 from prakashlaxkar/test_casesKasper Timm Hansen2015-10-011-0/+12
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Added test cases for checkbox_tag
| * | | | | | | | | | Add test cases for checkbox_tagPrakash Laxkar2015-10-011-0/+12
|/ / / / / / / / / /
* | | | | | | | | | make sure exceptions are marshalable when returning test resultsAaron Patterson2015-09-301-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this should fix the error where isolation tests raise an exception and we just get a marshal error
* | | | | | | | | | Merge pull request #21821 from akshay-vishnoi/fix-test-casesKasper Timm Hansen2015-09-301-1/+7
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Add test cases for text_field_tag
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 15:35:24 +0000