| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
yhirano55/update_autoloading_and_reloading_constants
Update Autoloading and Reloading Constants guide [ci skip]
|
|/
|
|
| |
[ci skip]
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Add executable file `activestorage/bin/test`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
rails$ cd activestorage/
rails/activestorage$ bin/test
........(compressed)....
rails/activestorage$ bin/test test/controllers/disk_controller_test.rb
.(compressed)..
rails/activestorage$ bin/test test/controllers/disk_controller_test.rb:42
.
```
|
|\ \
| | |
| | | |
Add expiry metadata to Cookies and freshen expires option to support duration
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|/|
| |
| |
| | |
This is only used for the internal `column_spec` and
`column_spec_for_primary_key`.
|
|\ \
| | |
| | |
| | |
| | | |
yhirano55/update_debugging_rails_applications_guide
Update Debugging Rails Applications guide [ci skip]
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
currently integer types extracts the `limit` from `sql_type`. But the
lookup key of type map is the `oid` in postgresql adapter. So in most
case `sql_type` is passed to `extract_limit` as `""` and `limit` is
extracted as `nil`.
https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L445
In mysql2 adapter, `limit` is registered correctly without extracting
from `sql_type`.
https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L678-L682
Postgresql adapter should also be registered correctly.
``` ruby
conn = ActiveRecord::Base.connection
conn.select_all("SELECT 1::smallint, 2::integer, 3::bigint").column_types.map do |name, type|
[name, type.limit]
end
```
Before:
``` ruby
# => [["int2", nil], ["int4", nil], ["int8", nil]]
```
After:
``` ruby
# => [["int2", 2], ["int4", 4], ["int8", 8]]
```
|
|\ \
| | |
| | |
| | |
| | | |
yhirano55/update_rails_initialization_process_guide
Update The Rails Initialization Process of guide [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
yhirano55/update_database_config_in_command_line_of_guide
Update database config in The Rails Comamnd Line of guide [ci skip]
|
| |/ / |
|
|/ / |
|
|\ \
| | |
| | | |
Fix doc format in Active Storage Setup [ci skip]
|
|/ /
| |
| |
| | |
Follow up of 2ebb284ef5bf2c36bd8ba0a4524cab83810f12ab.
|
|\ \
| | |
| | | |
Fix `can't modify frozen String` error in an AR test
|
|/ / |
|
|\ \
| | |
| | | |
Fix typo in "Ambiguous route definition" error message
|
|/ / |
|
|\ \
| | |
| | | |
Remove unused require
|
| | |
| | |
| | |
| | | |
Since 0d72489, this file does not use `method_source`.
|
|\ \ \
| |/ /
|/| | |
Use https in guide and comment [ci skip]
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
DNNX/rm-pointless-flatten-and-compact-from-am-errors
Simplify ActiveModel::Errors#generate_message
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Besides making the code easier to read, this commit
also makes it faster:
* We don't eval `@base.class.respond_to?(:i18n_scope)` twice
* We only eval `@base.class.i18n_scope` once
* We don't call `flatten!` because it's not needed anymore
* We don't call `compact` because all elements are Symbols
|
|\ \ \
| | | |
| | | | |
Use https instead of http or git in guide [ci skip]
|
|/ / /
| | |
| | |
| | | |
* Update url in Development Dependencies Install
|
| | |
| | |
| | |
| | |
| | |
| | | |
Lots of grammar cleanup, and also changing to use macOS.
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a requirement when working on the JS portions of ASt. Using
npm instead of Yarn is a bad idea here since the lockfile is in Yarn's
format.
[ci skip]
|
|\ \ \
| | | |
| | | | |
Remove Active Storage code climate config file
|
|/ / /
| | |
| | |
| | | |
There's already a .codeclimate.yml file at the root of the project.
|
| | |
| | |
| | |
| | |
| | | |
* Test `test_unabstracted_database_dependent_types` for `PostgreSQLAdapter`
* Add `test_change_column_with_new_precision_and_scale` for `SQLite3Adapter`
* This test case and comment was lost at 28bb02a78fd47527bb7a208d01a4594bb212812c
|
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise random CI failure will be caused.
https://travis-ci.org/rails/rails/jobs/265848046#L777
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
(#29944)
Since 213796f, it was lost the ability that SQL with binds for `insert`,
`update`, and `delete` (like `select_all`). This restores the ability
because `insert`, `update`, and `delete` are public API, so it should
not be removed without deprecation.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
affected by scoping (#29997)
I tried to change the expectation in #29976, but it is expected behavior
at least for now. So I added the test cases to prevent anyone change the
expectation.
|
| | |
| | |
| | |
| | | |
Because `to_sql` is public API. I introduced `to_sql_and_binds` internal
API to return SQL and binds.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`where.not` with multiple conditions is still unexpected behavior. But
`where.not` with only polymorphic association has already been fixed in
213796fb.
Closes #14161.
Closes #16983.
Closes #17010.
Closes #26207.
|
|\ \ \
| | | |
| | | | |
Move common tests to `SharedGeneratorTests`
|
| | | |
| | | |
| | | |
| | | | |
`SharedGeneratorTests`
|
|\ \ \ \
| | | | |
| | | | | |
Faster and more readable implementation of Hash#deep_merge
|