Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Replace `class_eval` with `define_method` for enum | Vitaly Tatarintsev | 2013-11-04 | 1 | -4/+12 | |
| |/ / | | | | | | | | | | https://github.com/rails/rails/commit/db41eb8a6ea88b854bf5cd11070ea4245e1639c5#commitcomment-4502683 | |||||
* | | | Fix typo in railties changelog | Carlos Antonio da Silva | 2013-11-04 | 1 | -2/+2 | |
| | | | | | | | | | | | | Also improve the example to show as shell command [ci skip] | |||||
* | | | Fix changelog indent [ci skip] | Carlos Antonio da Silva | 2013-11-04 | 1 | -6/+6 | |
|/ / | ||||||
* | | BACKTRACE environment variable to show unfiltered backtraces. | Yves Senn | 2013-11-04 | 3 | -6/+48 | |
| | | | | | | | | | | | | | | | | | | | | | | We used to support the `BACKTRACE` environment variable but when we switched to MiniTest it got removed: f9382cd7948 This commit adds back the functionality to show the unfiltered backtrace when needed. This also works when you run your tests with `rake`: * `BACKTRACE=1 bin/rake test` * `BACKTRACE=1 ruby -Itest ...` | |||||
* | | Merge pull request #12750 from arunagw/webconsole-invite-only | Guillermo Iguaran | 2013-11-03 | 3 | -15/+0 | |
|\ \ | | | | | | | Not adding webconsole by default in new apps | |||||
| * | | No web-console for now | Arun Agrawal | 2013-11-03 | 3 | -15/+0 | |
|/ / | ||||||
* | | Line up the comments for aesthetics | David Heinemeier Hansson | 2013-11-03 | 1 | -5/+5 | |
| | | ||||||
* | | Aesthetics | David Heinemeier Hansson | 2013-11-03 | 1 | -22/+30 | |
| | | ||||||
* | | Code style for privacy indention | David Heinemeier Hansson | 2013-11-03 | 1 | -8/+8 | |
| | | ||||||
* | | Ensure backwards compability after the #deep_munge extraction | David Heinemeier Hansson | 2013-11-03 | 1 | -0/+10 | |
| | | ||||||
* | | Add test verifying that you can only sort ARs of the same type | David Heinemeier Hansson | 2013-11-02 | 1 | -1/+7 | |
| | | ||||||
* | | Revert "ActiveRecord::Base#<=> has been removed. Primary keys may not be in ↵ | David Heinemeier Hansson | 2013-11-02 | 3 | -12/+16 | |
| | | | | | | | | | | | | | | | | | | order," -- will be replaced with a check to ensure that the keys used for comparison are integers, and only fail if they are not. This reverts commit 6256734e2d0bdd89f4b5d11da259d40afa0c95c7. Conflicts: activerecord/CHANGELOG.md | |||||
* | | Delegate #rewhere to all on the class like all other relation methods | David Heinemeier Hansson | 2013-11-02 | 2 | -1/+5 | |
| | | ||||||
* | | Move documentation around a bit | David Heinemeier Hansson | 2013-11-02 | 1 | -4/+7 | |
| | | ||||||
* | | Merge pull request #12747 from yury/explicit-enum-values | David Heinemeier Hansson | 2013-11-02 | 4 | -1/+15 | |
|\ \ | | | | | | | Explicit mapping for enum | |||||
| * | | Explicit mapping for enum | Yury Korolev | 2013-11-02 | 4 | -1/+15 | |
| | | | ||||||
* | | | Added ActiveRecord::QueryMethods#rewhere which will overwrite an existing, ↵ | David Heinemeier Hansson | 2013-11-02 | 3 | -0/+52 | |
| | | | | | | | | | | | | named where condition. | |||||
* | | | unscope now works on default_scope after ↵ | Rafael Mendonça França | 2013-11-02 | 3 | -9/+9 | |
|/ / | | | | | | | 94924dc32baf78f13e289172534c2e71c9c8cade | |||||
* | | Add a test case for the scope enum adds | David Heinemeier Hansson | 2013-11-02 | 1 | -0/+4 | |
| | | ||||||
* | | Extend ActiveRecord::Base#cache_key to take an optional list of timestamp ↵ | David Heinemeier Hansson | 2013-11-02 | 4 | -2/+27 | |
| | | | | | | | | attributes of which the highest will be used. | |||||
* | | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2013-11-02 | 10 | -94/+48 | |
|\ \ | ||||||
| * | | Use an already existing fixture | Carlos Antonio da Silva | 2013-11-02 | 1 | -1/+1 | |
| | | | ||||||
| * | | Fix to work on Ruby 1.9.3, example and changelog improvements | Carlos Antonio da Silva | 2013-11-02 | 4 | -34/+34 | |
| | | | ||||||
| * | | Improve wording in AC::ParameterMissing error message | Guillermo Iguaran | 2013-11-02 | 1 | -1/+1 | |
| | | | ||||||
| * | | Update guides welcome page to point to version 3.2.15 [ci skip] | Carlos Antonio da Silva | 2013-11-02 | 1 | -1/+1 | |
| | | | ||||||
| * | | Revert "Merge pull request #9660 from ↵ | Guillermo Iguaran | 2013-11-02 | 5 | -57/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour" This reverts commit c2b5a8e61ba0f35015e6ac949a5c8fce2042a1f2, reversing changes made to 1918b12c0429caec2a6134ac5e5b42ade103fe90. See: https://github.com/rails/rails/pull/9660#issuecomment-27627493 | |||||
* | | | Added Numeric#in_milliseconds, like 1.hour.in_milliseconds, so we can feed ↵ | David Heinemeier Hansson | 2013-11-02 | 3 | -0/+14 | |
|/ / | | | | | | | them to JavaScript functions like getTime(). | |||||
* | | Added ActiveRecord::Base#enum for declaring enum attributes where the values ↵ | David Heinemeier Hansson | 2013-11-02 | 7 | -2/+128 | |
| | | | | | | | | map to integers in the database, but can be queried by name | |||||
* | | Merge pull request #12686 from kryzhovnik/master | Carlos Antonio da Silva | 2013-11-02 | 1 | -6/+6 | |
|\ \ | | | | | | | | | | | | | | | | | | | Minor doc fix of ActiveModel::Naming. [ci skip] Conflicts: activemodel/lib/active_model/naming.rb | |||||
| * | | Minor doc fix of ActiveModel::Naming. | Andrey Samsonov | 2013-10-29 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | - qoute example line's result when it kind of String - right ("singular_route_key") method in example | |||||
* | | | Merge pull request #9660 from ↵ | Guillermo Iguaran | 2013-11-01 | 5 | -11/+57 | |
|\ \ \ | | | | | | | | | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour Change ActionController::Parameters#require behavior when value is empty | |||||
| * | | | Change ActionController::Parameters#require behavior when value is empty | Sebastian Sogamoso | 2013-03-11 | 5 | -11/+57 | |
| | | | | | | | | | | | | | | | | | | | | When the value for the required key is empty an ActionController::ParameterMissing is raised which gets caught by ActionController::Base and turned into a 400 Bad Request reply with a message in the body saying the key is missing, which is misleading. With these changes, ActionController::EmptyParameter will be raised which ActionController::Base will catch and turn into a 400 Bad Request reply with a message in the body saying the key value is empty. | |||||
* | | | | Fix wrong behavior where associations with dependent: :destroy options | Rafael Mendonça França | 2013-11-01 | 3 | -10/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | was using nullify strategy This caused a regression in applications trying to upgrade. Also if the user set the dependent option as destroy he expects to get the records removed from the database. | |||||
* | | | | Merge pull request #12739 from laurocaetano/remove_warnings_for_ruby_trunk | Rafael Mendonça França | 2013-11-01 | 5 | -6/+6 | |
|\ \ \ \ | | | | | | | | | | | Remove warnings on ruby trunk | |||||
| * | | | | remove warnings on ruby trunk | laurocaetano | 2013-11-01 | 5 | -6/+6 | |
|/ / / / | ||||||
* | | | | Test with the right association | Rafael Mendonça França | 2013-11-01 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #12733 from robin850/fix-railties-build | Rafael Mendonça França | 2013-11-01 | 5 | -6/+6 | |
|\ \ \ \ | | | | | | | | | | | Fix railties build | |||||
| * | | | | Fix some failing tests for Rails::Paths | Robin Dupret | 2013-11-01 | 2 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Since we are not using the File.exists? alias which raises a warning on current ruby trunk, few stubs are wrong. | |||||
| * | | | | Set the destination_root for plugins | Robin Dupret | 2013-11-01 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the plugin generator is relying on the application one, we need to define the proper root when creating the plugin. The AppBase class is not setting the destination_root (this is done via the AppGenerator) | |||||
| * | | | | Remove "circular require considered harmful" error | Robin Dupret | 2013-11-01 | 2 | -3/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | rails/generators should not load rails/generators/base since the latter is loading it. | |||||
* | | | | | Merge pull request #12735 from linstula/fix-typo-in-responder-comment | Rafael Mendonça França | 2013-11-01 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix typo in method description in Responder class | |||||
| * | | | | | Fix typo in method description in Responder class | Lin Reid | 2013-11-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Fixes a typo in the description for the call class method in Responder. | |||||
* | | | | | | Merge pull request #12728 from arunagw/aa-warnings-removed-ruby-trunk | Rafael Mendonça França | 2013-11-01 | 19 | -31/+31 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | More Warnings removed for ruby trunk | |||||
| * | | | | | shadowing variable warning removed | Arun Agrawal | 2013-11-01 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | More Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 19 | -30/+30 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | |||||
* | | | | | | :bomb: | Rafael Mendonça França | 2013-11-01 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Use consistent order of the arguments | Rafael Mendonça França | 2013-11-01 | 1 | -9/+9 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #12729 from arunagw/build-fixed-ruby193 | Rafael Mendonça França | 2013-11-01 | 2 | -2/+8 | |
|\ \ \ \ \ | | | | | | | | | | | | | Can't used named argument in ruby 1.9.3 | |||||
| * | | | | | Passing args for gemfile entry | Arun Agrawal | 2013-11-01 | 2 | -2/+8 | |
| |/ / / / | | | | | | | | | | | | | | | | Fixing build | |||||
* | | | | | Merge pull request #12732 from razielgn/additional-rbx-dep | Rafael Mendonça França | 2013-11-01 | 1 | -0/+1 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Added rubysl-rexml to Rubinius deps. |