aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #5569 from arunagw/warning_remove_masterVijay Dev2012-03-241-1/+1
|\ | | | | removed warning: shadowing outer local variable - exception
| * removed warning: shadowing outer local variable - exceptionArun Agrawal2012-03-241-1/+1
|/
* Merge pull request #5567 from tpope/xhr-booleanAaron Patterson2012-03-231-1/+1
|\ | | | | Return an actual boolean from xml_http_request?
| * Return an actual boolean from xml_http_request?Tim Pope2012-03-231-1/+1
|/
* oops, forgot to commit the tests! :bomb:Aaron Patterson2012-03-231-0/+67
|
* chdir before globbing so that we don't need to escape directory names.Aaron Patterson2012-03-231-1/+30
| | | | fixes #5521
* Merge pull request #5550 from schneems/schneems/server_envAaron Patterson2012-03-234-0/+63
|\ | | | | Fix environment support for rails server, and match interface of rails console
| * match rails console environment support, to serverschneems2012-03-222-0/+32
| | | | | | | | rails server takes `-e` as an argument to specify RAILS_ENV, rails console currently does not have the same interface. This commit fixes this disparity so developers can manually specify `RAILS_ENV` or can pass in an environment with a `-e`.
| * fix rails server support of RAILS_ENV variableschneems2012-03-202-0/+31
| | | | | | | | | | | | | | When launching rails server from the command line with a rails environment specified such as `rails server RAILS_ENV=production` an error would occur since rails will try to use `RAILS_ENV=production` as it's server. When launching rails with a specified server such as thin `rails server thin RAILS_ENV=production` no error will be thrown, but rails will not start up in the specified environment. This fixes both of those cases
* | Merge pull request #5518 from rafaelfranca/minor-refactorJosé Valim2012-03-231-11/+11
|\ \ | | | | | | Remove code duplication
| * | Remove code duplicationRafael Mendonça França2012-03-191-11/+11
| | |
* | | Merge pull request #5556 from rafaelfranca/remove-warningPiotr Sarnacki2012-03-231-1/+1
|\ \ \ | | | | | | | | use the new scope syntax on the tests to avoid DEPRECATION WARNINGS.
| * | | Use the new scope syntaxRafael Mendonça França2012-03-231-1/+1
|/ / /
* | | Merge pull request #5374 from ↵José Valim2012-03-232-28/+1
|\ \ \ | | | | | | | | | | | | | | | | nertzy/remove_deprecated_partial_path_from_active_model_naming Remove ActiveModel::Naming#partial_path
| * | | Remove ActiveModel::Naming#partial_pathGrant Hutchins2012-03-102-28/+1
| | | | | | | | | | | | It was deprecated in 3.2
* | | | Fix tests, when creating rescue handler, we need to check for arity nowPiotr Sarnacki2012-03-231-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | Before it was handled by Proc.bind, but since Proc.bind has been deprecated, this is no longer the case and returned handler needs to match rescuer.
* | | | Merge pull request #5546 from mptre/masterPiotr Sarnacki2012-03-232-4/+5
|\ \ \ \ | | | | | | | | | | Fixed missing space bug introduces in rails/rails@9299bfd
| * | | | Fixed missing space bug introduces in ↵Anton Lindqvist2012-03-222-4/+5
| | | | | | | | | | | | | | | | | | | | rails/rails@9299bfdcd387253d83b645c205b8df477f2d0940.
* | | | | properly namespace the fixture exceptionAaron Patterson2012-03-222-7/+3
| | | | |
* | | | | Merge pull request #5552 from lest/patch-3Aaron Patterson2012-03-223-6/+11
|\ \ \ \ \ | |/ / / / |/| | | | deprecate Proc#bind that can cause symbol memory leak
| * | | | deprecate Proc#bind that can cause symbol memory leakSergey Nartimov2012-03-223-6/+11
|/ / / /
* | | | Merge pull request #5540 from mhfs/another_blank_line_fixPiotr Sarnacki2012-03-212-2/+1
|\ \ \ \ | | | | | | | | | | Avoid another blank line in generated migration and remove assertion as per @spastorino request
| * | | | Avoid another blank line in generated migration and remove assertion as per ↵Marcelo Silveira2012-03-212-2/+1
| | | | | | | | | | | | | | | | | | | | @spastorino request
* | | | | remove duplicate requires. thanks @atamboAaron Patterson2012-03-211-1/+0
| | | | |
* | | | | evented listeners can subscribe to any messageAaron Patterson2012-03-211-9/+27
| | | | |
* | | | | evented subscribers workAaron Patterson2012-03-211-6/+10
| | | | |
* | | | | start / finish events are sent by the instrumenterAaron Patterson2012-03-212-7/+41
| | | | |
* | | | | push the autoloads up to requiresAaron Patterson2012-03-211-4/+4
|/ / / /
* | | | Deprecate eager-evaluated scopes.Jon Leighton2012-03-2120-83/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
* | | | Avoid obscure &Proc.new thingJon Leighton2012-03-211-2/+2
| | | |
* | | | Remove valid_scope_name? check - use rubyJon Leighton2012-03-212-30/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods.
* | | | no need for castJon Leighton2012-03-211-1/+0
| | | |
* | | | no need for lvarJon Leighton2012-03-211-3/+1
| | | |
* | | | split subscribers based on pattern typeAaron Patterson2012-03-211-13/+31
| | | |
* | | | Merge pull request #5532 from mhfs/migration_blank_lineJosé Valim2012-03-212-1/+2
|\ \ \ \ | | | | | | | | | | Remove blank line from generated migration
| * | | | Remove blank line from generated migrationMarcelo Silveira2012-03-202-1/+2
| | |_|/ | |/| |
* | | | Merge pull request #5522 from ↵José Valim2012-03-212-0/+21
|\ \ \ \ | |/ / / |/| | | | | | | | | | | travisjeffery/fix_migration_generator_adding_removing_index Fix adding/removing field's index when generating migration
| * | | Generate Migration Thats Adds Removed IndexTravis Jeffery2012-03-212-0/+21
|/ / / | | | | | | | | | | | | When generating a migration that removes a field with an index, the down will add both the field and its index.
* | | We dont need to merge in the parameters as thats all being reset by the rack ↵David Heinemeier Hansson2012-03-201-1/+0
| | | | | | | | | | | | headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
* | | probably should require the objects we monkey patch.Aaron Patterson2012-03-201-0/+1
| | |
* | | search private and protected methods for convert_keyAaron Patterson2012-03-202-3/+3
| | |
* | | bigdecimal can be duped on Ruby 2.0Aaron Patterson2012-03-202-2/+22
| | |
* | | guides location has changed [ci skip]Vijay Dev2012-03-201-1/+1
| | |
* | | Merge pull request #5524 from kennyj/add_missing_requireXavier Noria2012-03-201-0/+1
|\ \ \ | |_|/ |/| | Add missing require
| * | Add missing requirekennyj2012-03-201-0/+1
|/ /
* | Merge pull request #5515 from rafaelfranca/remove-excludeJosé Valim2012-03-192-14/+29
|\ \ | | | | | | Remove exclude option from ActionDispatch::SSL and fix secure cookies
| * | Fix secure cookies when there are more than one space before the secureRafael Mendonça França2012-03-192-1/+29
| | | | | | | | | | | | keyword
| * | Remove exclude option from ActionDispatch::SSLRafael Mendonça França2012-03-192-13/+0
|/ /
* | Merge pull request #5503 from jeyb/leap_day_time_date_time_selectorAndrew White2012-03-193-13/+27
|\ \ | | | | | | Fixes issue #5222: DateTimeSelector builds invalid dates on leap days
| * | Fixes issue #5222: DateTimeSelector builds invalid dates on leap day when ↵Jey Balachandran2012-03-183-13/+27
| | | | | | | | | | | | discarding both day and month.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-16 03:56:53 +0000