Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Correct fixed-width doc syntax, thanks to @sikachu for pointing it out! | Zachary Scott | 2014-11-03 | 2 | -2/+2 |
| | | | | From dc5854f and c07c0b2 [ci skip] | ||||
* | Document included ability of AJ::QueueName module for class methods [ci skip] | Zachary Scott | 2014-11-03 | 1 | -0/+1 |
| | |||||
* | Add documentation of AJ::QueueAdapter class methods module [ci skip] | Zachary Scott | 2014-11-03 | 1 | -0/+1 |
| | |||||
* | Document AJ::Execution class methods module [ci skip] | Zachary Scott | 2014-11-03 | 1 | -0/+1 |
| | |||||
* | Document the module which includes `perform_later` for AJ::Enqueuing [ci skip] | Zachary Scott | 2014-11-03 | 1 | -0/+1 |
| | |||||
* | Add documentation for class methods module included for AJ::Core used | Zachary Scott | 2014-11-03 | 1 | -0/+2 |
| | | | | for serialization and deserialization of jobs. [ci skip] | ||||
* | Document the class methods include module for AJ::Callbacks [ci skip] | Zachary Scott | 2014-11-03 | 1 | -0/+2 |
| | |||||
* | Merge pull request #17498 from rochefort/remove-redundant-to_s | Rafael Mendonça França | 2014-11-03 | 1 | -1/+1 |
|\ | | | | | Remove redundant `to_s` in interpolation | ||||
| * | Remove redundant `to_s` in interpolation | rochefort | 2014-11-04 | 1 | -1/+1 |
|/ | |||||
* | Remove unneeded autoload | Rafael Mendonça França | 2014-11-03 | 1 | -4/+1 |
| | |||||
* | Merge pull request #17494 from craftsmen/issue-17484 | Zachary Scott | 2014-11-03 | 0 | -0/+0 |
|\ | | | | | Change `rails` to `bin/rails` in getting started, fix #1748 [ci skip] | ||||
| * | Change `rails` to `bin/rails` in getting started, fix #1748 [ci skip] | kevcha | 2014-11-03 | 1 | -3/+3 |
| | | |||||
* | | Merge pull request #17487 from pabloh/avoid_allocations | Rafael Mendonça França | 2014-11-03 | 5 | -5/+5 |
|\ \ | | | | | | | Avoid unnecessary allocations and method calls | ||||
| * | | Avoid unnecessary allocations/calls | Pablo Herrero | 2014-11-02 | 5 | -5/+5 |
| | | | |||||
* | | | Merge pull request #17383 from rwz/string-remove | Rafael Mendonça França | 2014-11-03 | 3 | -8/+26 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md | ||||
| * | | | Make `String#remove` and `String#remove!` accept multiple arguments | Pavel Pravosud | 2014-10-25 | 3 | -8/+26 |
| | | | | |||||
* | | | | Add comment to point out String#[] is intentional | Andrew White | 2014-11-02 | 1 | -0/+1 |
| | | | | |||||
* | | | | Revert "Replace String index juggling with Pathname goodness in ↵ | yuuji.yaginuma | 2014-11-02 | 2 | -1/+11 |
| |/ / |/| | | | | | | | | | | | | | | | | | | | | db:fixtures:load" This reverts commit 482fdad5ef8a73688b50bba3991dd4ef6f286edd. Fixes #17237. | ||||
* | | | Add an `assert_deprecated` for `sanitize_sql_hash_for_conditions` | Sean Griffin | 2014-11-02 | 1 | -1/+3 |
| | | | |||||
* | | | Handle `RangeError` from casting in `find_by` and `find_by!` on Relation | Sean Griffin | 2014-11-02 | 2 | -0/+14 |
| | | | | | | | | | | | | | | | We should not behave differently just because a class has a default scope. | ||||
* | | | Revert deprecation of `sanitize_sql_hash_for_assignment` | Sean Griffin | 2014-11-02 | 2 | -6/+2 |
| | | | | | | | | | | | | This method is still used by `update_all` | ||||
* | | | Deprecate `sanitize_sql_hash_` methods on ActiveRecord | Sean Griffin | 2014-11-02 | 2 | -0/+12 |
| | | | | | | | | | | | | | | | These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally. | ||||
* | | | Pass the `SelectManager`, rather than the AST when querying w/ Relation | Sean Griffin | 2014-11-02 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now. | ||||
* | | | Tiny documentation styling fixes [ci skip] | Robin Dupret | 2014-11-02 | 3 | -18/+24 |
| | | | |||||
* | | | Merge pull request #17469 from rishijain/update_docs_2 | Zachary Scott | 2014-11-02 | 2 | -2/+4 |
|\ \ \ | | | | | | | | | added punctuations, and role of queue_adapter module [ci skip] | ||||
| * | | | placed description at correct place [ci skip] | Rishi Jain | 2014-11-01 | 1 | -2/+2 |
| | | | | |||||
| * | | | added punctuations, and role of queue_adapter module [ci skip] | Rishi Jain | 2014-11-01 | 2 | -2/+4 |
| | | | | |||||
* | | | | Merge pull request #17483 from pabloh/optimize_gsub_calls | Sean Griffin | 2014-11-01 | 5 | -5/+5 |
|\ \ \ \ | | | | | | | | | | | Call gsub with a Regexp instead of a String for better performance | ||||
| * | | | | Call gsub with a Regexp instead of a String for better performance | Pablo Herrero | 2014-11-01 | 5 | -5/+5 |
| | | | | | |||||
* | | | | | Don't duplicate predicate building logic in Relation finders | Sean Griffin | 2014-11-01 | 1 | -5/+2 |
| | | | | | |||||
* | | | | | Add a test case for range type casting | Sean Griffin | 2014-11-01 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | We support this behavior, but have no tests which assert that type casting actually occurs. | ||||
* | | | | | Use a bound parameter for the "id = " portion of update statements | Sean Griffin | 2014-11-01 | 2 | -5/+14 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG. | ||||
* | | | | Correctly cast calculation results on PG | Sean Griffin | 2014-11-01 | 4 | -2/+17 |
| | | | | | | | | | | | | | | | | | | | | MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"` | ||||
* | | | | Merge pull request #17482 from djpowers/patch-1 | Zachary Scott | 2014-11-01 | 1 | -0/+1 |
|\ \ \ \ | | | | | | | | | | | Add link to API Documentation Guidelines [ci skip] | ||||
| * | | | | Add link to API Documentation Guidelines | Dave Powers | 2014-11-01 | 1 | -0/+1 |
|/ / / / | | | | | | | | | | | | | Link to the "English" section to specify American English be used for the Guides [ci skip] | ||||
* | | | | [ci skip] `Relation#bind` is not public API | Sean Griffin | 2014-11-01 | 1 | -1/+1 |
| | | | | |||||
* | | | | Fix test which failed in isolation | Sean Griffin | 2014-11-01 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | It was transitively relying on the vertex model being loaded | ||||
* | | | | Use bind values for joined tables in where statements | Sean Griffin | 2014-11-01 | 8 | -1/+43 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In practical terms, this allows serialized columns and tz aware columns to be used in wheres that go through joins, where they previously would not behave correctly. Internally, this removes 1/3 of the cases where we rely on Arel to perform type casting for us. There were two non-obvious changes required for this. `update_all` on relation was merging its bind values with arel's in the wrong order. Additionally, through associations were assuming there would be no bind parameters in the preloader (presumably because the where would always be part of a join) [Melanie Gilman & Sean Griffin] | ||||
* | | | | Merge pull request #17463 from mrgilman/remove-index-from-substitute-at | Sean Griffin | 2014-11-01 | 3 | -7/+6 |
|\ \ \ \ | | | | | | | | | | | Remove redundant substitute index when constructing bind values | ||||
| * | | | | Remove redundant substitute index when constructing bind values | Melanie Gilman | 2014-10-31 | 3 | -7/+6 |
| |/ / / | | | | | | | | | | | | | | | | | | | | | We end up re-ordering them either way when we construct the Arel AST (in order to deal with rewhere, etc), so we shouldn't bother giving it a number in the first place beforehand. | ||||
* | | | | Merge pull request #17477 from Adam89/ma-remove-redundant-require | Richard Schneeman | 2014-11-01 | 1 | -1/+0 |
|\ \ \ \ | | | | | | | | | | | Remove redundant require of file | ||||
| * | | | | Remove redundant require of file | Adam89 | 2014-11-01 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | This file was required inside 'test/validators/namespace/email_validator.rb' that's already required here. Therefore I removed the redundant required. | ||||
* | | | | | Don't needlessly alphabetize columns for insert/update | Sean Griffin | 2014-11-01 | 1 | -4/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | This slightly simplifies the code, and reduces the number of times we need to iterate over the attributes by one. | ||||
* | | | | | Tiny documentation fixes and styling improvements | Robin Dupret | 2014-11-01 | 2 | -12/+17 |
|/ / / / | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Merge pull request #17474 from kuldeepaggarwal/fix-indentaion | Rafael Mendonça França | 2014-11-01 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | add missing space.[ci skip] | ||||
| * | | | | add missing space.[ci skip] | Kuldeep Aggarwal | 2014-11-01 | 1 | -1/+1 |
|/ / / / | |||||
* | | | | Merge pull request #17470 from keikun17/master | Zachary Scott | 2014-10-31 | 1 | -2/+1 |
|\ \ \ \ | | | | | | | | | | | [ci skip] Fix line break on asset pipeline guide | ||||
| * | | | | Fix break on generated html | Cakey | Buddy Magsipoc | 2014-11-01 | 1 | -2/+1 |
|/ / / / | | | | | | | | | | | | | | | | | fixes this : ![http://i.imgur.com/86scI3a.png](http://i.imgur.com/86scI3a.png)) | ||||
* | | | | remove unused and untested API | Aaron Patterson | 2014-10-31 | 1 | -6/+2 |
| | | | | |||||
* | | | | fix set_pk_sequence and add a test for it. | Aaron Patterson | 2014-10-31 | 2 | -1/+9 |
| | | | |