aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | necessary
* adding test cases for the dynamic finder matcher match methodAaron Patterson2010-09-271-0/+49
|
* constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
|
* @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-272-9/+5
|
* no need for a case / when statementAaron Patterson2010-09-271-11/+7
|
* do not need intermediate variable, avoid lasgnAaron Patterson2010-09-271-2/+3
|
* DRY up our regular expressionAaron Patterson2010-09-271-3/+3
|
* reduce method calls in the dynamic finder matcherAaron Patterson2010-09-271-4/+4
|
* Fix tests on 1.9.2.José Valim2010-09-282-5/+1
|
* revises RDoc of Hash#to_param to be more precise about orderingXavier Noria2010-09-281-2/+2
|
* let Hash#to_param and Hash#to_query sort againXavier Noria2010-09-282-5/+10
| | | | | This was a regression introduced in 5c858220085dc4ddc1bec496747059dfbe32f1da. We bring sorting back because people rely on it, eg for constructing consistent cache keys.
* make sure we use the engine assigned to the table when quotingAaron Patterson2010-09-272-1/+19
|
* Test for after_create callback order in ActiveSupport [#5703 state:resolved]Neeraj Singh2010-09-271-0/+23
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* after_create in ActiveModel should in the order specifiedNeeraj Singh2010-09-272-1/+31
| | | | | | [#5650 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* renderer calls object.to_json when rendering :json => object [#5655 ↵Diego Carrion2010-09-272-1/+14
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix for #5579 involved the code change for both has_one and has_many ↵Neeraj Singh2010-09-271-1/+9
| | | | | | | | relationships. The path included test only for has_one. This patch adds test for has_many relationship. [#5706 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix for nested_attributes with has_many association fails when a single ↵Neeraj Singh2010-09-272-1/+14
| | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix broken module namespacing in ActiveResource with Ruby 1.9 [#5699 ↵Matthijs Langenberg2010-09-274-5/+22
| | | | | | | | | | | | | | | | | | | | | | | state:resolved] Following namespace use case was broken with Ruby 1.9: class Author < ActiveRecord::Base ... end module Api class Book < ActiveResouce::Base end end Let's say XML contains <book><author><name>John</name></author>.... Api::Book.first.author.class.to_s #=> Ruby 1.8.7: "Api::Book::Author" (namespaced, correct), Ruby 1.9: "Author" (toplevel, broken) Signed-off-by: José Valim <jose.valim@gmail.com>
* Properly initialize variables inside the initialize method.José Valim2010-09-271-3/+8
|
* Define @_routes inside method, makes more sense and will be initialized when ↵Emilio Tagua2010-09-272-2/+1
| | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove more warnings shadowing outer local variable.Emilio Tagua2010-09-275-17/+17
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-276-13/+16
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Merge remote branch 'gramos/ares-missing-prefix-value'José Valim2010-09-275-1/+41
|\
| * - added mock to test ActiveResource::MissingPrefixParam in finder_testGaston Ramos2010-09-271-0/+1
| |
| * - update exceptions documentationGaston Ramos2010-09-271-0/+11
| |
| * - check prefix options in collection_pathGaston Ramos2010-09-272-1/+8
| |
| * - better name for prefix param test caseGaston Ramos2010-09-271-1/+1
| |
| * - refactoring, move prefix_options check to a custom methodGaston Ramos2010-09-271-5/+9
| |
| * - elmenth_path raise an ActiveResource::MissingPrefixParam exception when ↵Gaston Ramos2010-09-274-1/+18
| | | | | | | | | | | | | | prefix_options does not has all required prefix_options ex: class StreetAddress < ActiveResource::Base self.site = "http://37s.sunrise.i:3000/people/:person_id/" end StreetAddress.element_path(1) # => ActiveResource::MissingPrefixParam
* | Do not cache the script name outcome.José Valim2010-09-271-9/+11
| |
* | Merge remote branch 'miloops/warnings'José Valim2010-09-2743-150/+180
|\ \ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| * | _routes must be inside @controller conditional.Emilio Tagua2010-09-271-1/+1
| | |
| * | Initialize @_routes if not defined yet, avoiding more warnings.Emilio Tagua2010-09-271-0/+1
| | |
| * | Rename duplicated test name.Emilio Tagua2010-09-271-1/+1
| | |
| * | Refactor method to avoid warnings and not run unnecessary code.Emilio Tagua2010-09-271-11/+11
| | |
| * | Avoid uninitialized variable warning.Emilio Tagua2010-09-271-1/+1
| | |
| * | Initialize @_request and @_response.Emilio Tagua2010-09-271-1/+3
| | |
| * | Remove method previous method if already defined.Emilio Tagua2010-09-271-0/+1
| | |
| * | Define @emitted_hidden_id if it doesn't exists and reuse it if it does.Emilio Tagua2010-09-271-1/+1
| | |
| * | Avoid uninitialized variable warning.Emilio Tagua2010-09-271-0/+1
| | |
| * | Initialize @cookies.Emilio Tagua2010-09-271-0/+1
| | |
| * | Remove more warnings shadowing outer local variable.Emilio Tagua2010-09-275-17/+17
| | |
| * | Don't shadow outer local variables.Emilio Tagua2010-09-272-5/+5
| | |
| * | Remove method if already exists to avoid warnings.Emilio Tagua2010-09-271-0/+1
| | |
| * | Remove duplicated test.Emilio Tagua2010-09-271-8/+0
| | |
| * | Avoid uninitialized variable warning, reuse @integration_session.Emilio Tagua2010-09-271-8/+14
| | |
| * | Ask is @controller is defined to avoid warning.Emilio Tagua2010-09-271-1/+1
| | |
| * | Initialize @_routes if it doesn't exists.Emilio Tagua2010-09-271-0/+1
| | |
| * | Remove warning "too many arguments for format string" when interpolating ↵Emilio Tagua2010-09-271-1/+1
| | | | | | | | | | | | with empty hash.
| * | Initialize @_etag.Emilio Tagua2010-09-271-0/+1
| | |