Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #12550 from Peeja/hash-wia-update-respects-to-hash | Rafael Mendonça França | 2014-03-28 | 3 | -3/+51 |
|\ | | | | | HashWithIndifferentAccess#update respects #to_hash | ||||
| * | HashWithIndifferentAccess better respects #to_hash | Peter Jaros | 2014-03-28 | 3 | -3/+51 |
| | | | | | | | | | | | | In particular, `.new`, `#update`, `#merge`, `#replace` all accept objects which respond to `#to_hash`, even if those objects are not Hashes directly. | ||||
* | | Add CHANGELOG entry for #12778 [ci skip] | Rafael Mendonça França | 2014-03-28 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #12778 from etehtsea/rake-default-fix | Rafael Mendonça França | 2014-03-28 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | Don't load test env by default. Closes #13241 | ||||
| * | | Don't load test env by default | Konstantin Shabanov | 2013-11-11 | 1 | -1/+1 |
| | | | |||||
* | | | PostgreSQL, use `PostgreSQLColumn` in PG specific tests. | Yves Senn | 2014-03-28 | 1 | -8/+8 |
| | | | |||||
* | | | PostgreSQL, test-cases to lock down column default values. | Yves Senn | 2014-03-28 | 3 | -0/+33 |
| | | | |||||
* | | | Merge pull request #14515 from mzahir/fix_xml_warning | Yves Senn | 2014-03-28 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | Fix warning for overshadowing XML variable | ||||
| * | | | Fix warning for overshadowing XML variable | Musannif Zahir | 2014-03-28 | 1 | -2/+2 |
|/ / / | |||||
* | | | PostgreSQL, test cases to lock the current column types. | Yves Senn | 2014-03-28 | 8 | -15/+68 |
| | | | |||||
* | | | Merge pull request #14154 from al2o3cr/issue12770 | Aaron Patterson | 2014-03-27 | 4 | -4/+14 |
|\ \ \ | |_|/ |/| | | Pass a base relation to build_default_scope when joining | ||||
| * | | Pass a base relation to build_default_scope when joining | Matt Jones | 2014-02-21 | 4 | -4/+14 |
| | | | | | | | | | | | | | | | This allows the default scope to be built using the current table alias. Resolves #12770 | ||||
* | | | Merge pull request #14469 from tiegz/timestamp_inheritance_fix | Rafael Mendonça França | 2014-03-27 | 3 | -1/+23 |
| | | | | | | | | | | | | Swap Timestamp/Callbacks order in ActiveRecord::Base | ||||
* | | | Merge pull request #14505 from davefp/patch-1 | Carlos Antonio da Silva | 2014-03-27 | 1 | -0/+7 |
|\ \ \ | | | | | | | | | Adds explanation of :base attribute to errors.add [ci skip] | ||||
| * | | | Adds explanation of :base attribute to errors.add | David Underwood | 2014-03-27 | 1 | -0/+7 |
|/ / / | | | | | | | [ci skip] | ||||
* | | | Merge pull request #14393 from chrisfinne/persisted_exception | Rafael Mendonça França | 2014-03-27 | 4 | -1/+16 |
|\ \ \ | | | | | | | | | | | | | | | | | AR .persisted? throws SystemStackError for an unsaved model with a custom primary_key that didn't save due to validation error | ||||
| * | | | AR .persisted? throws SystemStackError for an unsaved model with a | chrisfinne | 2014-03-27 | 4 | -1/+16 |
|/ / / | | | | | | | | | | custom primary_key that didn't save due to validation error | ||||
* | | | Add CHANGELOG to Active Model too [ci skip] | Rafael Mendonça França | 2014-03-27 | 1 | -0/+6 |
| | | | |||||
* | | | Merge pull request #14456 from henrik/add-validate-method | Rafael Mendonça França | 2014-03-27 | 5 | -0/+38 |
|\ \ \ | | | | | | | | | | | | | ActiveRecord/ActiveModel '#validate' alias for 'valid?' | ||||
| * | | | ActiveRecord/ActiveModel '#validate' alias for 'valid?' | Henrik Nyh | 2014-03-27 | 5 | -0/+38 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies. | ||||
* | | | require dependency to execute a single test from xml_serialization_test | Yves Senn | 2014-03-27 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi | ||||
* | | | only run citext_test if the connection supports_extensions?. | Yves Senn | 2014-03-27 | 1 | -52/+54 |
| | | | | | | | | | | | | This will keep the test suite passing with older PG installations. | ||||
* | | | Merge pull request #14494 from laurocaetano/test_case_for_fk_with_validate_false | Rafael Mendonça França | 2014-03-26 | 1 | -1/+15 |
|\ \ \ | | | | | | | | | Add a test case for save(validate: false) with invalid foreign key. | ||||
| * | | | Add a test case for save(validate:false) with invalid foreign key. | Lauro Caetano | 2014-03-27 | 1 | -1/+15 |
|/ / / | | | | | | | | | | | | | It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint. | ||||
* | | | Fix build with bundler 1.6 | Rafael Mendonça França | 2014-03-26 | 1 | -1/+1 |
| | | | |||||
* | | | Edge Rails applications doesn't need to use arel master | Rafael Mendonça França | 2014-03-26 | 1 | -2/+1 |
| | | | |||||
* | | | Remove unused method | Rafael Mendonça França | 2014-03-26 | 1 | -5/+0 |
| | | | | | | | | | | | | | | | This method is not being called anywhere in our code and a GitHub search show it is not being used in any project. | ||||
* | | | Merge branch 'rm-create-with-index' | Rafael Mendonça França | 2014-03-26 | 6 | -66/+125 |
|\ \ \ | |||||
| * | | | Improve CHANGELOG entry | Rafael Mendonça França | 2014-03-26 | 1 | -3/+5 |
| | | | | |||||
| * | | | No need to use begin/end blocks | Rafael Mendonça França | 2014-03-26 | 2 | -16/+16 |
| | | | | |||||
| * | | | No need to gsub the string | Rafael Mendonça França | 2014-03-26 | 3 | -3/+3 |
| | | | | |||||
| * | | | Don't use send when we own the method | Rafael Mendonça França | 2014-03-26 | 2 | -35/+35 |
| | | | | |||||
| * | | | Make method private | Rafael Mendonça França | 2014-03-26 | 1 | -5/+6 |
| | | | | |||||
| * | | | Improve the method | Rafael Mendonça França | 2014-03-26 | 1 | -5/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call | ||||
| * | | | Remove unneeded comments about feature support on the adapters | Rafael Mendonça França | 2014-03-26 | 1 | -20/+9 |
| | | | | | | | | | | | | | | | | | | | | These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters | ||||
| * | | | Invert the conditionals to make easier to read | Rafael Mendonça França | 2014-03-26 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | Also improve some of the code conventions | ||||
| * | | | Merge pull request #14480 from steverice/mysql-indexes-in-create-table | Rafael Mendonça França | 2014-03-26 | 6 | -14/+80 |
|/| | | | | | | | | | | | | | | | Create indexes inline in CREATE TABLE for MySQL | ||||
| * | | | Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵ | Steve Rice | 2014-03-25 | 5 | -6/+25 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog | ||||
| * | | | create indexes inline in CREATE TABLE for MySQL | Cody Cutrer | 2014-03-25 | 5 | -11/+58 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md | ||||
* | | | | Merge pull request #14487 from JuanitoFatas/patch/fix-release-note-url | Rafael Mendonça França | 2014-03-26 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | [ci skip] Fix Pull Request URL in 4.1 release note. | ||||
| * | | | | [ci skip] Fix Pull Request URL in 4.1 release note. | Juanito Fatas | 2014-03-27 | 1 | -1/+1 |
|/ / / / | |||||
* / / / | link to "Schema migration" Wikipedia page. Closes #14479. [ci skip] | Yves Senn | 2014-03-26 | 1 | -3/+4 |
|/ / / | |||||
* | | | Fix task comment to match which file should be changed | Rafael Mendonça França | 2014-03-25 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Fix the update_versions release task | Rafael Mendonça França | 2014-03-25 | 2 | -49/+23 |
| | | | |||||
* | | | Use rails convetions | Rafael Mendonça França | 2014-03-25 | 1 | -2/+2 |
| | | | |||||
* | | | Merge pull request #14390 from huoxito/true-touch | Rafael Mendonça França | 2014-03-25 | 2 | -0/+13 |
|\ \ \ | | | | | | | | | | | | | Still touch associations when theres no timestamp | ||||
| * | | | Still touch associations when theres no timestamp | Washington Luiz | 2014-03-14 | 2 | -0/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute | ||||
* | | | | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects" | Rafael Mendonça França | 2014-03-25 | 3 | -22/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb | ||||
* | | | | clarify CHANGELOG [ci skip]. | Yves Senn | 2014-03-25 | 1 | -8/+2 |
| | | | | |||||
* | | | | Merge pull request #13440 from kuldeepaggarwal/pluralize_table_name_issue | Yves Senn | 2014-03-25 | 4 | -3/+74 |
|\ \ \ \ | | | | | | | | | | | Generating proper migration when ActiveRecord::Base.pluralize_table_names = false |