aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | Fix typo in test error messageclaudiob2017-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the current code, a failing test shows this error, which is missing the number of times called and has two periods at the end. ``` /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install Failure: AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]: active_storage:install expected to be called once, but was called times.. Expected: 1 Actual: 2 ``` After the fix, the error message looks correct: ``` /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install Failure: AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]: active_storage:install expected to be called once, but was called 2 times. Expected: 1 Actual: 2 ```
* | | | | | | | | | | | Fix `s/klass.connection/connection/`Ryuta Kamizono2017-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `klass` has removed in 5358f2b67bd6fb12d708527a4a70dcab65513c5e.
* | | | | | | | | | | | Fix `test_add_column_with_timestamp_type` failureRyuta Kamizono2017-12-032-7/+8
| |/ / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test failed due to dirty schema cache. It is needed to call `clear_cache!` when using same named table with different definition. https://travis-ci.org/rails/rails/jobs/310627767#L769-L772
* | | | | | | | | | | Extract duplicated index column options normalization as ↵Ryuta Kamizono2017-12-035-46/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `options_for_index_columns` And placed `add_options_for_index_columns` in `schema_statements.rb` consistently to ease to find related code.
* | | | | | | | | | | Fix warning: assigned but unused variable - tRyuta Kamizono2017-12-031-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Refactor `length`, `order`, and `opclass` index options dumpingRyuta Kamizono2017-12-039-33/+67
|/ / / / / / / / / /
* | | | | | | | | | Merge pull request #31230 from dinahshi/postgresql_extract_sqlMatthew Draper2017-12-036-61/+107
|\ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / |/| | | | | | | | | Extract sql fragment generators from PostgreSQL adapter
| * | | | | | | | | Extract sql fragment generators for alter table from PostgreSQL adapterDinah Shi2017-12-026-61/+107
| | | | | | | | | |
* | | | | | | | | | Merge pull request #31312 from ↵Yuji Yaginuma2017-12-021-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | willnet/add-a-missing-space-before-closing-curly-braces [ci skip] Add a missing space before closing curly braces
| * | | | | | | | | | [ci skip] Add a missing space before closing curly braceswillnet2017-12-021-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Fix method name in `validate_constraint` doc [ci skip]yuuji.yaginuma2017-12-021-1/+1
| | | | | | | | | |
* | | | | | | | | | Merge pull request #27756 from travisofthenorth/validate-foreign-keysMatthew Draper2017-12-028-1/+152
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / |/| | | | | | | | | Add ability to create/validate invalid foreign keys in Postgres
| * | | | | | | | | Add support for invalid foreign keys in PostgresTravis Hunter2017-12-018-1/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add validate_constraint and update naming
* | | | | | | | | | Make ASt previewer/analyzer binary paths configurableGeorge Claghorn2017-12-014-4/+32
|/ / / / / / / / /
* | | | | | | | | Remove unpaired `}` [ci skip]Ryuta Kamizono2017-12-011-2/+1
| | | | | | | | |
* | | | | | | | | Tweaks CHANGELOGs [ci skip]Ryuta Kamizono2017-12-012-3/+3
| | | | | | | | |
* | | | | | | | | Merge pull request #19090 from ↵Matthew Draper2017-12-019-20/+115
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gregnavis/support-postgresql-operator-classes-in-indexes Add support for PostgreSQL operator classes to add_index
| * | | | | | | | | Add support for PostgreSQL operator classes to add_indexGreg Navis2017-11-309-20/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for specifying non-default operator classes in PostgreSQL indexes. An example CREATE INDEX query that becomes possible is: CREATE INDEX users_name ON users USING gist (name gist_trgm_ops); Previously it was possible to specify the `gist` index but not the custom operator class. The `add_index` call for the above query is: add_index :users, :name, using: :gist, opclasses: {name: :gist_trgm_ops}
* | | | | | | | | | Merge pull request #31241 from matthewd/no-after-forkMatthew Draper2017-12-011-23/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Drop the before_fork/on_worker_boot advice
| * | | | | | | | | | Drop the before_fork/on_worker_boot adviceMatthew Draper2017-11-271-23/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's no longer required for Active Record, and other common libraries (dalli, redis-rb) all seem to be fork-proof too.
* | | | | | | | | | | Remove unnecessary scopingRyuta Kamizono2017-12-011-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Class level `update` and `destroy` checks all the records exist before ↵Ryuta Kamizono2017-12-012-13/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | making changes (#31306) It makes more sense than ignoring invalid IDs.
* | | | | | | | | | | Add ActiveStorage::Previewer#logger to match ActiveStorage::Analyzer#loggerGeorge Claghorn2017-11-301-0/+4
| | | | | | | | | | |
* | | | | | | | | | | Maintain raising `RecordNotFound` for class level `update` and` destroy`Ryuta Kamizono2017-12-012-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 35836019, class level `update` and `destroy` suppressed `RecordNotFound` to ensure returning affected objects. But `RecordNotFound` is a common exception caught by a `rescue_from` handler. So changing the behavior when a typical `params[:id]` is passed has a compatibility problem. The previous behavior should not be changed. Fixes #31301.
* | | | | | | | | | | Merge pull request #31293 from ydakuka/fix-gemfile-guidesYuji Yaginuma2017-12-0111-28/+28
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Cosmetic changes for Gemfile [ci skip]
| * | | | | | | | | | | Cosmetic changes [ci skip]Yauheni Dakuka2017-11-3011-28/+28
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #31296 from dixitp012/configuration_update_linksRyuta Kamizono2017-12-011-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Updated links for unicorn which redirect & added https for n…
| * | | | | | | | | | | | [ci skip] Updated links for uncorn which redirect & added https for nginx linkDixit Patel2017-11-301-3/+3
| |/ / / / / / / / / / /
* | | | | | | | | | | | Merge pull request #31292 from noahd1/patch-1Rafael França2017-11-301-0/+22
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Keep current Code Climate behavior before upgrade
| * | | | | | | | | | | | Keep current Code Climate behavior before upgradeNoah Davis2017-11-291-0/+22
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you merge these changes now (*before Monday, December 4th*), Code Climate will run the same analysis on Rails as it always has on your pull requests. *If you do not merge these changes*, when Code Climate migrates Rails to our new analysis, Code Climate will continue to run Rubocop, but it will ALSO run Code Climate's new maintainability checks (https://codeclimate.com/blog/10-point-technical-debt-assessment). You may want this ... you may not. Just want to make sure you knew the quick option to disable them if it's a problem!
* | | | | | | | | | | | Add changelog entry for 9d6e28eileencodes2017-11-301-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since this changes a default setting a changelog entry is important.
* | | | | | | | | | | | Merge pull request #31300 from aried3r/ar/move_test_dependencies_to_test_groupEileen M. Uchitelle2017-11-301-7/+10
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | Move system test dependencies to test group
| * | | | | | | | | | | Move system test dependencies to test groupAnton Rieder2017-11-301-7/+10
|/ / / / / / / / / / /
| | | | | | | | | | * Incorporate latest round of feedbackJeffrey Guenther2017-12-041-57/+67
| | | | | | | | | | |
| | | | | | | | | | * Change info to noteJeffrey Guenther2017-11-301-1/+9
| | | | | | | | | | |
| | | | | | | | | | * Adds Javan's event exampleJeffrey Guenther2017-11-301-2/+98
| | | | | | | | | | |
| | | | | | | | | | * Merge branch 'master' into activestorage-guideJeffrey Guenther2017-11-30172-676/+2670
| | | | | | | | | | |\ | |_|_|_|_|_|_|_|_|_|/ |/| | | | | | | | | |
* | | | | | | | | | | Do not overwrite by default if credentials already existsyuuji.yaginuma2017-11-302-2/+12
| |_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #31286
* | | | | | | | | | Add :nodoc: to `StatementPool` which is internal used [ci skip]Ryuta Kamizono2017-11-302-4/+2
| |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #30510, `StatementPool` in `AbstractMysqlAdapter` was hidden in the doc. But that class is also had in sqlite3 and postgresql adapters and the base class is :nodoc: class.
* | | | | | | | | Build the root folder before specific filesRafael Mendonça França2017-11-291-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #31282.
* | | | | | | | | Make screenshots default to "simple" formateileencodes2017-11-292-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not everyone uses iTerm2 and whereas Terminal.app on a mac just ignores that and outputs the path, other terminals like those on Ubuntu do not. A friendlier default is one that works by default. Closes #31159 Closes #30957
* | | | | | | | | Merge pull request #31214 from ↵Eileen M. Uchitelle2017-11-293-0/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chopraanmol1/bug_fix_has_one_inverse_owner_reload_from_validation Inverse instance should not be reloaded during autosave if called in validation
| * | | | | | | | | Inverse instance should not be reloaded during autosave if called in validationAnmol Chopra2017-11-273-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Record saved in save_has_one_association already make call to association.loaded! via record's before_save callback of save_belongs_to_association, but this will reload object if accessed in record's validation.
* | | | | | | | | | Merge pull request #31272 from y-yagi/use_credentials_instead_of_keyfile_in_gcsGeorge Claghorn2017-11-295-21/+23
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Use `credentials` instead of `keyfile` in GCS sevice
| * | | | | | | | | | Use `credentials` instead of `keyfile` in GCS seviceyuuji.yaginuma2017-11-295-21/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `keyfile` was renamed to `credentials` in `google-cloud-storage` 1.8.0. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/master/google-cloud-storage/CHANGELOG.md#180--2017-11-14 Although `keyfile` can still be used, but it looks like deprecate. https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/ddf7b2a856d676316525eb581c1a4cc83ca6097b/google-cloud-storage/lib/google/cloud/storage.rb#L589...L590 Therefore, I think that should use `credentials` in newly generated applications. Ref: https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/1802
* | | | | | | | | | | Mention about Ruby 2.4 Unicode case mappings in `mb_chars` example [ci skip] ↵Ryuta Kamizono2017-11-291-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#31275) https://www.ruby-lang.org/en/news/2016/09/08/ruby-2-4-0-preview2-released/
* | | | | | | | | | | Fix tests: Remove ogx mime type from testsGuillermo Iguaran2017-11-291-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Fix typo in mime type registeringGuillermo Iguaran2017-11-291-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Restore mpeg mime type, delete less common mime typesGuillermo Iguaran2017-11-291-9/+4
| |_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | See discussion in #31251
* | | | | | | | | | Register "audio/mp4" mime type with :m4a symbolGuillermo Iguaran2017-11-291-1/+1
| | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 10:09:05 +0000