Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | | | | | | | | | | | | Merge pull request #27451 from rails/sdoc-rc1 | Akira Matsuda | 2016-12-25 | 2 | -5/+5 | |
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bump sdoc to rc1 which includes zzak/sdoc#98 | |||||
| * | | | | | | | | | | | | | | | | | Bump sdoc to rc1 which includes zzak/sdoc#98 | Zachary Scott | 2016-12-25 | 2 | -5/+5 | |
|/ / / / / / / / / / / / / / / / / | ||||||
* | | | | | | | | | | | | | | | | | Correct indent-accounting in controller route generation | Matthew Draper | 2016-12-25 | 2 | -12/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma] | |||||
* | | | | | | | | | | | | | | | | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in ↵ | Akira Matsuda | 2016-12-25 | 3 | -5/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | minitest 6." | |||||
* | | | | | | | | | | | | | | | | | Expectation first | Akira Matsuda | 2016-12-25 | 2 | -5/+5 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | CI against ruby 2.4.0 | Akira Matsuda | 2016-12-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 6 | -15/+15 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Merge pull request #27448 from kamipo/no_need_doc_for_nodoc_classes | Akira Matsuda | 2016-12-25 | 5 | -15/+15 | |
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | |||||
| * | | | | | | | | | | | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | Ryuta Kamizono | 2016-12-25 | 5 | -15/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html | |||||
* | | | | | | | | | | | | | | | | | | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 69 | -196/+196 | |
| | | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | | public methods can be placed after private ones if you want to | Akira Matsuda | 2016-12-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | | | | | | | | | | | | | Abuse of protected in guides | Akira Matsuda | 2016-12-25 | 3 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Railties | Akira Matsuda | 2016-12-25 | 25 | -135/+136 | |
| | | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | | Privatize some methods that were originally protected | Akira Matsuda | 2016-12-25 | 1 | -25/+27 | |
| | | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | | Prefer class << self; def over def self. | Akira Matsuda | 2016-12-25 | 1 | -200/+200 | |
|/ / / / / / / / / / / / / / / / / | ||||||
* | | | | | | | | | | | | | | | | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | `protected` here doesn't protect anything | Akira Matsuda | 2016-12-25 | 1 | -26/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there aren't any instance method defined in this class | |||||
* | | | | | | | | | | | | | | | | | Shuffle travis matrix | Matthew Draper | 2016-12-25 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Run actionpack and actioncable tests together * Demote ac:integration to allow_failures -- it works most of the time, but still fails too frequently to rely upon | |||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Shave a couple of allocations off Journey scan & parse | Matthew Draper | 2016-12-25 | 4 | -203/+208 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | self. is not needed when calling its own instance method | Akira Matsuda | 2016-12-24 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action View | Akira Matsuda | 2016-12-24 | 7 | -39/+32 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 9 | -20/+20 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Cable | Akira Matsuda | 2016-12-24 | 5 | -25/+24 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected method in Active Job | Akira Matsuda | 2016-12-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Mailer | Akira Matsuda | 2016-12-24 | 4 | -27/+20 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private method | Akira Matsuda | 2016-12-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 15 | -83/+82 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 5 | -24/+24 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Model | Akira Matsuda | 2016-12-24 | 6 | -27/+23 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to :nodoc: private methods | Akira Matsuda | 2016-12-24 | 2 | -6/+6 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Support | Akira Matsuda | 2016-12-24 | 15 | -56/+46 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 5 | -10/+10 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Wrong rake task name in the document | Akira Matsuda | 2016-12-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | | | | | | | | | | | | | bundle u rake to 12.0.0 | Akira Matsuda | 2016-12-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Support tests | Akira Matsuda | 2016-12-24 | 7 | -8/+8 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Railties tests | Akira Matsuda | 2016-12-24 | 6 | -6/+6 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Record tests | Akira Matsuda | 2016-12-24 | 11 | -11/+11 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Cable tests | Akira Matsuda | 2016-12-24 | 3 | -3/+3 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Active Job tests | Akira Matsuda | 2016-12-24 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Mailer tests | Akira Matsuda | 2016-12-24 | 3 | -3/+3 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action Pack tests | Akira Matsuda | 2016-12-23 | 10 | -22/+20 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Privatize unneededly protected methods in Action View tests | Akira Matsuda | 2016-12-23 | 5 | -5/+5 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 37 | -0/+78 | |
| | | | | | | | | | | | | | | | | | ||||||
* | | | | | | | | | | | | | | | | | Unneeded attr_accessor with side effects | Akira Matsuda | 2016-12-23 | 2 | -8/+0 | |
|/ / / / / / / / / / / / / / / / | ||||||
* | | | | | | | | | | | | | | | | Merge pull request #27424 from utilum/fix_complex_and_rational_are_duplicable | Kasper Timm Hansen | 2016-12-22 | 3 | -2/+27 | |
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ / / / / / / / |/| | | | | | | | | | | | | | | | Fix duplicable? for Complex and Rational | |||||
| * | | | | | | | | | | | | | | | Fix Complex and Rational are duplicable? | utilum | 2016-12-21 | 3 | -2/+27 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See [this test](https://gist.github.com/utilum/78918f1b64f8b61ee732cb266db7c43a). | |||||
* | | | | | | | | | | | | | | | | Merge pull request #27431 from y-yagi/quiet_generator_log_in_test | Kasper Timm Hansen | 2016-12-22 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | quiet generators log in test |