aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | | Prevented belongs_to: touch propagating up if there are no changes being savedBrock Trappitt2014-05-213-1/+16
| | | | | | | | | | | | |
* | | | | | | | | | | | | Revert "Revert "Merge pull request #8313 from ↵Rafael Mendonça França2014-05-203-8/+22
|/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | alan/only_save_changed_has_one_objects"" This reverts commit e94e6c27af495a2460c811bb506459f1428dec6b. Conflicts: activerecord/CHANGELOG.md The original commit was reverted only to be safe since #14407 were reported. We don't have any proof we added a regression with the original commit so reverting it now will give us more problem. Closes #14407
* | | | | | | | | | | | Merge pull request #15154 from msgehard/move_password_fieldRafael Mendonça França2014-05-201-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Put attr_reader in with all of the other instance methods
| * | | | | | | | | | | | Put attr_reader in with all of the other instance methodsMike Gehard2014-05-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the grouping make a little more sense
* | | | | | | | | | | | | we don't use this parameter for anything, so rmAaron Patterson2014-05-203-22/+21
| | | | | | | | | | | | |
* | | | | | | | | | | | | fewer string allocations per url_forAaron Patterson2014-05-201-7/+5
| | | | | | | | | | | | |
* | | | | | | | | | | | | mutate the path string to avoid object allocationsAaron Patterson2014-05-201-4/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | push only_path conditional upAaron Patterson2014-05-201-18/+19
| | | | | | | | | | | | |
* | | | | | | | | | | | | push arg checking upAaron Patterson2014-05-201-4/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | fewer method calls and string garbage when there is no user/passwordAaron Patterson2014-05-201-9/+5
| | | | | | | | | | | | |
* | | | | | | | | | | | | fewer hash allocations when calling url_forAaron Patterson2014-05-201-9/+12
| | | | | | | | | | | | |
* | | | | | | | | | | | | fix variable names, only pass hashes to the positional args methodAaron Patterson2014-05-201-8/+10
| |/ / / / / / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #15208 from sgrif/sg-delegate-type-cast-for-writeRafael Mendonça França2014-05-204-30/+14
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Delegate `type_cast_for_write` to injected type object
| * | | | | | | | | | | | Delegate `type_cast_for_write` to injected type objectSean Griffin2014-05-204-30/+14
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #11346 from tomykaira/fix_10257Rafael Mendonça França2014-05-202-2/+21
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | | Check authentication scheme in Basic auth
| * | | | | | | | | | | | Run login_procedure only when the auth_scheme is validtomykaira2013-07-081-7/+14
| | | | | | | | | | | | |
| * | | | | | | | | | | | Check authentication scheme in Basic authtomykaira2013-07-072-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257.
* | | | | | | | | | | | | Merge pull request #15207 from sgrif/sg-inline-column-helpersRafael Mendonça França2014-05-2010-120/+77
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inline typecasting helpers from Column to the appropriate types
| * | | | | | | | | | | | | Inline typecasting helpers from Column to the appropriate typesSean Griffin2014-05-2010-120/+77
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #15206 from sgrif/sg-type-map-postgresqlRafael Mendonça França2014-05-203-45/+31
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the generic type map for PostgreSQL OID registrations
| * | | | | | | | | | | | | | Use the generic type map for PostgreSQL OID registrationsSean Griffin2014-05-203-45/+31
| |/ / / / / / / / / / / / /
* | | | | | | | | | | | | | Merge pull request #15204 from sgrif/sg-delegate-predicatesRafael Mendonça França2014-05-2012-24/+44
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / |/| | | | | | | | | | | | | Delegate predicate methods to injected type object on Column
| * | | | | | | | | | | | | Delegate predicate methods to injected type object on ColumnSean Griffin2014-05-2012-24/+44
|/ / / / / / / / / / / / /
* | | | | | | | | | | | | remove dead codeAaron Patterson2014-05-201-57/+0
| | | | | | | | | | | | |
* | | | | | | | | | | | | cache the formatter on the path objectAaron Patterson2014-05-202-2/+6
| | | | | | | | | | | | |
* | | | | | | | | | | | | translate AST to a formatter before url generationAaron Patterson2014-05-202-1/+72
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #15200 from sgrif/sg-type-map-mysqlRafael Mendonça França2014-05-204-23/+39
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the generic type map object for mysql field lookups
| * | | | | | | | | | | | | Use the generic type map object for mysql field lookupsSean Griffin2014-05-204-23/+39
|/ / / / / / / / / / / / /
* | | | | | | | | | | | | Merge pull request #15191 from camsong/masterYves Senn2014-05-201-2/+8
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Distinguish rake assets:clobber from rake assets:clean [ci skip]
| * | | | | | | | | | | | | Distinguish rake assets:clobber from rake assets:cleancam song2014-05-201-2/+5
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #15203 from sgrif/sg-delegate-type-castRafael Mendonça França2014-05-207-75/+7
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace `type_cast` case statement with delegation
| * | | | | | | | | | | | | | Replace `type_cast` case statement with delegationSean Griffin2014-05-207-75/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All subclasses of column were now delegating `type_cast` to their injected type object. We can remove the overriding methods, and generalize it on the `Column` class itself. This also enabled us to remove several column classes completely, as they no longer had any meaningful behavior of their own.
* | | | | | | | | | | | | | | Merge pull request #15187 from v-yarotsky/fix_confusing_delegation_exceptionRafael Mendonça França2014-05-203-26/+20
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix confusing exception in ActiveSupport delegation
| * | | | | | | | | | | | | | | Fix confusing exception in ActiveSupport delegationVladimir Yarotsky2014-05-203-26/+20
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | prepopulate the dispatch cache so we don't need the ThreadSafe cache.Aaron Patterson2014-05-201-7/+9
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | make the each visitor top-down left-rightAaron Patterson2014-05-201-1/+1
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Merge pull request #15201 from sgrif/sg-types-postgresqlRafael Mendonça França2014-05-204-151/+85
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Have Postgres OID types inherit from general types
| * | | | | | | | | | | | | | | | Have Postgres OID types inherit from general typesSean Griffin2014-05-204-151/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using general types where possible. Several more can go away once infinity gets figured out.
* | | | | | | | | | | | | | | | | fix multiple hash preloads. Fixes #14994Aaron Patterson2014-05-202-6/+14
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | Merge pull request #15199 from sgrif/sg-types-mysqlRafael Mendonça França2014-05-201-69/+11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | Use general types for mysql fields
| * | | | | | | | | | | | | | | | Use general types for mysql fieldsSean Griffin2014-05-201-69/+11
|/ / / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | | Merge pull request #15198 from sgrif/sg-delegate-type-cast-mysqlYves Senn2014-05-206-53/+72
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | Delegate type_cast to injected type object in mysql
| * | | | | | | | | | | | | | | Delegate type_cast to injected type object in mysqlSean Griffin2014-05-206-53/+72
|/ / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | Merge pull request #15197 from sgrif/sg-delegate-type-cast-sqlite3Yves Senn2014-05-2011-7/+83
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | Delegate `#type_cast` to injected type objects on SQLite3
| * | | | | | | | | | | | | | Delegate `#type_cast` to injected type objects on SQLite3Sean Griffin2014-05-2011-7/+83
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Merge pull request #14965 from eric-chahin/issue_14824Matthew Draper2014-05-203-1/+33
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed the inferred table name of a HABTM auxiliar
| * | | | | | | | | | | | | | Fixed the inferred table name for HABTM within a schemaEric Chahin2014-05-203-1/+33
|/ / / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #14824.
* | | | | | | | | | | | | | Merge pull request #15192 from simi/guides-binstubsYves Senn2014-05-2016-108/+108
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / / / |/| | | | | | | | | | | | | Use generated binstubs in guides examples. [ci skip]
| * | | | | | | | | | | | | Use generated binstubs in guides examples.Josef Šimánek2014-05-2016-108/+108
|/ / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | | | | fix `rake test_sqlite3_mem`.Yves Senn2014-05-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While running Sqlite3 memory tests I encountered the following error: ``` Finished in 69.416366s, 58.0267 runs/s, 162.3681 assertions/s. 1) Error: ActiveRecord::Migration::ChangeSchemaTest#test_add_column_with_timestamp_type: NoMethodError: undefined method `type' for nil:NilClass /Users/senny/Projects/rails/activerecord/test/cases/migration/change_schema_test.rb:244:in `test_add_column_with_timestamp_type' 4028 runs, 11271 assertions, 0 failures, 1 errors, 1 skips ``` This was because the table `testings` was used in multiple test-cases. This resulted in a wrongly cached schema on `ActiveRecord::Base.schema_chae`. /cc @zuhao
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-25 15:07:55 +0000