aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix styleschneems2016-08-302-31/+31
|
* Better keyword argument nameschneems2016-08-301-3/+3
|
* Address comment via @dhh, better option namingschneems2016-08-303-23/+23
|
* Explicitly mention defaults.schneems2016-08-292-2/+2
|
* Document public_poster_folder optionschneems2016-08-291-0/+4
|
* Address doc style comments from @robin850schneems2016-08-292-10/+10
|
* Fix asset_pipeline.md miss-mergeschneems2016-08-291-7/+7
|
* Specify version of Sprockets-rails this will be inschneems2016-08-291-1/+1
|
* Set unknown_asset_fallback false only new appsschneems2016-08-291-1/+1
|
* Move default to different initializerschneems2016-08-293-16/+4
| | | | | Is this usage correct? cc/ @prathamesh-sonpatki
* Thanks rubocopschneems2016-08-291-1/+1
|
* [ci skip] configuring.md assets.unknown_asset_fallbackschneems2016-08-291-0/+2
|
* [ci skip] asset_pipeline.md assets.unknown_asset_fallbackschneems2016-08-291-7/+20
|
* [ci skip] Upgrading assets.unknown_asset_fallbackschneems2016-08-291-0/+12
|
* Fix initializerschneems2016-08-291-1/+1
|
* Fully document asset_path.schneems2016-08-291-7/+58
|
* Do not deprecate using assets with leading slashschneems2016-08-291-10/+5
|
* Default assets.unknown_asset_fallback to falseschneems2016-08-291-0/+4
|
* Missed 2 public_* methods in cleanupschneems2016-08-291-16/+0
|
* Favor `public_folder: true` over `public_*`schneems2016-08-293-169/+47
| | | | Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way.
* Fix formattingschneems2016-08-293-26/+25
|
* Add `public_*` helpers to all the `_tag` methods.schneems2016-08-292-19/+73
|
* Test `public_` methods.schneems2016-08-291-0/+72
|
* Match method signatureschneems2016-08-291-3/+3
|
* Add docs to `public_*_path` methods & fix commentsschneems2016-08-291-15/+36
|
* Add public URL helpersschneems2016-08-291-0/+56
|
* Add descriptive commentschneems2016-08-291-7/+7
|
* Make sure routes don't interfere with pathsschneems2016-08-291-0/+11
|
* Allow a more explicit public behaviorschneems2016-08-291-2/+37
| | | | | We want to make it more explicit when a user wants to avoid the asset pipeline to do this we will add `public_*` methods to all path helpers. So if someone wants to use an asset that isn't maintained by the asset pipeline they can use `public_asset_path` instead of `asset_path` and letting it fall through. The main reason for this change is the desire to raise helpful errors in the future. Right now if you typo an asset name, then we assume you intended an asset in the `public/` folder and not in the pipeline so nothing fails and the error sits silently until you realize the page didn't render correctly. We have to deprecate today so we can raise meaningful error messages in the future.
* Merge pull request #26318 from alexcameron89/contributing-doc-updateAndrew White2016-08-291-1/+1
|\ | | | | [ci skip] Update branch version in Contributing Guide
| * [ci skip] Update branch version in Contributing GuideAlex Kitchens2016-08-291-1/+1
|/ | | | | Since only Rails 4 and above are currently supported, this updates a 3-2-stable example to be consistent with the support standard.
* Fix nested multiple rootsRyo Hashimoto2016-08-293-2/+61
| | | | | | | | | | | | | | | The PR #20940 enabled the use of multiple roots with different constraints at the top level but unfortunately didn't work when those roots were inside a namespace and also broke the use of root inside a namespace after a top level root was defined because the check for the existence of the named route used the global :root name and not the namespaced name. This is fixed by using the name_for_action method to expand the :root name to the full namespaced name. We can pass nil for the second argument as we're not dealing with resource definitions so don't need to handle the cases for edit and new routes. Fixes #26148.
* Remove unneeded FIXME noteRafael Mendonça França2016-08-291-2/+0
| | | | | This is the intended behavior. You should not do more than one request in a controller test.
* Merge pull request #26311 from y-yagi/use_inspect_for_show_valueKasper Timm Hansen2016-08-292-1/+10
|\ | | | | use `inspect` for show `from` value
| * use `inspect` for show `from` valueyuuji.yaginuma2016-08-292-1/+10
| | | | | | | | If `from` is nil, in order to avoid the blank is showed.
* | Merge pull request #26310 from kjellberg/guidesJon Moss2016-08-281-0/+1
|\ \ | |/ |/| Add .gitignore to "files & purpose" list - getting started docs
| * Added gitignore to "files & purpose" list [ci skip]Rasmus Kjellberg2016-08-291-0/+1
|/
* Merge pull request #26305 from kamipo/follow-up-to-26301Kasper Timm Hansen2016-08-281-3/+1
|\ | | | | Switch back to `Hash.dup`
| * Switch back to `Hash.dup`Ryuta Kamizono2016-08-281-3/+1
| | | | | | | | Follow up to #26301.
* | Merge pull request #26306 from kamipo/remove_under_ruby-1.9Kasper Timm Hansen2016-08-281-9/+9
|\ \ | |/ |/| Remove "Under Ruby 1.9" [ci skip]
| * Remove "Under Ruby 1.9" [ci skip]Ryuta Kamizono2016-08-281-9/+9
|/ | | | Rails dropped Ruby 1.9 support, but this comment still true.
* validate_each in NumericalityValidator is never called in this case.Guillermo Iguaran2016-08-281-2/+0
| | | | | NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate.
* Add test for allow_blank in numericality validationNicolai Reuschling2016-08-281-0/+7
| | | | Signed-off-by: Guillermo Iguaran <guilleiguaran@gmail.com>
* Merge pull request #26301 from maclover7/jm-fix-commentGuillermo Iguaran2016-08-271-4/+2
|\ | | | | Switch back to `Hash.dup`
| * Switch back to `Hash.dup`Jon Moss2016-08-271-4/+2
|/ | | | | | | | | | | | | The performance difference between `Hash[]` and `Hash.dup` looks to have been narrowed by @tenderlove via this commit --> https://github.com/ruby/ruby/commit/b3803cc49ad382e23291d75ce57ffb2b74bb9577#diff-eff9999082c8ce7d8ba1fc1d79f439cf. Since this commit first appeared in Ruby 2.0.0, and since Rails now requires a minimum Ruby version of 2.2.2, this performance boost should be available for all users. Relevant links: - This behavior was originally added via https://github.com/rails/rails/commit/02174a3efc6fa8f2e5e6f114e4cf0d8a06305b6a - The conversation on the Ruby issue tracker lives here --> https://bugs.ruby-lang.org/issues/7166
* Merge pull request #26299 from davydovanton/fix-typoVipul A M2016-08-271-1/+1
|\ | | | | Fix typo in Delegation#delegate_missing_to doc [ci skip]
| * Fix typo in Delegation#delegate_missing_to doc [skip ci]Anton Davydov2016-08-271-1/+1
|/
* Merge pull request #26297 from ledermann/patch-1Vijay Dev2016-08-271-1/+1
|\ | | | | Errors#add_on_blank: Fix typo in deprecation message
| * Fix typo in deprecation messageGeorg Ledermann2016-08-271-1/+1
|/ | | This fixes a copy-and-paste-issue slipped in by #18996
* Merge pull request #26293 from mechanicles/move-custom-assertionGuillermo Iguaran2016-08-272-11/+11
|\ | | | | Move Rails' custom assertion method `assert_nothing_raised` to its proper place.
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-03 23:05:54 +0000