aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | No need to check nilTsukuru Tanimichi2017-04-021-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ```ruby nil.respond_to?(:stringify_keys) # => false ``` ```ruby include ActiveModel::AttributeAssignment Object.new.assign_attributes(nil) # => ArgumentError: When assigning attributes, you must pass a hash as an argument. ```
* | | | | | Merge pull request #28636 from bkeepers/patch-2Matthew Draper2017-04-021-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Limit stale checks to issues
| * | | | | | Limit stale checks to issuesBrandon Keepers2017-04-011-0/+2
| |/ / / / /
* | | | | | Remove CHANGELOG.md entry that appears in 5-1-stableJon Moss2017-04-011-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CHANGELOG.md is a continuation of the 5-1-stable one, there shouldn't be any duplicate entries. [ci skip]
* | | | | | Merge pull request #28629 from rossta/patch-4Jon Moss2017-04-011-2/+14
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Add default_scope note to ActiveRecord guide
| * | | | | Add default_scope note to AR guide [ci skip]Ross Kaffenberger2017-03-311-2/+14
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds note to explain unexpected behavior described in issue #28561. Developers may be surprised that the internal representation of similar query conditions in Hash and Array formats in default_scope will yield different results for model initialization. Link: https://github.com/rails/rails/issues/28561
* | | | | Correct typo in component nameAndrew White2017-03-311-1/+1
| | | | |
* | | | | Merge pull request #28621 from koic/fix_failed_test_when_running_with_oracleEileen M. Uchitelle2017-03-311-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Fix a failed AR test when running with OracleAdapter
| * | | | | Fix a failed AR test when running with OracleAdapterKoichi ITO2017-03-311-0/+2
| | | | | |
* | | | | | Merge pull request #28612 from tricknotes/ruby-2.3.4Andrew White2017-03-311-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | CI against Ruby 2.3.4
| * | | | | | CI against Ruby 2.3.4Ryunosuke Sato2017-03-311-3/+3
| |/ / / / / | | | | | | | | | | | | | | | | | | https://www.ruby-lang.org/en/news/2017/03/30/ruby-2-3-4-released/
* | | | | | Merge pull request #28620 from ↵Kasper Timm Hansen2017-03-311-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | y-yagi/add_missing_backtick_to_deprecation_message Add missing backtick to deprecation message
| * | | | | Add missing backtick to deprecation messageyuuji.yaginuma2017-03-311-1/+1
|/ / / / /
* | | | | Merge pull request #28616 from spdawson/patch-4Jon Moss2017-03-301-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix example usage of ActiveRecord::Base.establish_connection [ci skip]
| * | | | | Fix example usage of ActiveRecord::Base.establish_connectionSimon Dawson2017-03-301-1/+1
| | | | | | | | | | | | | | | | | | `ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
* | | | | | Small grammar fixJon Moss2017-03-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #28617 from javan/rails-ujs/fix-npm-packageRafael França2017-03-3014-105/+146
|\ \ \ \ \ \ | | | | | | | | | | | | | | Restore rails-ujs.js UMD module support
| * | | | | | Reorganize rails-ujs filesJavan Makhmali2017-03-3013-104/+104
| | | | | | |
| * | | | | | Restore rails-ujs.js UMD module supportJavan Makhmali2017-03-301-1/+42
| |/ / / / /
* | | | | | Merge pull request #28607 from mikeastock/move-hash-with-indifferent-access-testRafael França2017-03-302-712/+734
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Move HashWithIndifferentAccess tests to separate file
| * | | | | Move HashWithIndifferentAccess tests to separate fileMichael Stock2017-03-302-712/+734
| | | | | |
* | | | | | Merge pull request #28606 from maclover7/jm-fix-25820Andrew White2017-03-304-1/+64
|\ \ \ \ \ \ | | | | | | | | | | | | | | Do not include default response headers for AC::Metal
| * | | | | | Do not include default response headers for AC::MetalJon Moss2017-03-294-1/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 4.2, `ActionController::Metal` controllers did not include the default headers from `ActionDispatch::Response`. However, through e16afe6, and a general shift towards having `ActionController::Metal` objects contain `ActionDispatch::Response` objects (instead of just returning an array of status, headers, and body), this behavior was lost. This PR helps to restore the original behavior by having `ActionController::Metal` controllers generate Response objects without the default headers, while `ActionController::Base` now overrides the factory method to make sure its version does have the default headers.
* | | | | | | Merge pull request #28609 from rossta/patch-2Andrew White2017-03-301-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Update comment in sanitizer helper test [skip ci]
| * | | | | | | Update comment in sanitizer helper test [skip ci]Ross Kaffenberger2017-03-291-1/+1
| | |/ / / / / | |/| | | | | | | | | | | | The previously referenced file no longer appears to exist in the project.
* | | | | | | Merge pull request #28417 from schneems/schneems/symlink-failuresAndrew White2017-03-302-1/+28
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Raise when using a bad symlink
| * | | | | | Raise when using a bad symlinkschneems2017-03-142-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a case where a dev made a symlink that worked on some machines and not on others. The issue manifested itself on a machine with `RAILS_ENV=staging` as the had their `config/environments/staging.rb` symlinked to another config file. The behavior was very hard to track down. Current behavior: If you use a bad symlink in a file, you get no warnings or failures or anything. If you have a bad symlink it just ignores the file as if it didn't exist (`File.exist?` returns false for a bad symlink). Patch behavior: With this patch when a file is not present we check if a symlink exists. If it does, that indicates there is a bad symlink and we should raise ``` File "config/environments/staging.rb" is a symlink that does not point to a valid file ```
* | | | | | | Merge pull request #28603 from mikeastock/alias-reverse-mergeSean Griffin2017-03-295-0/+47
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Add an alias for reverse_merge to with_defaults
| * | | | | | Add aliases for reverse_merge to with_defaultsMatt Casper2017-03-295-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the context of controller parameters, reverse_merge is commonly used to provide defaults for user input. Having an alias to reverse_merge called with_defaults feels more idiomatic for Rails.
* | | | | | | Small grammar fixJon Moss2017-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add comma and change verb. [ci skip]
* | | | | | | Merge pull request #28595 from 3wille/fw-after-action-hintRafael França2017-03-291-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | add hint on after_action filters
| * | | | | | | add hint on after_action filtersFrederik Wille2017-03-291-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a hint that ``after_action``-callbacks are not executed when an exception was raised in the rest of the request cycle. The ``before_action`` section mentions "If there are additional filters scheduled to run after that filter, they are also cancelled." but this is IMO not sufficient.
* | | | | | | Merge pull request #28592 from ↵Rafael França2017-03-293-1/+18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | htanata/ar_relation_inspect_should_not_load_all_records Load only needed records on ActiveRecord::Relation#inspect
| * | | | | | | Load only needed records on ActiveRecord::Relation#inspectHendy Tanata2017-03-283-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of loading all records and returning only a subset of those, just load the records as needed. Fixes #25537.
* | | | | | | | Merge pull request #28602 from tricknotes/fix-rails-groups-exampleRafael França2017-03-291-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix the example code for `Rails.groups` [ci skip]
| * | | | | | | | Fix the example code for `Rails.groups` [ci skip]Ryunosuke Sato2017-03-301-2/+2
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | `Rails.groups` contains `Rails.env` that is inspected as String.
* | | | | | | | Merge pull request #28600 from tricknotes/ruby-2.2.7Rafael França2017-03-291-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | CI against Ruby 2.2.7
| * | | | | | | | CI against Ruby 2.2.7Ryunosuke Sato2017-03-301-2/+2
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | https://www.ruby-lang.org/en/news/2017/03/28/ruby-2-2-7-released/
* | | | | | | | Add test to make sure subclasses also get helpersRafael Mendonça França2017-03-291-0/+16
| | | | | | | |
* | | | | | | | Merge pull request #28598 from wnadeau/patch-1Rafael França2017-03-291-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | FinderMethods#fourty_two docs cite proper source
| * | | | | | | | FinderMethods#fourty_two docs cite proper sourceWinfred Nadeau2017-03-291-1/+1
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | silly method gets a silly doc fix, or I'm missing an even sillier joke and I'm about to get schooled. BUT I'm pretty sure this is some serious Beaudrillard simulacrum, though. I'm just doing my part to spread the gospel of Douglas Adams.
* | | | | | | | Merge pull request #28601 from tricknotes/fix-link-to-rails-ujsRafael França2017-03-295-5/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix link to rails-ujs
| * | | | | | | | Fix link to rails-ujsRyunosuke Sato2017-03-305-5/+5
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails-ujs is merged into actionview in favor of https://github.com/rails/rails/pull/28098. [skip ci]
* / / / / / / / Configure the days until close a stale issueRafael França2017-03-291-1/+3
|/ / / / / / / | | | | | | | | | | | | | | [ci skip]
* | | | | | | Merge pull request #28478 from kamipo/fix_primary_keys_across_multiple_schemasAndrew White2017-03-292-10/+9
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `primary_keys` across multiple schemas
| * | | | | | | Fix `primary_keys` across multiple schemasRyuta Kamizono2017-03-202-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #28470.
* | | | | | | | Remove CHANGELOG.md entry that appears in 5-1-stableJon Moss2017-03-291-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CHANGELOG.md is a continuation of the 5-1-stable one, there shouldn't be any duplicate entries. [ci skip]
* | | | | | | | Merge pull request #28586 from mtsmfm/override-driverEileen M. Uchitelle2017-03-292-6/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Make `driven_by` overridable
| * | | | | | | | Make `driven_by` overridableFumiaki MATSUSHIMA2017-03-292-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes we want to use rack_test partially instead of selenium for test speed: ```ruby class ApplicationSystemTestCase < ActionDispatch::SystemTestCase driven_by :selenium, using: :chrome, screen_size: [1400, 1400], options: {url: "http://chrome:4444/wd/hub"} end class WithJavaScriptTest < ApplicationSystemTestCase end class WithoutJavaScriptTest < ApplicationSystemTestCase driven_by :rack_test end ``` In the abobe case, `WithoutJavaScriptTest` uses selenium because `SystemTestCase` calls superclass' driver on `#initialize` (`self.class.superclass.driver.use`). Using `class_attribute` can handle inherited `driven_by`.
* | | | | | | | | Merge pull request #28590 from y-yagi/remove_unnecessary_javascript_option_checkAndrew White2017-03-291-4/+1
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Remove unnecessary `javascript` option check
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 23:42:10 +0000