| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/add-test-for-non-string-labeled-fixtures
Fix lookup of fixtures with non-string(like Fixnum) label
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Fixtures with non-string labels such as integers should be accessed
using integer label as key. For eg. pirates(1) or pirates(42).
- But this results in NotFound error because the label is converted into string before
looking up into the fixtures hash.
- After this commit, the label is converted into string only if its a
symbol.
- This issue was fount out while adding a test case for
https://github.com/rails/rails/commit/7b910917.
|
|\ \ \
| | | |
| | | | |
Improve protect_from_forgery documentation.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
removing unecessary default parameter in private method
|
| | | | |
| | | | |
| | | | |
| | | | | |
'_singularize' only ever gets called with one argument
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Documenting 'remove_possible_method' and 'redefine_method' [ci skip]
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
skip]
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Propagate bind_values from join in subquery
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`initialize_internals_callback` will attempt to assign attributes from
the current scope, which will fail if something defined the method
and calls super (meaning it won't hit `method_missing`).
Fixes #18339
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix rollback of primarykey-less tables
|
| | | | |
| | | | |
| | | | | |
If you have a table without a primary key, and an `after_commit` callback on that table (ie `has_transactional_callbacks?` returns true), then trying to rollback a transaction involving that record would result in “ActiveModel::MissingAttributeError: can't write unknown attribute ``”
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tigrish/fix_custom_i18n_exception_handler_regression
Fix I18n regression introduced by #13832
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Add Firebird support to test suite
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Clean up secure_token_test
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix TypeError in Fixture creation
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Ruby 4.2 started doing `value.gsub('$LABEL', label)` for fixture label interpolation, but you can have have valid YAML where `label` isn't a String.
For example:
```YAML
0:
name: John
email: johndoe@gmail.com
1:
name: Jane
email: janedoe@gmail.com
```
This YAML will create a label that is a Fixnum, causing `TypeError: no implicit conversion of Fixnum into String.`
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove unneeded check since /_one_time_conditions/ is not present anymore.
|
| | |_|/ / /
| |/| | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
brainopia/reset_template_assertion_without_warnings
Reset template assertions without warnings
|
|/ / / / / |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Addresses https://github.com/rails/rails/commit/ed56e596a0467390011bc9d56d462539776adac1#commitcomment-9145960
|
| | | | |
| | | | |
| | | | |
| | | | | |
addresses https://github.com/rails/rails/commit/91949e48cf41af9f3e4ffba3e5eecf9b0a08bfc3#commitcomment-9144563
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
This adresses https://github.com/rails/rails/commit/1b7aa62b184c4410c99208f71b59bbac5c5f03be#commitcomment-9147803
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Include newer `find_by` syntax example in 4.2 release notes for Adequate Record
|
| | |_|_|/
| |/| | |
| | | | |
| | | | | |
Adequate Record [skip ci]
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Document all options for protect_from_forgery.
|
|/ / / /
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
simplify ActiveSupport.test_order definition
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
It was not done to be included
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Use directly TZInfo::Timezone without proxy
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since real timezone is loaded anyway in `#utc_offset`
which is called during `#create`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This was used by the respond_to/respond_with implementation on this
file, which is now extracted to the responders gem.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This functionality has been extracted to the responders gem.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|