aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Improve description of tests.Guo Xiang Tan2014-07-251-4/+4
| | | | | | |
| * | | | | | Bug fix for assert_template when opening a new session.Guo Xiang Tan2014-07-252-5/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/pull/16234#commitcomment-7115670.
* | | | | | | Merge pull request #16281 from arthurnn/copy_default_proc_hwiaSantiago Pastorino2014-07-243-0/+16
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Make HWIA copy the default proc too.
| * | | | | | | Make HWIA copy the default proc too.Arthur Neves2014-07-243-0/+16
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | [fixes #16279]
* | | | | | | tests, run adapter specific rake tests only for the right adapter.Yves Senn2014-07-243-0/+6
| | | | | | |
* | | | | | | build fix, fix error introduced with 091b246bb0111357edbb9703ea342a944b04deb6Yves Senn2014-07-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes the following issue: 1) Failure: ActiveRecord::MySQLPurgeTest#test_establishes_connection_to_test_database [test/cases/tasks/mysql_rake_test.rb:200]: not all expectations were satisfied unsatisfied expectations: - expected exactly once, not yet invoked: ActiveRecord::Base.establish_connection(:test) satisfied expectations: - allowed any number of times, invoked once: #<Mock:0x2349430>.recreate_database(any_parameters) - allowed any number of times, invoked once: ActiveRecord::Base.establish_connection(any_parameters) - allowed any number of times, invoked once: ActiveRecord::Base.connection(any_parameters)
* | | | | | | fix, mysql `db:purge` respects `Rails.env`.Yves Senn2014-07-242-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously this method always established a connection to the test database. This resulted in buggy behavior when combined with other tasks like `bin/rake db:schema:load`. This was one of the reasons why #15394 (22e9a91189af2c4e6217a888e77f22a23d3247d1) was reverted: > I’ve replicated it on a new app by the following commands: 1) rails generate model post:title, 2) rake db:migrate, 3) rake db:schema:load, 4) rails runner ‘puts Post.first’. The last command goes boom. Problem is that rake db:schema:load wipes the database, and then doesn’t actually restore it. This is all on MySQL. There’s no problem with SQLite. -- DHH https://github.com/rails/rails/commit/22e9a91189af2c4e6217a888e77f22a23d3247d1#commitcomment-6834245
* | | | | | | clenaup, unify CHANGELOG format. [ci skip]Yves Senn2014-07-241-5/+7
| | | | | | |
* | | | | | | Merge pull request #16280 from a3gis/masterMatthew Draper2014-07-241-2/+2
|\ \ \ \ \ \ \ | | |_|/ / / / | |/| | | | | Fixes #16265 and correct documentation typo
| * | | | | | Fix documentation typo in ConnectionSpecification::Resolve.speca3gis2014-07-241-1/+1
| | | | | | |
| * | | | | | Fixes #16265a3gis2014-07-241-1/+1
| | | | | | |
* | | | | | | pg, `change_column_default, :table, :column, nil` issues `DROP DEFAULT`.Yves Senn2014-07-242-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #16261. [Matthew Draper, Yves Senn] Using `DEFAULT NULL` results in the same behavior as `DROP DEFAULT`. However, PostgreSQL will cast the default to the columns type, which leaves us with a default like "default NULL::character varying". /cc @matthewd
* | | | | | | Merge pull request #16276 from y-yagi/bug_report_templatesMatthew Draper2014-07-242-0/+2
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | [ci skip]Add i18n master to the Gemfile
| * | | | | | [ci skip]Add i18n master to the Gemfileyuuji.yaginuma2014-07-242-0/+2
| |/ / / / /
* | | | | | Merge pull request #16260 from akshay-vishnoi/doc-changeMatthew Draper2014-07-241-2/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Calling require_self twice in css raises Sprockets::ArgumentError exception [ci skip]
| * | | | | Calling require_self twice in css raises Sprockets::ArgumentError exception ↵Akshay Vishnoi2014-07-241-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Remove mocha usageRafael Mendonça França2014-07-231-2/+5
| | | | | |
* | | | | | Fix syntax errorRafael Mendonça França2014-07-231-1/+2
| | | | | |
* | | | | | Dev and edge application and plugins need to include i18n masterRafael Mendonça França2014-07-231-1/+2
| | | | | |
* | | | | | Merge pull request #16267 from robin850/rbx-yamlRafael Mendonça França2014-07-233-0/+28
|\ \ \ \ \ \ | | | | | | | | | | | | | | Set Psych as the YAML engine for Rubinius
| * | | | | | Set Psych as the YAML engine for RubiniusRobin Dupret2014-07-233-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the rubysl-yaml gem doesn't ship with Psych by default because of its dependency on libyaml, on Rubinius, the default engine is Syck. However, if we want to be able to run the application safely on different rubies, we need to make people using Rubinius rely on Psych. See http://git.io/uuLVag for further information.
* | | | | | | Do not set enforce_available_locales to i18n 0.7Rafael Mendonça França2014-07-233-22/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales.
* | | | | | | Split Action Pack tests in a new job on travisRafael Mendonça França2014-07-231-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make easier to compare run time between Ruby 2.1 and trunk
* | | | | | | Use PROCESS_COUNT to define the number of parallel executorsRafael Mendonça França2014-07-231-1/+1
| | | | | | |
* | | | | | | specify N=0 to prevent parallel tests (just run tests on the main process)Aaron Patterson2014-07-231-2/+6
|/ / / / / /
* | | | | | Merge pull request #16237 from tonytonyjan/patchArthur Nogueira Neves2014-07-231-4/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | `create` method returns an active record object with errors instead of false when validation fails. [skip ci]
| * | | | | | `create` return an active record object with erros instead of false when ↵Tony Jian2014-07-231-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | validation fails. [skip ci]
* | | | | | | Merge pull request #16234 from ↵Yves Senn2014-07-223-5/+66
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | tgxworld/fix_template_assertion_for_integration_test Fix AC::TemplateAssertions instance variables not resetting.
| * | | | | | Fix AC::TemplateAssertions instance variables not resetting.Guo Xiang Tan2014-07-213-5/+66
| |/ / / / / | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/16119.
* | | | | | Merge pull request #16256 from akshay-vishnoi/doc-changeRafael Mendonça França2014-07-221-1/+1
|\ \ \ \ \ \ | | |/ / / / | |/| | | | Fixes #16255 [ci skip]
| * | | | | Fixes #16255 [ci skip]Akshay Vishnoi2014-07-221-1/+1
|/ / / / /
* | | | | Merge pull request #16231 from Envek/type_in_referencesYves Senn2014-07-226-5/+56
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow to specify a type for foreign key column in migrations * unified the docs * some cleanup in CHANGELOG
| * | | | | Allow to specify a type for foreign key column in migrationsAndrey Novikov2014-07-226-3/+46
|/ / / / / | | | | | | | | | | | | | | | [Andrey Novikov & Łukasz Sarnacki]
* | | | | Merge pull request #16253 from ↵Yves Senn2014-07-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_nested_through_associations_test Make sure assertion passes for postgresql.
| * | | | | Make sure assertion passes for postgresql.Zuhao Wan2014-07-221-1/+1
| | | | | |
* | | | | | Merge pull request #16254 from ↵Yves Senn2014-07-221-1/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_attribute_decorators_test Remove redundant reset that already happened in teardown.
| * | | | | Remove redundant that already happened in teardown.Zuhao Wan2014-07-221-1/+0
|/ / / / /
* | | | | build fix, remove not null constraint.Yves Senn2014-07-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fixtures are still in play, adding a new column without a default and `null: true` is not possible. This reverts back to leaking global state, as our `schema.rb` adds the `null: false` constraint on this field. A future solution would be to make the `migration_test.rb` run independent of fixture tables. This way we can simply drop the state after test execution, without worrying about side effects. /cc @zuhao
* | | | | Merge pull request #16250 from zuhao/refactor_activerecord_migration_testYves Senn2014-07-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Remove length limit that results failure in other tests.
| * | | | | Remove length limit that results failure in other tests.Zuhao Wan2014-07-221-1/+1
| | | | | |
* | | | | | docs, add example for running a single test against core adapters.Yves Senn2014-07-221-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #16248 from ↵Yves Senn2014-07-221-2/+3
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_presence_validation_test Remove the side-effects of validates_presence_of.
| * | | | | Remove the side-effects of validates_presence_of.Zuhao Wan2014-07-221-2/+3
|/ / / / /
* | | | | Merge pull request #16232 from egilburg/activesupport_coverageRafael Mendonça França2014-07-2111-4/+114
|\ \ \ \ \ | | | | | | | | | | | | Added some missing activesupport test coverage
| * | | | | missing activesupport test coverageEugene Gilburg2014-07-1911-4/+114
| |/ / / /
* | | | | Merge pull request #16239 from akshay-vishnoi/remove-requireRafael Mendonça França2014-07-211-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove not-required file class/subclasses
| * | | | | Remove not-required file class/subclassesAkshay Vishnoi2014-07-211-1/+0
| | | | | |
* | | | | | Merge pull request #16242 from vadivelan-k/content_verifierArthur Nogueira Neves2014-07-211-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Touch option description grammatical error fixed [ci skip]
| * | | | | | Touch option description grammatical error fixed [ci skip]vadivelan2014-07-211-1/+1
|/ / / / / /
* | | | | | Merge pull request #16240 from siddharthbhagwan/masterEileen M. Uchitelle2014-07-211-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Generators guide grammatical error fixed [ci skip]