Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Merge pull request #10565 from prathamesh-sonpatki/rake-db | Carlos Antonio da Silva | 2013-07-02 | 2 | -4/+4 | |
|\ | | | | | Improved grammar and replaced 'dbs' slang with 'databases' | |||||
| * | Improved grammar and replaced 'dbs' slang with 'databases' | Prathamesh Sonpatki | 2013-06-27 | 2 | -4/+4 | |
| | | ||||||
* | | Remove deprecated Hash#diff with no replacement. | Carlos Antonio da Silva | 2013-07-02 | 4 | -23/+7 | |
| | | | | | | | | | | If you're using it to compare hashes for the purpose of testing, please use MiniTest's assert_equal instead. | |||||
* | | Merge pull request #10909 from dockyard/master | Carlos Antonio da Silva | 2013-07-02 | 1 | -6/+6 | |
|\ \ | | | | | | | Use symbols instead of strings in ActiveSupport::Concern | |||||
| * | | Use symbols instead of strings | Brian Cardarella | 2013-06-10 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Concern is used all over Rails This PR will only create 3 new objects as keys are never recreated and are not subject to garbage collection. The strings were being uniquely created and garbage collected. I don't have any performance numbers but this should be better than all of the GC. | |||||
* | | | Merge pull request #11134 from wangjohn/object_orienting_testing_rake_file | Carlos Antonio da Silva | 2013-07-02 | 2 | -15/+45 | |
|\ \ \ | | | | | | | | | Making the rake file for tests easier to read. | |||||
| * | | | Making the rake file for tests easier to read. | wangjohn | 2013-06-25 | 2 | -15/+45 | |
| | | | | | | | | | | | | | | | | | | | | I'm defining a new class which modularizes how the `rake test` tasks are defined and invoked. | |||||
* | | | | Merge pull request #11258 from frodsan/remove_deprecated_distinct | Carlos Antonio da Silva | 2013-07-02 | 3 | -55/+4 | |
|\ \ \ \ | | | | | | | | | | | Remove deprecated SchemaStatements#distinct | |||||
| * | | | | Remove deprecated SchemaStatements#distinct | Francesco Rodriguez | 2013-07-02 | 3 | -55/+4 | |
| | | | | | ||||||
* | | | | | Remove deprecated Rails application fallback for integration testing | Carlos Antonio da Silva | 2013-07-02 | 2 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | Set ActionDispatch.test_app instead. | |||||
* | | | | | Remove deprecated constants autoload | Carlos Antonio da Silva | 2013-07-02 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | These constants were removed in 4b97ce5eb16cc20207516387fba98bf577e2e281, but I forgot to remove the autoload calls :sparkles:. | |||||
* | | | | | Remove the deprecated include_seconds argument from distance_of_time_in_words | Carlos Antonio da Silva | 2013-07-02 | 2 | -10/+7 | |
| | | | | | | | | | | | | | | | | | | | | Pass in an :include_seconds hash option to use this feature. | |||||
* | | | | | reduce the amount of code Ruby has to parse | Aaron Patterson | 2013-07-02 | 1 | -3/+8 | |
| | | | | | ||||||
* | | | | | freeze the constant value so it isn't duped when used as a hash key | Aaron Patterson | 2013-07-02 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | making the comment more accurate | Aaron Patterson | 2013-07-02 | 1 | -2/+5 | |
| | | | | | ||||||
* | | | | | stop storing multiple copies of a particular attribute name | Aaron Patterson | 2013-07-02 | 3 | -16/+16 | |
| | | | | | ||||||
* | | | | | eagerly assign the attribute name cache, remove const_missing | Aaron Patterson | 2013-07-02 | 3 | -2/+9 | |
| | | | | | ||||||
* | | | | | initialize generated modules on inclusion and on inheritence | Aaron Patterson | 2013-07-02 | 2 | -8/+1 | |
| | | | | | ||||||
* | | | | | push attribute constant cache in to the attribute methods module | Aaron Patterson | 2013-07-02 | 2 | -7/+9 | |
| | | | | | ||||||
* | | | | | fix to_sql output on eager loaded relations | Aaron Patterson | 2013-07-02 | 2 | -1/+17 | |
| | | | | | ||||||
* | | | | | lock around mutating the generated methods module | Aaron Patterson | 2013-07-02 | 1 | -2/+4 | |
| | | | | | ||||||
* | | | | | remove private attribute reader | Aaron Patterson | 2013-07-02 | 2 | -8/+4 | |
| | | | | | ||||||
* | | | | | define attribute methods in a thread safe manner | Aaron Patterson | 2013-07-02 | 1 | -5/+4 | |
| | | | | | ||||||
* | | | | | we don't need to use active support *everwhere* common. | Aaron Patterson | 2013-07-02 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | initialize ivars so we don't have to constantly check them | Aaron Patterson | 2013-07-02 | 1 | -1/+3 | |
| | | | | | ||||||
* | | | | | eagerly initialize the attributes module to avoid check-then-set race conditions | Aaron Patterson | 2013-07-02 | 3 | -9/+17 | |
|/ / / / | ||||||
* | | | | Merge pull request #11257 from arunagw/adding_actionview | Carlos Antonio da Silva | 2013-07-02 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Adding actionview in Rakefile to run test [ci skip] | |||||
| * | | | | Adding actionview in Rakefile to run test | Arun Agrawal | 2013-07-02 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | and create versions | |||||
* | | | | | remove wrong documentation from a :nodoc:'d method | Aaron Patterson | 2013-07-02 | 1 | -1/+0 | |
|/ / / / | ||||||
* | | | | remove unused `ActiveRecord::TestCase#sqlite3` method. | Yves Senn | 2013-07-02 | 1 | -6/+0 | |
| | | | | ||||||
* | | | | deprecated `ActiveRecord::TestCase` is no longer public. | Yves Senn | 2013-07-02 | 4 | -99/+100 | |
| | | | | | | | | | | | | | | | | /cc @tenderlove | |||||
* | | | | Merge pull request #11255 from neerajdotname/restrict-be-gone | Carlos Antonio da Silva | 2013-07-02 | 9 | -49/+9 | |
|\ \ \ \ | | | | | | | | | | | Dropped deprecated option `:restrict` for `:dependent` in associations | |||||
| * | | | | Dropped deprecated option `:restrict` for `:dependent` in associations | Neeraj Singh | 2013-07-03 | 9 | -49/+9 | |
|/ / / / | ||||||
* | | | | Merge pull request #11254 from neerajdotname/delete-sql-be-gone | Rafael Mendonça França | 2013-07-02 | 5 | -46/+15 | |
|\ \ \ \ | | | | | | | | | | | Removed support for deprecated `delete_sql` in associations. | |||||
| * | | | | Removed support for deprecated `delete_sql` in associations. | Neeraj Singh | 2013-07-03 | 5 | -46/+15 | |
|/ / / / | ||||||
* | | | | no need to to_sym the column name, leave it as-is | Aaron Patterson | 2013-07-02 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | resolve aliases before passing the hash to the predicate builder | Aaron Patterson | 2013-07-02 | 3 | -4/+12 | |
| | | | | ||||||
* | | | | Merge pull request #11253 from neerajdotname/removed-insert-sql | Rafael Mendonça França | 2013-07-02 | 3 | -10/+10 | |
|\ \ \ \ | | | | | | | | | | | Removed support for deprecated `insert_sql` in associations. | |||||
| * | | | | Removed support for deprecated `insert_sql` in associations. | Neeraj Singh | 2013-07-02 | 3 | -10/+10 | |
|/ / / / | ||||||
* | | | | Merge pull request #11252 from neerajdotname/use-extract-options | Rafael Mendonça França | 2013-07-02 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | use extract_options! | |||||
| * | | | | use extract_options! | Neeraj Singh | 2013-07-02 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #11251 from neerajdotname/deprecated-finder-sql | Rafael Mendonça França | 2013-07-02 | 9 | -210/+23 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Removed support for deprecated finder sql | |||||
| * | | | | fix indentation | Neeraj Singh | 2013-07-02 | 1 | -14/+14 | |
| | | | | | ||||||
| * | | | | Removed support for deprecated `finder_sql` in associations. | Neeraj Singh | 2013-07-02 | 9 | -197/+10 | |
|/ / / / | ||||||
* | | | | Add CHANGELOG enty for #11235 | Rafael Mendonça França | 2013-07-02 | 2 | -1/+4 | |
| | | | | ||||||
* | | | | Merge pull request #11241 from neerajdotname/deprecated-counter-sql | Rafael Mendonça França | 2013-07-02 | 8 | -79/+19 | |
|\ \ \ \ | | | | | | | | | | | Removed support for deprecated `counter_sql` | |||||
| * | | | | Removed support for deprecated `counter_sql` | Neeraj Singh | 2013-07-02 | 8 | -79/+19 | |
|/ / / / | ||||||
* | | | | Merge pull request #11240 from neerajdotname/remove-not-useful-test | Carlos Antonio da Silva | 2013-07-02 | 1 | -8/+0 | |
|\ \ \ \ | | | | | | | | | | | Removing not useful test related to reflect_on_all_associations | |||||
| * | | | | Removing not useful test related to reflect_on_all_associations | Neeraj Singh | 2013-07-02 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The comment in the test pretty much summarizes the issue. `FIXME these assertions bust a lot` Adding any type of association in class `Firm` will break this test. I removed some deprecated stuff and this test failed. I do not think this test provides any useful value. First of all who counted last that 39 is the right number of associations. Secondly there are a large number of tests which depend on reflection returning right information about associations. Those tests will start failing if there is a bug in the code. | |||||
* | | | | | Merge pull request #11244 from ccarruitero/testing-guide | Carlos Antonio da Silva | 2013-07-02 | 1 | -2/+2 | |
|\ \ \ \ \ | |/ / / / |/| | | | | update test names in testing guide [ci-skip] |