Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Merge pull request #8777 from goshakkk/delegate-class | Andrew White | 2013-01-06 | 5 | -5/+5 | |
|\ \ \ \ | | | | | | | | | | | Delegate to :class rather than 'self.class' | |||||
| * | | | | delegate to :class rather than 'self.class' | Gosha Arinich | 2013-01-06 | 5 | -5/+5 | |
| | | | | | ||||||
* | | | | | Refactor the logic that checks whether or not to emit the hidden id field | Carlos Antonio da Silva | 2013-01-06 | 1 | -7/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects. | |||||
* | | | | | Move the hidden :id field logic to where it belongs to | Carlos Antonio da Silva | 2013-01-06 | 1 | -6/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense. | |||||
* | | | | | Eliminate the usage of parent_builder option from form_for | Carlos Antonio da Silva | 2013-01-06 | 1 | -19/+15 | |
| | | | | | | | | | | | | | | | | | | | | Just use it internally from fields_for until we come up with a better solution. | |||||
* | | | | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 2 | -6/+18 | |
| | | | | | ||||||
* | | | | | Refactor to not call path.ast twice | Carlos Antonio da Silva | 2013-01-06 | 1 | -2/+3 | |
| | | | | | ||||||
* | | | | | Merge pull request #8779 from goshakkk/refactor-route-ast | Carlos Antonio da Silva | 2013-01-06 | 1 | -5/+4 | |
|\ \ \ \ \ | | | | | | | | | | | | | Refactor Route#ast to use or-equals and block, instead of return with a check | |||||
| * | | | | | refactor Route#ast to use or-equals and block, instead of return with a cond | Gosha Arinich | 2013-01-06 | 1 | -5/+4 | |
| | | | | | | ||||||
* | | | | | | Improve javascript in welcome page [ci skip] | Carlos Antonio da Silva | 2013-01-06 | 1 | -4/+5 | |
| | | | | | | ||||||
* | | | | | | This is not that common of a change to warrant top-line billing and you ↵ | David Heinemeier Hansson | 2013-01-06 | 1 | -6/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | should read more about the consequences than just toggling a boolean to make best use of it | |||||
* | | | | | | Include the standard reminder that you need to restart for changes in ↵ | David Heinemeier Hansson | 2013-01-06 | 2 | -0/+4 | |
|/ / / / / | | | | | | | | | | | | | | | | config/initializers to take effect | |||||
* | | | | | Update generated app's README [ci skip] | Akira Matsuda | 2013-01-06 | 1 | -7/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * a controller that destroying Weblogs might be WeblogsController * a controller that indexing Posts might be PostsController * Post.all returns a Relation * modernize Model.inspect results | |||||
* | | | | | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 15 | -123/+94 | |
| | | | | | ||||||
* | | | | | The controller generator invokes assets generator in addition | Akira Matsuda | 2013-01-06 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Fix generated migration file name in model generator USAGE | Akira Matsuda | 2013-01-06 | 1 | -7/+7 | |
| | | | | | ||||||
* | | | | | Update mailer generator USAGE | Akira Matsuda | 2013-01-06 | 1 | -3/+2 | |
|/ / / / | | | | | | | | | | | | | | | | | * it does not generate fixtures * it generates .text.erb templates | |||||
* | | | | Merge pull request #8774 from goshakkk/multiline-block-do-end | Carlos Antonio da Silva | 2013-01-05 | 3 | -6/+6 | |
|\ \ \ \ | |_|_|/ |/| | | | Prefer do-end for multiline block [ci skip] | |||||
| * | | | prefer do-end for multiline block | Gosha Arinich | 2013-01-06 | 3 | -6/+6 | |
|/ / / | ||||||
* | | | Merge pull request #8772 from goshakkk/guides-warning-fix | Rafael Mendonça França | 2013-01-05 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Fix guides' warning bottom padding | |||||
| * | | | fix guides' warning bottom padding | Gosha Arinich | 2013-01-06 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Remove the content_tag_for change from CHANGELOG since it was reverted | Rafael Mendonça França | 2013-01-05 | 1 | -5/+3 | |
| | | | ||||||
* | | | Merge pull request #8771 from lucasmazza/unobtrusive-javascript-examples | Steve Klabnik | 2013-01-05 | 1 | -31/+33 | |
|\ \ \ | | | | | | | | | New code examples on "Working with JavaScript in Rails" guide. | |||||
| * | | | Update some code examples on the "Working with JavaScript in Rails" guide. | Lucas Mazza | 2013-01-05 | 1 | -31/+33 | |
| | | | | ||||||
* | | | | Fix documentation to content_tag_for [ci skip] | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 | |
|/ / / | ||||||
* | | | Move config.filter_parameters to you own initializer file | Rafael Mendonça França | 2013-01-05 | 3 | -5/+4 | |
| | | | | | | | | | | | | This is very rarely changed and does not deserve to be in application.rb | |||||
* | | | Merge pull request #8766 from jcoglan/session_token_docs | Andrew White | 2013-01-05 | 1 | -7/+4 | |
|\ \ \ | | | | | | | | | | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip] | |||||
| * | | | Remove suggestion that Procs can be used as session secrets. | James Coglan | 2013-01-05 | 1 | -7/+4 | |
| | | | | ||||||
* | | | | Needless fancy structure that did not anything | David Heinemeier Hansson | 2013-01-05 | 1 | -1/+3 | |
| | | | | ||||||
* | | | | Assert config.filter_parameters should be able to be set in a initializer | Rafael Mendonça França | 2013-01-05 | 1 | -0/+10 | |
| | | | | ||||||
* | | | | Fix indention issue in generated template | David Heinemeier Hansson | 2013-01-05 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Fix indention issue in generated template | David Heinemeier Hansson | 2013-01-05 | 1 | -2/+2 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #8769 from senny/deprecate_assert_blank | David Heinemeier Hansson | 2013-01-05 | 16 | -43/+60 | |
|\ \ \ | | | | | | | | | deprecate `assert_blank` and `assert_present`. | |||||
| * | | | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 16 | -43/+60 | |
| | | | | | | | | | | | | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | |||||
* | | | | No need to give an example where there is generated code right there to ↵ | David Heinemeier Hansson | 2013-01-05 | 1 | -5/+1 | |
| | | | | | | | | | | | | | | | | serve as the example | |||||
* | | | | Make sure assets is disable when --skip-sprockets is used | Rafael Mendonça França | 2013-01-05 | 1 | -1/+2 | |
| | | | | ||||||
* | | | | config.assets.enabled is now true by default | David Heinemeier Hansson | 2013-01-05 | 5 | -9/+14 | |
|/ / / | ||||||
* | | | Merge pull request #8768 from goshakkk/about-env-toggling | Guillermo Iguaran | 2013-01-05 | 1 | -7/+11 | |
|\ \ \ | | | | | | | | | Allow toggling "about app's env", not just showing | |||||
| * | | | allow toggling about env, not just showing | Gosha Arinich | 2013-01-05 | 1 | -7/+11 | |
|/ / / | ||||||
* / / | Remove warning, remove not used variable, and make methods private | Carlos Antonio da Silva | 2013-01-05 | 1 | -3/+5 | |
|/ / | | | | | | | Warning: "shadowing outer local variable - routes". | |||||
* | | Close container div tag in routing error page | Carlos Antonio da Silva | 2013-01-05 | 1 | -9/+11 | |
| | | ||||||
* | | Move style to head to make routes page valid html5 | Carlos Antonio da Silva | 2013-01-05 | 3 | -4/+8 | |
| | | ||||||
* | | Redirect using action hash instead of hardcoding full route | Carlos Antonio da Silva | 2013-01-05 | 1 | -1/+1 | |
| | | ||||||
* | | Change Rails Info controller to use the new table routes formatter | Carlos Antonio da Silva | 2013-01-05 | 2 | -5/+2 | |
| | | ||||||
* | | Action Pack changelog improvements [ci skip] | Carlos Antonio da Silva | 2013-01-05 | 1 | -32/+35 | |
| | | ||||||
* | | Merge pull request #8658 from senny/8649_unify_routes_output_for_console_and_web | Carlos Antonio da Silva | 2013-01-05 | 7 | -37/+111 | |
|\ \ | | | | | | | | | | | | | Unify routes output for console and web, ensure engine routes are shown in html routes table. Closes #8649. | |||||
| * | | display mountable engine routes on RoutingError. | Yves Senn | 2013-01-05 | 4 | -11/+46 | |
| | | | ||||||
| * | | split formatting concerns from RoutesInspector | Yves Senn | 2013-01-05 | 3 | -26/+65 | |
|/ / | ||||||
* | | Merge pull request #8737 from tricknotes/info-page-style | Carlos Antonio da Silva | 2013-01-05 | 2 | -3/+4 | |
|\ \ | | | | | | | Fix info page style [ci skip] | |||||
| * | | Don't use layout when requested from xhr | Ryunosuke SATO | 2013-01-05 | 2 | -3/+4 | |
| | | |