| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Active Record can be configured via the environment variable `DATABASE_URL` or by manually injecting a hash of values which is what Rails does, reading in `database.yml` and setting Active Record appropriately. Active Record expects to be able to use `DATABASE_URL` without the use of Rails, and we cannot rip out this functionality without deprecating. This presents a problem though when both config is set, and a `DATABASE_URL` is present. Currently the `DATABASE_URL` should "win" and none of the values in `database.yml` are used. This is somewhat unexpected to me if I were to set values such as `pool` in the `production:` group of `database.yml` they are ignored.
There are many ways that active record initiates a connection today:
- Stand Alone (without rails)
- `rake db:<tasks>`
- ActiveRecord.establish_connection
- With Rails
- `rake db:<tasks>`
- `rails <server> | <console>`
- `rails dbconsole`
We should make all of these behave exactly the same way. The best way to do this is to put all of this logic in one place so it is guaranteed to be used.
Here is my prosed matrix of how this behavior should work:
```
No database.yml
No DATABASE_URL
=> Error
```
```
database.yml present
No DATABASE_URL
=> Use database.yml configuration
```
```
No database.yml
DATABASE_URL present
=> use DATABASE_URL configuration
```
```
database.yml present
DATABASE_URL present
=> Merged into `url` sub key. If both specify `url` sub key, the `database.yml` `url`
sub key "wins". If other paramaters `adapter` or `database` are specified in YAML,
they are discarded as the `url` sub key "wins".
```
### Implementation
Current implementation uses `ActiveRecord::Base.configurations` to resolve and merge all connection information before returning. This is achieved through a utility class: `ActiveRecord::ConnectionHandling::MergeAndResolveDefaultUrlConfig`.
To understand the exact behavior of this class, it is best to review the behavior in activerecord/test/cases/connection_adapters/connection_handler_test.rb though it should match the above proposal.
|
|\
| |
| | |
MySQL version 4.1 was EOL on December 31, 2009 [ci-skip]
|
|/
|
|
| |
We should at least recommend modern versions of MySQL to users.
|
|
|
|
|
|
|
|
| |
fixes #13547
The body may use the local cache during rendering. `call`ing the app
doesn't mean that rendering is finished, so we need to wait until
`close` is called on the body.
|
| |
|
|\
| |
| | |
Move finish_template as the last public method defined in the generator
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Fix typo [ci skip]
|
|/ |
|
| |
|
|
|
|
| |
Closes #13623.
|
|\
| |
| | |
Be more explicit about the default of db:drop and db:create
|
|/
|
|
| |
Closes #13625
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3.
As described in PR #13627 this commit broke functionality when passing
a negative Fixnum to the `String#to` method:
```ruby
assert_equal "hell", s.to(-2)
```
Before the revert, this failed with:
```
1) Failure:
StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]:
Expected: "hell"
Actual: nil
```
This revert is to keep the functionality on `master` working.
If there is another way to get the performance benefit and keep
the documented functionality we can add that.
/cc @amatsuda @carlosantoniodasilva
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also extracted the tests from a single bulk method into a separate test-case.
The new tests cover the API described in the docs.
There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3
* #to with negative Fixnum, position is counted from the end
* #from and #to can be combined
This was brought to my attention by #13627.
Closes #13627.
|
|\
| |
| |
| |
| |
| |
| | |
activerecord: Initialize Migration with version from MigrationProxy.
Conflicts:
activerecord/CHANGELOG.md
|
| | |
|
|\ \
| | |
| | | |
Fix typo in image_tag documentation [ci skip]
|
|/ /
| |
| | |
image_tag only supports :alt and :size as additional keys, not three.
|
|\ \
| | |
| | | |
Make change_table use object of current database adapter
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Earlier, change_table was creating database-agnostic object.
- After this change, it will create correct object based on current
database adapter.
- This will ensure that create_table and change_table will get same objects.
- This makes update_table_definition method public and nodoc.
- Fixes #13577 and #13503
|
|/ /
| |
| |
| |
| | |
Also improve changelog entries related to secure password to proper
highlight.
|
|\ \
| | |
| | | |
Add 'e' var on rescue DalliError, in order to log it
|
|/ / |
|
|\ \
| |/
|/| |
Remove warnings in test suite
|
|/
|
|
|
|
|
| |
lib/active_record/store.rb:79: warning: method redefined; discarding old color=
lib/active_record/store.rb:79: warning: previous definition of color= was here
lib/active_record/store.rb:83: warning: method redefined; discarding old color
lib/active_record/store.rb:83: warning: previous definition of color was here
|
|\
| |
| | |
Fix: ActiveRecord::Store TypeError conversion when using YAML coder
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Renaming the test accordingly to its behaviour
Adding 'Fixes' statement to changelog
Improving tests legibility & changelog
Undoing mistakenly removed empty line & further improving changelog
|
| |
| |
| |
| | |
/cc @pixeltrix
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Wrapping symbols with + does not work, we must use <tt> instead.
|
|\ \
| | |
| | | |
Add missing tests for invalid names in `rails plugin new` generator
|
| | |
| | |
| | |
| | |
| | | |
* Test for: Invalid plugin name, because of reserved rails word.
* Test for: Invalid plugin name because of constant name that is already in use.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Require actionview/version
|
|/ / /
| | |
| | |
| | | |
just like all the other modules do require their version file
|
|\ \ \
| |_|/
|/| | |
Ruby is a proper noun here, not part of code fragment [ci skip]
|
|/ /
| |
| |
| |
| | |
Last line of note also relates heavily to first part
and parenthesis broke reading flow.
|
| |
| |
| |
| | |
Fixes #12777
|
| | |
|
|\ \
| | |
| | | |
Maintain proleptic gregorian in Time#advance
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Time#advance uses Time#to_date and Date#advance to calculate a new date.
The Date object returned by Time#to_date is constructed with the assumption
that the Time object represents a proleptic gregorian date, but it is
configured to observe the default julian calendar reform date (2299161j)
for purposes of calculating month, date and year:
Time.new(1582, 10, 4).to_date.to_s # => "1582-09-24"
Time.new(1582, 10, 4).to_date.gregorian.to_s # => "1582-10-04"
This patch ensures that when the intermediate Date object is advanced
to yield a new Date object, that the Time object for return is contructed
with a proleptic gregorian month, date and year.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove method redefined warnings for test suite
Closes #13526
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
has_many definitions with "name" as singular and as plural e.g.
has_many :welcome_posts_with_comment
has_many :welcome_posts_with_comments
Ruby mentions it with:
lib/active_record/associations/builder/collection_association.rb:65:
warning: method redefined; discarding old welcome_posts_with_comment_ids
lib/active_record/associations/builder/collection_association.rb:65:
warning: previous definition of welcome_posts_with_comment_ids was here
lib/active_record/associations/builder/collection_association.rb:75:
warning: method redefined; discarding old welcome_posts_with_comment_ids=
lib/active_record/associations/builder/collection_association.rb:75:
warning: previous definition of welcome_posts_with_comment_ids= was here
|