aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge pull request #34666 from vinistock/upgrade_rubocop_and_fix_offensesRafael França2018-12-108-183/+184
|\ \ \ \ \ | | | | | | | | | | | | Upgrade Rubocop to 0.61.1 and fix offenses
| * | | | | Upgrade Rubocop to 0.61.1 and fix offensesVinicius Stock2018-12-108-183/+184
| | | | | |
* | | | | | An explain query does not raise the `ReadOnlyError` if preventing writesRyuta Kamizono2018-12-114-3/+11
| | | | | |
* | | | | | Don't treat begin and rollback transactions as write queriesRyuta Kamizono2018-12-115-6/+17
|/ / / / / | | | | | | | | | | | | | | | | | | | | Otherwise `save` method would raise the `ReadOnlyError` against `BEGIN` and `ROLLBACK` queries.
* | | | | Prevent write queries with prepared statements for mysql2 adapterRyuta Kamizono2018-12-111-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this change, mysql2 adapter with prepared statements won't pass `base_test.rb`. ``` % ARCONN=mysql2 be ruby -w -Itest test/cases/base_test.rb Using mysql2 Run options: --seed 27614 # Running: ....S..............................F Failure: BasicsTest#test_creating_a_record_raises_if_preventing_writes [test/cases/base_test.rb:1493]: ActiveRecord::ReadOnlyError expected but nothing was raised. rails test test/cases/base_test.rb:1492 ...F Failure: BasicsTest#test_deleting_a_record_raises_if_preventing_writes [test/cases/base_test.rb:1513]: ActiveRecord::ReadOnlyError expected but nothing was raised. rails test test/cases/base_test.rb:1510 ............................................................................................................F Failure: BasicsTest#test_updating_a_record_raises_if_preventing_writes [test/cases/base_test.rb:1503]: ActiveRecord::ReadOnlyError expected but nothing was raised. rails test test/cases/base_test.rb:1500 .......... Finished in 2.534490s, 62.7345 runs/s, 149.5370 assertions/s. 159 runs, 379 assertions, 3 failures, 0 errors, 1 skips ```
* | | | | Prevent write queries for `exec_query`Ryuta Kamizono2018-12-113-1/+46
| | | | | | | | | | | | | | | | | | | | Follow up #34505.
* | | | | Add test for reads environment credential file with environment variable keyyuuji.yaginuma2018-12-091-1/+17
| | | | |
* | | | | Do not require `webpacker` in Active Job integration testsyuuji.yaginuma2018-12-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because `skip-javascript` option is specified for the dummy application used in the integration tests. https://github.com/rails/rails/blob/bdc96802a7a4a8c6d183272e997430e8b9006498/activejob/test/support/integration/helper.rb#L14
* | | | | Merge pull request #34632 from rails/rename-write-on-read-errorEileen M. Uchitelle2018-12-078-17/+21
|\ \ \ \ \ | | | | | | | | | | | | Rename error that occurs when writing on a read
| * | | | | Rename error that occurs when writing on a readEileen Uchitelle2018-12-078-17/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I originally named this `StatementInvalid` because that's what we do in GitHub, but `@tenderlove` pointed out that this means apps can't test for or explitly rescue this error. `StatementInvalid` is pretty broad so I've renamed this to `ReadOnlyError`.
* | | | | | #create_or_find_by/!: add more tests and fix docs (#34653)Bogdan2018-12-082-2/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `#create_or_find_by/!`: add more tests * Fix docs of `create_or_find_by` This method uses `find_by!` internally.
* | | | | | Merge pull request #34654 from rantler/fix_small_typo_in_upgrade_docsVipul A M2018-12-081-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix typo in per-form CSRF token docs [ci skip]
| * | | | | | Fix typo in per-form CSRF token docs [ci skip]Randy Antler2018-12-071-1/+1
|/ / / / / /
* | | | | | Merge pull request #34643 from albertoalmagro/move-type-method-to-symbolRyuta Kamizono2018-12-071-6/+7
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Move type method inside ActionDispatch::Journey::Nodes::Symbol
| * | | | | Expand metaprogramming for Symbol, Slash and Dot.Alberto Almagro2018-12-071-6/+7
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This first started with moving type method inside `ActionDispatch::Journey::Nodes::Symbol`. `AD::Journey::Nodes::Symbol#type` was generated dynamically with an `each` block. While this is OK for classes like `AD::Journey::Nodes::Slash` or `AD::Journey::Nodes::Dot` which don't have further implementation, all other classes containing more logic have this method defined in their class body. This patch does the same in this case. On code review process @kamipo suggested to fully expand over metaprogramming for Slash and Dot classes, a topic on which I agree with him.
* / | | | Abort early if generator command fails (#34420)David Rodríguez2018-12-076-6/+33
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * No need to go through ruby * Abort early if a generator command fails * Reuse `rails_command` method * Bump thor minimum dependency to 0.20.3 * Add some minimal docs * Add a changelog entry * Restore original logging
* | | | Merge pull request #34573 from WoH/firefox-right-click-bugRafael França2018-12-057-6/+100
|\ \ \ \ | |/ / / |/| | | Prevent non-primary mouse button clicks from triggering click events
| * | | Prevent unintended mouse keys from firing click eventsWoH2018-12-057-6/+100
| | | | | | | | | | | | | | | | | | | | Firefox fires click events on left-, right- and scroll-wheel (any non-primary mouse key) clicks while other browsers don't.
* | | | Merge pull request #34194 from staugaard/staugaard/actioncable_unauthorizedRafael França2018-12-059-10/+46
|\ \ \ \ | | | | | | | | | | Stop trying to reconnect on unauthorized cable connections
| * | | | Stop trying to reconnect on unauthorized cable connectionsMick Staugaard2018-12-059-10/+46
| | | | |
* | | | | Improve deprecation message for enqueue returning falseRafael Mendonça França2018-12-055-1/+49
|/ / / / | | | | | | | | | | | | | | | | | | | | And make sure new applications in Rails 6.0 has this config enabled. Also, improve test coverage and add a CHANGELOG entry.
* | | | Merge pull request #34626 from gmcgibbon/sqlite_pluck_quotingRyuta Kamizono2018-12-063-0/+12
|\ \ \ \ | | | | | | | | | | Fix join table column quoting with SQLite.
| * | | | Fix join table column quoting with SQLite.Gannon McGibbon2018-12-053-0/+12
| | | | |
* | | | | Merge pull request #33992 from kirs/enqueue-return-falseRafael França2018-12-055-1/+56
|\ \ \ \ \ | | | | | | | | | | | | Make AJ::Base#enqueue return false if the job wasn't enqueued
| * | | | | Make AJ::Base#enqueue return false if the job wasn't enqueuedKir Shatrov2018-10-285-1/+56
| | | | | |
* | | | | | Merge pull request #34621 from colby-swandale/update-bundler-2Rafael França2018-12-051-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Update bundler to 2.0.0.pre.2
| * | | | | update bundler to 2.0.0.pre.2Colby Swandale2018-12-051-1/+1
| | | | | |
* | | | | | Merge pull request #34591 from gmcgibbon/new_delivery_jobEileen M. Uchitelle2018-12-0512-23/+179
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add MailDeliveryJob for unified mail delivery
| * | | | | | Add MailDeliveryJob for unified mail deliveryGannon McGibbon2018-12-0412-23/+179
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `MailDeliveryJob` for delivering both regular and parameterized mail. Deprecate using `DeliveryJob` and `Parameterized::DeliveryJob`.
* | | | | | | Fix unstable ↵yuuji.yaginuma2018-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_serialized_attribute_works_under_concurrent_initial_access` test Since bd62389307e138ee0f274a9d62697567a3334ea0, isolate test of `test_serialized_attribute_works_under_concurrent_initial_access` fails. ``` $ ./bin/test -w test/cases/serialized_attribute_test.rb -n test_serialized_attribute_works_under_concurrent_initial_access Using sqlite3 Run options: -n test_serialized_attribute_works_under_concurrent_initial_access --seed 32129 # Running: E Error: SerializedAttributeTest#test_serialized_attribute_works_under_concurrent_initial_access: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such table: ``` If duplicate an unloaded model, it seems that method invocation for that class is not guaranteed. Use the original class to avoid it.
* | | | | | | Merge pull request #34620 from ↵Yuji Yaginuma2018-12-052-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ysksn/use_safe_navigation_operator_for_railsguides_generator_constructor Use String for direction of RailsGuides::Generator#new
| * | | | | | | Use safe nav operator when calling RailsGuides::Generator.newYosuke Kabuto2018-12-052-3/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Use String for direction of RailsGuides::Generator
* | | | | | | Merge pull request #34617 from blahed/colorize-unpermitted-paramsRafael França2018-12-041-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Colorize the unpermitted params log message
| * | | | | | | colorize the unpermitted params log messageblahed2018-12-031-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #34563 from sambostock/improve-test-helper-guidesGannon McGibbon2018-12-041-0/+50
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Add advanced test helpers docs to guides
| * | | | | | | Add advanced test helpers docs to guidesSam Bostock2018-12-041-0/+50
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Merge pull request #34612 from ↵Rafael França2018-12-041-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | utilum/bigdecimal_raises_on_comma_in_string_argument Another Ruby 2.6 BigDecimal compatibility issue
| * | | | | | | Another Ruby 2.6 BigDecimal compatibility issueutilum2018-12-041-1/+1
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch modifies XmlMini::Parsing["decimal"] to handle a string that contains an invalid number. Since [ruby/ruby@a0e438c#diff-6b866d482baf2bdfd8433893fb1f6d36R144](https://github.com/ruby/ruby/commit/a0e438cd3c28d2eaf4efa18243d5b6edafa14d88#diff-6b866d482baf2bdfd8433893fb1f6d36R144) this case raises an `ArgumentError`. `String.to_f` returns 0.0 if there is not a valid number at the start of the argument, so current behavior is conserved. See https://travis-ci.org/rails/rails/jobs/463180341#L6264 Related: #34600, #34601
* | | | | | | Merge pull request #34560 from gmcgibbon/fix_decorate_leak_on_serial_attr_testRafael França2018-12-041-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix attribute decoration leak on serialized attribute test
| * | | | | | | Fix attribute decoration leak on serialized attribute testGannon McGibbon2018-11-291-0/+4
| | | | | | | |
* | | | | | | | Merge pull request #34616 from gmcgibbon/route_symbol_noteRafael França2018-12-041-0/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add note about symbols vs strings
| * | | | | | | | Add note about symbols vs stringsGannon McGibbon2018-12-041-0/+2
| | | | | | | | |
* | | | | | | | | Fix announcement draft formatting [ci skip]Rafael Mendonça França2018-12-041-2/+2
| | | | | | | | |
* | | | | | | | | Add release link to the announcement [ci skip]Rafael Mendonça França2018-12-041-3/+7
| | | | | | | | |
* | | | | | | | | Improve the task to generate the release summaryRafael Mendonça França2018-12-041-5/+10
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now it accepts the base release to be compared with. [ci skip]
* | | | | | | | Merge pull request #34605 from alfie-max/disable_enum_scopesRafael França2018-12-043-2/+18
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | option to disable all scopes that `ActiveRecord.enum` generates
| * | | | | | | option to disable scopes that `ActiveRecord.enum` generates by defaultAlfred Dominic2018-12-043-2/+18
|/ / / / / / /
* | | | | | | Merge pull request #34609 from kamipo/delete_all_on_collection_proxyRyuta Kamizono2018-12-045-6/+23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Ensure that `delete_all` on collection proxy returns affected count
| * | | | | | | Ensure that `delete_all` on collection proxy returns affected countRyuta Kamizono2018-12-045-6/+23
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike the `Relation#delete_all`, `delete_all` on collection proxy doesn't return affected count. Since the `CollectionProxy` is a subclass of the `Relation`, this inconsistency is probably not intended, so it should return the count consistently.
* | | | | | | Merge pull request #34607 from gmcgibbon/clear_scope_on_deleteRyuta Kamizono2018-12-044-4/+72
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Reset scope after collection delete
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 03:16:18 +0000