aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused fixturesRafael Mendonça França2014-07-1660-98/+0
| | | | These fixtures are not used in actionpack tests.
* nodoc enum hooks [ci skip]Rafael Mendonça França2014-07-161-2/+2
|
* Don't accept parameters as argument for redirect to [via @homakov]Santiago Pastorino2014-07-162-0/+11
| | | | Closes #16170
* we intend to keep the `capture` helper for Active Record tests.Yves Senn2014-07-161-18/+12
| | | | This is a follow up to f8f5cdc
* Active Record tests still depend on `capture`. Let's keep it for now.Yves Senn2014-07-162-19/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow-up to 3121412 /cc @rafaelfranca This will remove deprecation warnings from the PostgreSQL suite: ``` DEPRECATION WARNING: #capture(stream) is deprecated and will be removed in the next release. (called from capture at /Users/senny/Projects/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:89) /Users/senny/Projects/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:89:in `capture' /Users/senny/Projects/rails/activerecord/test/cases/adapters/postgresql/composite_test.rb:73:in `ensure_warning_is_issued' /Users/senny/Projects/rails/activerecord/test/cases/adapters/postgresql/composite_test.rb:48:in `test_column' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:106:in `block (3 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:204:in `capture_exceptions' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:103:in `block (2 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:256:in `time_it' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:102:in `block in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:317:in `on_signal' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:276:in `with_info_handler' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:101:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:759:in `run_one_method' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:293:in `run_one_method' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:287:in `block (2 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:286:in `each' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:286:in `block in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:317:in `on_signal' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:306:in `with_info_handler' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:285:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `block in __run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `map' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `__run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:126:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:55:in `block in autorun' ```
* Merge pull request #16187 from jone/testing-guide-assertionsYves Senn2014-07-161-2/+13
|\ | | | | Update assertion methods in testing guide [ci skip]
| * link minitest assertions documentation.Jonas Baumann2014-07-161-2/+7
| |
| * document assert[_not]_empty, assert[_not]_includes, assert[_not]_predicate ↵Jonas Baumann2014-07-161-0/+6
|/ | | | in testing guide.
* use foreign key DSL in our tests.Yves Senn2014-07-162-5/+4
|
* Merge pull request #16138 from sgrif/sg-attribute-set-keyYves Senn2014-07-163-10/+10
|\ | | | | AttributeSet#include? -> AttributeSet#key?
| * AttributeSet#include? -> AttributeSet#key?Sean Griffin2014-07-113-10/+10
| | | | | | | | https://github.com/rails/rails/pull/15868/files#r14135210
* | Fix 1.9. uggghhhhhh get it together @tenderlove :bomb:Aaron Patterson2014-07-151-2/+2
| |
* | fix for 1.9 kwargs syntaxAaron Patterson2014-07-151-1/+2
| |
* | routed applications will respond to these methodsAaron Patterson2014-07-152-2/+2
| |
* | Merge branch 'rm-uuid'Rafael Mendonça França2014-07-156-78/+78
|\ \
| * | Move uuid_v5 and uuid_v3 to Digest::UUIDRafael Mendonça França2014-07-156-78/+78
| | | | | | | | | | | | | | | These methods are not random so they should not belings to SecureRandom module.
* | | stop passing recall to url_forAaron Patterson2014-07-152-37/+48
| | |
* | | rack 1.6 encodes the filenames in posts correctly nowAaron Patterson2014-07-151-8/+1
| | |
* | | fix warningsAaron Patterson2014-07-151-1/+1
| | |
* | | stop calling url_for with recall parameters and actually use a requestAaron Patterson2014-07-152-85/+197
|/ /
* | execute a request and check the path_parametersAaron Patterson2014-07-151-17/+59
| | | | | | | | | | | | | | | | This actually runs a request through the system, using the actual routing methods as we would use in production, then tests the path_parameters set on the request object. The `recognize_path` method isn't actually used in production, so testing what it returns isn't useful.
* | set `set` in the setup methodAaron Patterson2014-07-151-2/+5
| |
* | remove useless ivar setAaron Patterson2014-07-151-1/+0
| |
* | RouteSet should be in charge of constructing the dispatherAaron Patterson2014-07-153-10/+15
| | | | | | | | Now we can override how requests are dispatched in the routeset object
* | Merge pull request #16180 from rafaelfranca/rm-dirtyRafael Mendonça França2014-07-156-18/+79
|\ \ | | | | | | Improve Active Model Dirty API.
| * | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.Rafael Mendonça França2014-07-155-13/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods.
| * | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵Rafael Mendonça França2014-07-154-6/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes.
* | | Add CHANGELOG entry for #13392 [ci skip]Rafael Mendonça França2014-07-151-0/+7
| | |
* | | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-1510-21/+140
| | |
* | | Deprecate reporting methods for silencing output as they aren't thread safeTom Meier2014-07-151-0/+10
| | |
* | | Merge pull request #16129 from rafaelfranca/config_forRafael Mendonça França2014-07-153-0/+134
|\ \ \ | | | | | | | | Add Rails::Application#config_for
| * | | Add Rails::Application#config_forRafael Mendonça França2014-07-153-0/+134
| |/ / | | | | | | | | | | | | This is a convenience for loading configuration for the current Rails environment.
* | | Merge branch 'master' of git://github.com/rails/railsGodfrey Chan2014-07-154-6/+24
|\| | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md
| * | Merge branch 'jbrowning-fix_mariadb_rename_index'Rafael Mendonça França2014-07-154-6/+24
| |\ \ | | | | | | | | | | | | Closes #15936
| | * | Predicate methods don't need to return `true` / `false`Rafael Mendonça França2014-07-151-1/+1
| | | |
| | * | Fix version detection for RENAME INDEX support. Fixes #15931.Jeff Browning2014-07-154-6/+24
| | | |
* | | | Document the change in `nil` handling for serialized attributesGodfrey Chan2014-07-152-9/+17
| | | | | | | | | | | | | | | | Also updated the test case to reflect that
* | | | Fixed SQL syntax for postgresqlGodfrey Chan2014-07-151-1/+1
| | | |
* | | | Merge pull request #16162 from chancancode/fix_json_coderGodfrey Chan2014-07-152-1/+19
| | | | | | | | | | | | | | | | Fixed JSON coder when loading NULL from DB
* | | | Revert "Revert "Merge pull request #16059 from jenncoop/json-serialized-attr""Godfrey Chan2014-07-155-2/+76
|/ / / | | | | | | | | | | | | | | | | | | This reverts commit 6f3c64eeb1dc8288dae49f114aaf619adc7dcb7f. Conflicts: activerecord/CHANGELOG.md
* / / Add CHANGELOG entry for #15266Godfrey Chan2014-07-151-0/+5
|/ /
* | Merge pull request #15266 from dv/use_counter_cache_for_empty_callGodfrey Chan2014-07-152-0/+15
|\ \ | | | | | | If a counter_cache exists, use it for #empty?
| * | If a counter_cache exists, use it for #empty?David Verhasselt2014-06-102-0/+15
| | |
* | | Merge pull request #16142 from andreychernih/extend-server-optionsRafael Mendonça França2014-07-151-7/+11
|\ \ \ | | | | | | | | Add ability to extend `rails server` command options parser
| * | | Add ability to extend `rails server` command options parserAndrey Chernih2014-07-111-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this change it will be possible to add additional options to the `option_parser` like this: require 'rails/commands/server' module Rails class Server < ::Rack::Server class Options def option_parser_with_open(options) parser = option_parser_without_open options parser.on('-o', '--open', 'Open in default browser') { options[:open] = true } parser end alias_method_chain :option_parser, :open end def start_with_open start_without_open do `open http://localhost:3000` if options[:open] end end alias_method_chain :start, :open end end
* | | | Merge pull request #16175 from skorks/log_digestor_as_debugRafael Mendonça França2014-07-151-1/+1
|\ \ \ \ | | | | | | | | | | Log digest as :debug instead of :info
| * | | | Log digest as :debug instead of :infoAlan Skorkin2014-07-151-1/+1
| | | | |
* | | | | Merge pull request #16161 from jpawlyn/masterAndrew White2014-07-153-1/+14
|\ \ \ \ \ | | | | | | | | | | | | Fix empty host for an asset url when asset_host proc returns nil
| * | | | | Return an absolute instead of relative path from an asset url in the case of ↵Jolyon Pawlyn2014-07-153-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | the `asset_host` proc returning nil
* | | | | | Merge pull request #16174 from tgxworld/doc_fixZachary Scott2014-07-141-2/+2
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | [ci skip] Fix grammar of eager loading for ActiveRecord::Associations
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-08 12:37:26 +0000