aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* adding a method to handle strings using the same apiAaron Patterson2014-05-121-22/+32
|
* fix url_for with classesAaron Patterson2014-05-121-1/+1
|
* break each polymorphic type to it's own methodAaron Patterson2014-05-122-25/+86
|
* remove dead codeAaron Patterson2014-05-121-12/+0
|
* only test `persisted?` on the record onceAaron Patterson2014-05-121-3/+7
| | | | | also avoid the case of calling `persisted?` on something that doesn't respond to it
* only send options if there are any optionsAaron Patterson2014-05-121-5/+7
|
* add a test for the parameters sent to the url helper for new recordsAaron Patterson2014-05-121-0/+15
|
* remove should_pop variableAaron Patterson2014-05-121-4/+1
|
* only pop records when we get an arrayAaron Patterson2014-05-121-6/+7
|
* remove unnecessary array allocationsCoraline Ada Ehmke + Aaron Patterson2014-05-121-5/+1
|
* simplified route method name generationCoraline Ada Ehmke + Aaron Patterson2014-05-122-27/+19
|
* small refactoringCoraline Ada Ehmke + Aaron Patterson2014-05-121-6/+2
|
* pulling helpermethods up before refactoringCoraline Ada Ehmke + Aaron Patterson2014-05-121-20/+46
|
* push all is_a tests up, always pass options to the named routeAaron Patterson2014-05-121-28/+27
|
* pull nil checks upAaron Patterson2014-05-121-3/+5
|
* skip another Array is_a checkAaron Patterson2014-05-121-4/+6
|
* only do the Array is_a check onceAaron Patterson2014-05-121-4/+3
|
* we always convert this variable to a list, so we can remove the unconversionAaron Patterson2014-05-121-1/+0
|
* record as a hash is not possible, so rm branchAaron Patterson2014-05-121-2/+0
|
* stop popping in build_named_route_callAaron Patterson2014-05-121-4/+3
|
* remove extract_record since we have extracted the listAaron Patterson2014-05-121-12/+1
|
* always pass a list to build_named_route_callAaron Patterson2014-05-121-10/+19
|
* add a test with three objectsAaron Patterson2014-05-121-2/+13
|
* add a test for passing two models to the polymorphic_url methodAaron Patterson2014-05-122-1/+9
|
* typo: resulution -> resolution [ci skip]Godfrey Chan2014-05-121-1/+1
|
* reduce conditionals in url_forAaron Patterson2014-05-121-3/+6
|
* extract route key translation to a method and reuse itAaron Patterson2014-05-121-17/+14
|
* make the module version quack the same as the instanceAaron Patterson2014-05-121-3/+10
| | | | this way we can stop checking respond_to on every call.
* Hash#except is expensive and this is a hotspot, so use a dup + deleteAaron Patterson2014-05-121-1/+2
|
* test, use `columns_hash[]` in place of `columns.find {}`.Yves Senn2014-05-128-12/+12
|
* pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-124-3/+18
|
* pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-123-0/+33
| | | | Closes #10802.
* Merge pull request #13334 from gregolsen/postgresql_infinityYves Senn2014-05-123-3/+30
|\ | | | | | | | | | | | | | | | | | | pg, fix Infinity and NaN values conversion. Closes #13334. * rebased * removed guard * inlined guard into case statement
| * pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-123-3/+30
|/ | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* Merge pull request #10505 from patricksrobertson/bigserial_id_not_identifying_pkYves Senn2014-05-123-1/+33
|\ | | | | | | | | | | | | | | | | Handle other pk types in PostgreSQL gracefully. Closes #10505. - rebased - test slightly modified
| * Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-123-1/+33
|/ | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* Merge pull request #14999 from yahonda/modify_bind_variable_nameYves Senn2014-05-121-2/+3
|\ | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999.
| * Modify assert conditions not to be affectedYasuo Honda2014-05-121-2/+3
| | | | | | | | by each database bind variable naming conventions
* | Merge pull request #15060 from tgxworld/remove_unnecessary_tests_methodRafael Mendonça França2014-05-121-2/+0
|\ \ | | | | | | Remove redundant tests method.
| * | Remove redundant tests method.Guo Xiang Tan2014-05-111-2/+0
| | |
* | | Update attribute_methods.rbGuillermo Iguaran2014-05-111-1/+1
| | | | | | | | | Improve documentation
* | | Merge pull request #15063 from cbeer/correct-attribute_present-docsGuillermo Iguaran2014-05-111-7/+7
|\ \ \ | |/ / |/| | correcting method documentation [ci skip]
| * | correcting method documentation [ci skip]Chris Beer2014-05-111-7/+7
| | |
* | | Merge pull request #10662 from ↵Carlos Antonio da Silva2014-05-111-9/+9
|\ \ \ | | | | | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb
| * | | Refactor AR's validations_test.rbTakehiro Adachi2013-12-031-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code
* | | | Merge pull request #15059 from marcioj/patch-1Robin Dupret2014-05-111-2/+2
|\ \ \ \ | | | | | | | | | | Replace :base with :in [ci skip]
| * | | | Replace :base with :in [ci skip]Marcio Junior2014-05-111-2/+2
|/ / / /
* | | | Tidy up implementation of #15010Andrew White2014-05-112-11/+7
| | | |
* | | | Make TimeZone#parse behave more like Time#parse.Ulysse Carion2014-05-113-1/+25
| | | | | | | | | | | | | | | | | | | | Namely, if the mday is omitted but any other upper components are, then instead of supplying the mday from the current time, it defaults to 1.
* | | | docs, make `ActionNotFound` public API. [ci skip]Yves Senn2014-05-111-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 18:05:45 +0000