| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Get an incorrect cookie value in controller action method
if cookie value contains an escapable string.
|
|\
| |
| | |
Fix - `to_s(:db)` in numeric range
|
|/ |
|
|\
| |
| | |
Add test coverage for ActiveSupport::NumericWithFormat#to_formatted_s
|
| | |
|
|\ \
| | |
| | | |
Add a missing require to ActiveSupport::NumericWithFormat
|
| |/ |
|
|\ \
| | |
| | |
| | | |
Fix #first(limit) to take advantage of #loaded? records if available
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I realized that `first(2)`, etc. was unnecessarily querying for the
records when they were already preloaded. This was because
`find_nth_with_limit` can not know which `@records` to return because
it conflates the `offset` and `index` into a single variable, while
the `@records` only needs the `index` itself to select the proper
record.
Because `find_nth` and `find_nth_with_limit` are public methods, I
instead introduced a private method `find_nth_with_limit_and_offset`
which is called internally and handles the `loaded?` checking.
Once the `offset` argument is removed from `find_nth`,
`find_nth_with_limit_and_offset` can be collapsed into
`find_nth_with_limit`, with `offset` always equal to `offset_index`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
All uses of the `offset` are passing `offset_index`. Better to push
down the `offset` consideration into `find_nth`.
This also works toward enabling `find_nth_with_limit` to take
advantage of the `loaded?` state of the relation.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This resolves the following error:
```
Error:
TestAdapterWithInvalidConnection#test_inspect_on_Model_class_does_not_raise:
TypeError: superclass mismatch for class Mysql2Adapter
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb:35:in `<module:ConnectionAdapters>'
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb:34:in `<module:ActiveRecord>'
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb:6:in `<top (required)>'
/Users/senny/Projects/rails/activesupport/lib/active_support/dependencies.rb:302:in `require'
/Users/senny/Projects/rails/activesupport/lib/active_support/dependencies.rb:302:in `block in require'
/Users/senny/Projects/rails/activesupport/lib/active_support/dependencies.rb:268:in `load_dependency'
/Users/senny/Projects/rails/activesupport/lib/active_support/dependencies.rb:302:in `require'
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_adapters/connection_specification.rb:174:in `spec'
/Users/senny/Projects/rails/activerecord/lib/active_record/connection_handling.rb:50:in `establish_connection'
/Users/senny/Projects/rails/activerecord/test/cases/invalid_connection_test.rb:12:in `setup'
```
|
|\ \ \
| | | |
| | | | |
Removed extra "the" in the documentation of `broadcast_message` [ci skip]
|
|/ / / |
|
| | |
| | |
| | | |
It's numeric and the framework is called Action Controller.
|
|\ \ \
| | | |
| | | | |
Document `Logger#broadcast_messages` option
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
CHANGELOG entry for petabyte and exabyte
|
|\ \ \ \
| | | | |
| | | | | |
Add support for Petabyte and Exabyte in number to human size
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix link to pr [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ActionCable] remove not needed protected call and newlines
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add Ruby 2.3.0 to Travis matrix
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Changed default value of `:rc` option to `nil`
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- This fixes an error thrown by Thor because type of default value of
`:rc` option which is `:boolean` does not match with it's default type
which is `string`.
- Ref - https://github.com/erikhuda/thor/blob/master/lib/thor/parser/option.rb#L125
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix varbinary with default ''
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
A `(?:var)?binary` with default '' is a correct definition.
Remove `missing_default_forged_as_empty_string?` method for fixing this
issue because this method is a workaround for older mysql legacy adapter
(19c99ac, f7015336).
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Improve documentation for `config.ssl_options`
|
| | | | | | |
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
:scissors: whitespace in generated config files [skip ci]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
fix TypeError when using submit_tag with Symbol value
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix typo on documentation
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Plugin Usage and Installation instructions
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Didn't like the constant being at the top of the file, gave it overdue importance.
Now that `color_output` expects a result we can shorten some of the flexibility
from earlier:
* Inline COLOR_CODES constant (keep local variable for readability,
but don't need names of colors at run time).
* Inline color variable in `color_output`. Looks just as clear without it.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Focus `color_output`'s intent on coloring output by a result. We aren't meant
to pass it arbitrary codes to color output.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The word color is being thrown all around with slightly different meanings.
Right now, I understand it. But I'd like to be more immediately clear.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I got the blues because we aren't coloring any lines blue.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The static red color wouldn't paint skips in their designated yellow.
Use the color name we got from the result label earlier, which marks
skips as yellow.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I should have replaced the summary reporter with a subclass
the first time I wrote this.
For whatever reason, I didn't. Do it right and slim the methods added
to Minitest in the process.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Minitest by default includes a summary reporter and a progress reporter.
To print colored output, we have to replace the progress reporter.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add colored output to the new test reporter.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Improve readability of CacheHelper section
|