| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The prior logic explictly set `Cache-Control` to `nil`. But, we would only
reach that logic if the header was not set to begin with. So, rather than give
it any value at all, just leave it alone.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The prior logic was trying to do too many things at once. For all responses,
we want to perform two distinct steps:
* Merge/normalize the `Cache-Control` values found in HTTP headers and those
found in the `@cache_control` hash.
* Conditionally set a default `Cache-Control` header value when we have an ETag
This change separates these concerns since the merge/normalize step should
occur for all responses, but the second should only occur when we have already
set an ETag/last modified value. Normally ETag middleware will set a default
`Cache-Control`, but only if an existing ETag is not already set. So, in the
cases where an ETag is set, we need to set the default `Cache-Control` value
ourselves.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In the existing logic, the `Cache-Control` header may or may not get
normalized by additional logic depending on whether `response.cache_conrol`
has been modified. This leads to inconsistent behavior, since sometimes
`Cache-Control` can contain whatever a user sets and sometimes it gets
normalized, based on the logic inside of `set_conditional_cache_control!`. It
seems like this normalization process should happen regardless to ensure
consistent behavior.
|
|\
| |
| | |
Fixing nginx configuration added missing semicolon [ci skip]
|
|/ |
|
|\
| |
| | |
Use 5.2 version of ActiveRecord::Migration for Active Storage
|
|/ |
|
|\
| |
| |
| |
| | |
bogdanvlviv/remove-frozen_string_literal-from-blob-migration
Remove frozen_string_literal comment from activestorage's migration
|
| |
| |
| |
| |
| | |
The activestorage's migration is used as template for apps
Related to #30348
|
|\ \
| | |
| | | |
Automatically guess the inverse associations for STI
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ActiveRecord associations automatically guess the inverse associations.
But this feature does not work correctly on assoctions for STI.
For example, before this commit
```
class Post < ActiveRecord::Base
belongs_to :author
end
class SpecialPost < Post; end
class Author < ActiveRecord::Base
has_many :posts
has_many :special_posts
end
```
`author.posts.first.author` works correctly, but
`author.special_posts.first.author` does not work correctly.
|
|\ \
| | |
| | | |
missing backquotes [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
[actionpack] Update links to use https link instead of http [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
yhirano55/use_https_instead_of_http_in_activerecord
[activerecord] Update links to use https instead of http [ci skip]
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Remove frozen_string_literal magic comment from templates
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
yhirano55/use_https_instead_of_http_in_activesupport
[activesupport] Update links to use https instead of http [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Update MIT licenses link [ci skip]
|
| | |/ /
| |/| | |
|
| | | | |
|
| |_|/
|/| |
| | |
| | | |
Closes #30134.
|
|\ \ \
| | | |
| | | | |
Update debugging rails applications guide [ci skip]
|
|/ / / |
|
|\ \ \
| |_|/
|/| | |
[ci skip] form_with in the getting started guide.
|
| | |
| | |
| | |
| | | |
Add back a bit about a resource oriented style of routing.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
yhirano55/fix_broken_link_to_mysql_docs_in_database_yml
Fix broken link to mysql docs in database.yml [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Fix link in Contributing Ruby on Rails guide [ci skip]
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
* Add Contributing to the Rails Code link.
* Wiki link for Spanish is redirect.
* The base branch of Polish repo is master. And Turkish is, too.
* Unified expression `rails-dev-box`
* The Clone url is wrong.
* The mailing list url is old.
|
|\ \
| | |
| | | |
Update Contributing to Ruby on Rails guide [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Update generator guide [ci skip]
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`SET time zone 'value'` is an alias for `SET timezone TO 'value'`.
https://www.postgresql.org/docs/current/static/sql-set.html
So if `variables["timezone"]` is specified, it is enough to
`SET timezone` once.
|
|\ \ \
| |/ /
|/| | |
Update Rails on Rack guide [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Make `restart` and `dev:cache` tasks work when customizing pid file path
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Originally, it hard-coded pid file path. It can not be removed when customizing
pid file path.
But rake task can not get pid file path. Therefore, do not remove file in rake
task, makes it possible to judge whether it is restart from the argument of the
command and removes the file in server command.
Fixes #29306
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
yhirano55/update_autoloading_and_reloading_constants
Update Autoloading and Reloading Constants guide [ci skip]
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
| | | |
|
| | | |
|