aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #21240 from piton4eg/patch-5Claudio B.2015-08-141-10/+10
|\ \ | | | | | | Small fixes [ci skip]
| * | Small fixes [ci skip]Alexey Markov2015-08-151-10/+10
| | |
* | | rm add_route2Aaron Patterson2015-08-144-49/+53
| | | | | | | | | | | | | | | refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router
* | | pass pass the mapping object down the add_route stackAaron Patterson2015-08-144-56/+73
| | | | | | | | | | | | | | | then we can let the mapping object derive stuff that the Route object needs.
* | | pass the mapping object to build_routeAaron Patterson2015-08-143-26/+15
| | | | | | | | | | | | | | | now that we aren't doing options manipulations, we can just pass the mapping object down and read values from it.
* | | remove `process_path`Aaron Patterson2015-08-141-6/+2
|/ / | | | | | | | | since we've extracted the `to` initialization, there's no need for `process_path`
* | explicitly return nil from `get_to_from_path`Aaron Patterson2015-08-141-3/+3
| | | | | | | | | | | | if `to` was initialized, this method would return, so we can eliminate the to ||= in the conditional. Finally, let's return a nil in the else block so that it's explicit that this method can return nil
* | extract method on determining :to from the pathAaron Patterson2015-08-141-5/+9
| | | | | | | | Eventually we'll pull this up and delete `process_path`.
* | deprecate passing a string for both the beginning path and :path optionAaron Patterson2015-08-142-2/+20
| |
* | rm path_params methodAaron Patterson2015-08-141-5/+1
| | | | | | | | | | | | We don't need a method for something like this. I want to pull this up the stack as well and move the module + :controller ArgumentError up the stack as well
* | extract method on wildcard path parameter handlingAaron Patterson2015-08-141-6/+11
| |
* | pass the path ast downAaron Patterson2015-08-143-6/+4
| | | | | | | | | | now we don't need to add it to a hash and delete it from the hash later just to pass it around
* | pull up path parsingAaron Patterson2015-08-143-11/+12
| | | | | | | | | | `add_route` needs the AST, so rather than shove it in a hash and delete later, lets move parsing up the stack so we can pass down later
* | use predicate methods instead of hard coding verb stringsAaron Patterson2015-08-143-7/+7
| | | | | | | | | | also change the feeler to subclass AD::Request so that it has all the methods that Request has
* | remove hard coded regular expressionAaron Patterson2015-08-142-1/+5
| |
* | implement `requirements` in terms of routesAaron Patterson2015-08-141-1/+1
| |
* | implement the `asts` method in terms of paths / patternsAaron Patterson2015-08-141-12/+11
| | | | | | | | Eventually I want to eliminate the FakeSet test class
* | extract ast finding to a methodAaron Patterson2015-08-141-9/+13
| | | | | | | | | | I'm going to reimplement this using route objects, so it will be easier if we just change ast access to go through a method rather than hashes
* | stop adding path_info to the conditions hashAaron Patterson2015-08-143-11/+9
| | | | | | | | we don't need to keep adding it and deleting if from hashes.
* | pull up path normalization.Aaron Patterson2015-08-141-18/+18
| | | | | | | | | | Eventually I want to pull up AST generation so that we don't have to add it to the `conditions` hash.
* | Merge pull request #20647 from twalpole/method_source_dependencyRafael Mendonça França2015-08-142-0/+2
|\ \ | | | | | | Add method_source dependency to activesupport
| * | Add method_source dependency to activesupportThomas Walpole2015-07-292-0/+2
| | |
* | | Remove install.rbRafael Mendonça França2015-08-141-13/+0
| | | | | | | | | | | | We already have rake install command that does the same thing.
* | | Merge pull request #21234 from ↵Rafael Mendonça França2015-08-141-5/+2
|\ \ \ | | | | | | | | | | | | | | | | ixkaito/version_is_needless_when_running_installrb Remove `version` argument in install.rb
| * | | Remove `version` argument in install.rbKite2015-08-141-5/+2
| | | |
* | | | Merge pull request #21236 from jonatack/fix-middleware-deprecation-messagesKasper Timm Hansen2015-08-141-1/+1
|\ \ \ \ | |/ / / |/| | | Fix middleware deprecation message. Related to #21172.
| * | | Fix middleware deprecation message. Related to #21172.Jon Atack2015-08-141-1/+1
|/ / /
* | | Merge pull request #21225 from brooksreese/sql_is_made_up_of_statementsClaudio B.2015-08-131-1/+1
|\ \ \ | | | | | | | | [ci skip] SQL is written using statements, not sentences
| * | | [ci skip] SQL is written using statements, not sentencesBrooks Reese2015-08-131-1/+1
| | | |
* | | | `build_path` doesn't need the path variable anymoreAaron Patterson2015-08-131-2/+2
| | | | | | | | | | | | | | | | | | | | It just constructs a Path::Pattern object with the AST that it already has
* | | | remove StrexpAaron Patterson2015-08-138-115/+73
| | | | | | | | | | | | | | | | | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object.
* | | | pass anchor directly to `Pattern`Aaron Patterson2015-08-137-50/+47
| | | | | | | | | | | | | | | | | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away.
* | | | we already have access to the AST, so just use itAaron Patterson2015-08-131-3/+3
| | | |
* | | | remove default arguments that aren't usedAaron Patterson2015-08-131-1/+1
| | | | | | | | | | | | | | | | | | | | we always pass all parameters, so there is no reason to provide default arguments.
* | | | pull up options_constrants extractionAaron Patterson2015-08-132-17/+16
| | | |
* | | | remove `as`Aaron Patterson2015-08-132-9/+8
| | | | | | | | | | | | | | | | the caller already has access to `as`, so we can stop passing it around.
* | | | remove anchor from mappingAaron Patterson2015-08-132-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | the same value that is extracted from the options hash earlier is returned, so we don't need to pass it in in the first place. The caller already has the data, so stop passing it around.
* | | | pull `anchor` extraction upAaron Patterson2015-08-132-18/+17
| | | | | | | | | | | | | | | | | | | | this way we don't have to mutate the options hash so far away from where the user passed it in
* | | | Merge pull request #19683 from tristang/require-option-for-counter-cacheRafael Mendonça França2015-08-137-6/+56
|\ \ \ \ | | | | | | | | | | | | | | | Require explicit counter_cache option for has_many
| * | | | Add tests for associations without counter_cacheTristan Gamilis2015-04-094-0/+43
| | | | | | | | | | | | | | | | | | | | | | | | | Assert that counter_cache behaviour is not used on belongs_to or has_many associations if the option is not given explicitly.
| * | | | Require explicit counter_cache option for has_manyTristan Gamilis2015-04-073-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously has_many associations assumed a counter_cache was to be used based on the presence of an appropriately named column. This is inconsistent, since the inverse belongs_to association will not make this assumption. See issues #19042 #8446. This commit checks for the presence of the counter_cache key in the options of either the has_many or belongs_to association as well as ensuring that the *_count column is present.
* | | | | raise if `anchor` is passed to `scope`Aaron Patterson2015-08-132-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it is directly passed to `match`, so setting it in a scope must be a mistake.
* | | | | Merge pull request #19770 from vngrs/prevent_duplicated_where_clausesRafael Mendonça França2015-08-133-0/+14
|\ \ \ \ \ | |_|/ / / |/| | | | Prevent duplicating `where` clauses
| * | | | Prevent duplicating `where` clauses when model is extended from an abstract ↵Mehmet Emin İNAÇ2015-04-153-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | class Fixes #19528 fix for mysql2 test better test
* | | | | descriptive error message when fixtures contian a missing column.Yves Senn2015-08-134-2/+21
| | | | | | | | | | | | | | | | | | | | Closes #21201.
* | | | | Merge pull request #21120 from dhiachou/patch-1Robin Dupret2015-08-131-5/+12
|\ \ \ \ \ | | | | | | | | | | | | How to pass arguments to ActiveJob Jobs [ci skip]
| * | | | | [ci skip] How to pass arguments to ActiveJob JobsDhia Eddine Chouchane2015-08-131-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A section explaining how to pass arguments to Jobs has been added. [ci skip] How to pass arguments to ActiveJob Jobs Removed the "how to pass arguments" from what you will know section [ci skip] improving Enqueue Job section Using GuestsCleanupJob rather than MyJob for coherence. [ci skip] Passing args section merged with enqueuing jobs Passing args is now explained through examples withing Enqueuing the Jobs section [ci skip] Unnecessary example removed [ci skip] Typo fixed (missing as)
* | | | | | Merge pull request #21221 from alietz/doc-asset-pipeline-clarificationRobin Dupret2015-08-131-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Clarified asset pipeline guide
| * | | | | | [ci skip] Clarified asset pipeline guideAndreas Lietz2015-08-131-4/+4
|/ / / / / /
* | | | | | implement `provider_job_id` for `queue_classic`.Yves Senn2015-08-135-9/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The latest, currently unreleased, version of queue_classic is required for this to work. See https://github.com/QueueClassic/queue_classic/pull/262 for more details.
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-19 14:02:26 +0000