| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Make sure we clean preview_interceptors
|
| |
| |
| |
| | |
We should make sure we clean preview_interceptors after each test so they dont leaky to the next test
|
|\ \
| |/
|/| |
Add preventDefault() on click event
|
|/ |
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/4_1_release_notes.md
|
| |
| |
| |
| | |
Thank you @bquorning
|
| |
| |
| |
| |
| | |
[ci-skip]
Closes rails/rails#14294
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Based on comments at
https://github.com/rails/docrails/commit/42417b0013819e573be9ffc5402e179003156e8e#commitcomment-5527251
[skip ci]
|
| |
| |
| |
| | |
[skip ci]
|
| |
| |
| |
| | |
[skip ci]
|
| |
| |
| |
| | |
This commit also addresses rails/docrails#169 and rails/rails#14159
|
| |
| |
| | |
the fact that Rails is multi-thread by default is not very relevant. see https://github.com/rails/rails/pull/13998 [ci skip]
|
| | |
|
|\ \
| | |
| | | |
Add "Low-Level Caching" part to "Caching With Rails" guide
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
sikachu/master-revert-render-body-remove-content-type
Do note remove `Content-Type` when `render :body`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`render :body` should just not set the `Content-Type` header. By
removing the header, it breaks the compatibility with other parts.
After this commit, `render :body` will returns `text/html` content type,
sets by default from `ActionDispatch::Response`, and it will preserve
the overridden content type if you override it.
Fixes #14197, #14238
This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
joker1007/fix_rails_guides_about_active_record_default_timezone
Fix guide about `config.active_record.default_timezone` [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
Now the initial value of ActiveRecord.default_timezone is always :utc
|
|\ \ \ \
| |/ / /
|/| | | |
Introduce `Rails.gem_version`
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This method return `Gem::Version.new(Rails.version)`, suggesting a more
reliable way to perform version comparison.
Example:
Rails.version #=> "4.1.2"
Rails.gem_version #=> #<Gem::Version "4.1.2">
Rails.version > "4.1.10" #=> false
Rails.gem_version > Gem::Version.new("4.1.10") #=> true
Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true
This was originally introduced as `.version` by @charliesome in #8501
but got reverted in #10002 since it was not backward compatible.
Also, updating template for `rake update_versions`.
|
| | |
| | |
| | |
| | |
| | | |
This actually not an issue fixing ; the changelog is referring to the
introducing pull request itself.
|
| | |
| | |
| | |
| | | |
origin: https://github.com/rails/rails/commit/f6aeb8b1a3687c8523e4a56309fe3736011b2935#commitcomment-5569649
|
| | |
| | |
| | |
| | | |
This is a result of the discussion at https://github.com/rails/rails/pull/14263/files#r10291489
|
| | |
| | |
| | |
| | | |
This is a follow up to a668beffd64106a1e1fedb71cc25eaaa11baf0c1
|
| | | |
|
|\ \ \
| | | |
| | | | |
Follow up of #10732 - Allow string hash values on AR order method
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This behavior has almost no performance impact:
String not allowed 66.910000 0.030000 66.940000 ( 67.024976)
String allowed 69.360000 0.030000 69.390000 ( 69.503096)
Benchmarked with http://git.io/Y0YuRw.
|
|\ \ \ \
| | | | |
| | | | | |
Make exists? use bound values.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When we build a query with an inline value that is a numeric (e.g.
because it's out of range for an int4) PostgreSQL doesn't use an index
on the column, since it's now comparing numerics and not int4s.
This leads to a _very_ slow query.
When we use bound parameters instead of inline values PostgreSQL
raises numeric_value_out_of_range since no automatic coercion happens.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 475c96589ca65282e1a61350271c2f83f0d4044f, reversing
changes made to 705915ab5cf24430892107764b0050c07e1df583.
We decided that this is not worth busting everyone's cache as this
seems like a very unlikely problem. The problem only occurs when the
user is 1) not using a namespace, or 2) using the same namesapce for
different *kinds* of cache items. The recommended "fix" is to put
those cache items into their own namspace:
id = 1
Rails.cache.fetch(id, namespace: "user"){ User.find(id) }
ids = [1]
Rails.cache.fetch(ids, namespace: "users"){ User.find(ids) }
See the discussion on #14269 for details.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Cache key should be different when is Array.
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`cache.fetch(['foo'])` and `cache.fetch('foo')` should generate
different cache keys as they are not equivalents.
[related #8615]
[related #8614]
|
|\ \ \ \
| | | | |
| | | | | |
Variants in ActionView::Digestor
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Take variants into account when calculating template digests in
ActionView::Digest.
Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.
Fixes #14242
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
HAML and probably other generators extend this class and invoke
filename_with_extensions with the old signature (without format).
This makes the second argument optional and defaults it to the #format
method which could be overridden as well.
Closes #14132.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix enum test unused variable warning.
|
|/ / / /
| | | |
| | | |
| | | | |
Related - https://github.com/rails/rails/commit/5c55aafd38f45ac019573f98438ffdbdc8c580f9
|
|\ \ \ \
| | | | |
| | | | | |
Add Enum type to postgresql adapter's oids to prevent unknown OID warnings
|
| |/ / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There's no need to rely on Active Support's Hash#reverse_merge for
simple cases with default values, since we can just merge from the
default rather than reverse merge from the options.
This also avoids the creation of one extra hash object by moving to a
Hash#merge! call.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Fixes #14254 ActionView button_tag helper default options values issue.
|
| | | | |
|
| | | | |
|