aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | | | | | | Avoid postgres 9.X syntaxJon Leighton2011-12-031-1/+5
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Fix #3837.Jon Leighton2011-12-032-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access.
* | | | | | | | | | | | | | | removes the convenience instance version of AR::Base.silence_auto_explainXavier Noria2011-12-035-99/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled.
* | | | | | | | | | | | | | | Merge pull request #3820 from jaylevitt/nested_loading_through_assocJon Leighton2011-12-032-1/+36
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reintroduce patch from #726 to handle nested eager loading via associations
| * | | | | | | | | | | | | | | reintroduce patch from #726 to handle nested eager loading via associationsJay Levitt2011-11-302-1/+36
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Merge pull request #3833 from kennyj/fix_3678-3Jon Leighton2011-12-031-3/+8
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use show create table (fix 3678: third time).
| * | | | | | | | | | | | | | | | Use show create table.kennyj2011-12-031-3/+8
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | Merge pull request #3842 from arunagw/app_gen_testJosé Valim2011-12-031-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | App Generator test
| * | | | | | | | | | | | | | | | | Simplifying test in app/generatorArun Agrawal2011-12-031-3/+3
| | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Fix failing cascade exception.José Valim2011-12-033-2/+12
|/ / / / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | | | Restore performance of ERB::Util.html_escapeJon Jensen2011-12-032-7/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert html_escape to do a single gsub again, but add the "n" flag (no language, i.e. not multi-byte) to protect against XSS via invalid utf8 Signed-off-by: José Valim <jose.valim@gmail.com>
* | | | | | | | | | | | | | | | | fix a typo in query guideVijay Dev2011-12-031-1/+1
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | yield > block.callXavier Noria2011-12-021-3/+3
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | two small details from the previous patchXavier Noria2011-12-022-2/+2
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | implements AR::Base(.|#)silence_auto_explainXavier Noria2011-12-025-61/+142
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | fix typo in railties changelogVijay Dev2011-12-031-1/+1
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | revises Enumerable#pluck in AS guideVijay Dev2011-12-021-1/+1
| |_|/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-12-025-11/+14
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | Added doc about pluck for active_support core extArun Agrawal2011-12-021-0/+10
| | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | [Docs] Information about ActionDispatch::DebugExceptions in rake taskArun Agrawal2011-12-021-0/+1
| | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | Adding information about ActionDispatch::DebugExceptionsArun Agrawal2011-12-021-1/+1
| | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | [docs] removed last-modifed line from examplesRichard Hulse2011-12-021-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is no longer best-practice. ref: http://stackoverflow.com/questions/8344186/rails-3-1-on-apache-pagespeed-says-specify-cache-validator-when-using-asset-p/8348385#8348385
| * | | | | | | | | | | | | | | | fixed finger-dyslexia in active_support core extensions guideTim Sjoberg2011-12-011-1/+1
| | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | typo in the performance testing rails guideLeandro Santos2011-11-301-1/+1
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | rephrase doc on explain thresholdVijay Dev2011-12-021-1/+1
| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | Merge pull request #3832 from arunagw/indentationXavier Noria2011-12-021-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | indentation fix warning
| * | | | | | | | | | | | | | | | indentation fix warningArun Agrawal2011-12-021-1/+1
|/ / / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | | revises some details in the previous explain patchXavier Noria2011-12-023-4/+4
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Revert "Roflscaling!" (for now)Jon Leighton2011-12-022-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.)
* | | | | | | | | | | | | | | | implements automatic EXPLAIN logging for slow queriesXavier Noria2011-12-0218-96/+354
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH*David Heinemeier Hansson2011-12-023-3/+19
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Try to play nice with plugins doing monkey patches.José Valim2011-12-021-0/+5
| |_|_|_|/ / / / / / / / / / / |/| | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Fewer string allocations in attribute methodJon Leighton2011-12-011-4/+4
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Roflscaling!Jon Leighton2011-12-012-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster.
* | | | | | | | | | | | | | | Create method with known identifier then alias into place.Jon Leighton2011-12-012-25/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.)
* | | | | | | | | | | | | | | Remove some unnecessary code etcJon Leighton2011-12-012-26/+11
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Add test for read_attribute(:id) with non-standard PK.Jon Leighton2011-12-013-4/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go.
* | | | | | | | | | | | | | | Remove the need for type_cast_attribute.Jon Leighton2011-12-015-43/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is good because it reduces duplication.
* | | | | | | | | | | | | | | Fix up test altering global state that was causing me griefJon Leighton2011-12-011-2/+4
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Get rid of the underscore versions of attribute methods!Jon Leighton2011-12-016-6/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes me happy!
* | | | | | | | | | | | | | | Don't rely on underscore-prefixed attribute methods.Jon Leighton2011-12-013-48/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o
* | | | | | | | | | | | | | | Remove unnecessary *argsJon Leighton2011-12-011-2/+2
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Merge branch 'exceptions' with the following features:José Valim2011-12-0116-254/+406
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A Railtie API for registering new exceptions and their respective status code (check Active Record railtie for an example) * Extraction of ShowExceptions middleware logging and debugging features into a middleware called DebugExceptions Conflicts: actionpack/CHANGELOG.md
| * | | | | | | | | | | | | | | Remove unnecessary test setup.José Valim2011-12-011-6/+1
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Split and improve show and debug exceptions middlewares.José Valim2011-12-014-89/+145
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Split ShowExceptions responsibilities in two middlewares.José Valim2011-12-0110-95/+130
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Add a deprecation to old show exceptions API (even though it was not public).José Valim2011-12-011-0/+14
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Add an ExceptionWrapper that wraps an exception and provide convenience helpers.José Valim2011-12-015-77/+104
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Allow rescue responses to be configured through a railtie.José Valim2011-12-016-30/+55
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Revert "Added ActiveRecord::Base#last_modified to work with the new ↵David Heinemeier Hansson2011-12-014-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fresh_when/stale? conditional get methods from Action Pack" Needless indirection with no added value. This reverts commit 535853e83b9092078035a5abb2aa242fba815c05.
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-22 01:51:40 +0000