Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Swap branches | George Claghorn | 2017-07-15 | 1 | -3/+3 |
| | |||||
* | Merge pull request #48 from seanhandley/hosted_s3 | George Claghorn | 2017-07-15 | 1 | -2/+18 |
|\ | | | | | Allow custom endpoints for S3. | ||||
| * | Allow custom endpoints for S3. | Sean Handley | 2017-07-15 | 1 | -2/+18 |
| | | |||||
* | | Put conditional back | George Claghorn | 2017-07-14 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #55 from SGospodinov/logger-for-5.2.0 | George Claghorn | 2017-07-14 | 1 | -3/+3 |
|\ \ | | | | | | | Fixing logger to work with Rails 5.2.0.alpha | ||||
| * | | Fixing logger to work with Rails 5.2.0.alpha | Stanislav Gospodinov | 2017-07-15 | 1 | -3/+3 |
|/ / | |||||
* | | Depend on Rails >= 5.2.0.alpha | George Claghorn | 2017-07-14 | 3 | -35/+51 |
| | | |||||
* | | Merge pull request #53 from colorfulfool/error-messages | George Claghorn | 2017-07-14 | 2 | -2/+5 |
|\ \ | | | | | | | Useful error messages for two possible misconfigurations | ||||
| * | | Fail early if no storage service is specified | colorfulfool | 2017-07-15 | 1 | -0/+3 |
| | | | |||||
| * | | Don't fail on boot because of missing S3 keys when S3 is not used | colorfulfool | 2017-07-15 | 1 | -2/+2 |
| |/ | |||||
* | | Merge pull request #51 from dixpac/restore_intermediate_variables | George Claghorn | 2017-07-14 | 1 | -2/+8 |
|\ \ | |/ |/| | Revert back to the original implementaion with varaibles | ||||
| * | Revert back to the original implementaion with varaibles | dixpac | 2017-07-14 | 1 | -2/+8 |
|/ | | | | | | Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow. | ||||
* | Added rubocop / codeclimate config and fixed current offenses (#45) | Cristian Bica | 2017-07-14 | 18 | -33/+183 |
| | |||||
* | Fix regular expression on s3 test URL generation test (#44) | Dino Maric | 2017-07-13 | 1 | -5/+5 |
| | | | | | | | So tests are passing if the bucket name is rails-active storage. But developers specify their own s3 tests configuration (in my case was activestorage-test) then this regex fails. Also the first part is dynamic and based on bucket name and region | ||||
* | Merge pull request #43 from dixpac/small_gcs_service_refactoring | George Claghorn | 2017-07-13 | 1 | -8/+2 |
|\ | | | | | Remove unnecessary variables from gcs_service implementation | ||||
| * | Remove few ivars from gcs_service implementation | dixpac | 2017-07-13 | 1 | -8/+2 |
|/ | |||||
* | Merge pull request #42 from quartzmo/gcs-site-url | George Claghorn | 2017-07-12 | 3 | -6/+6 |
|\ | | | | | Update GCSService#url | ||||
| * | Update GCSService#url | Chris Smith | 2017-07-12 | 3 | -6/+6 |
| | | | | | | | | | | Update google-cloud-storage dependency to 1.3 Refactor arguments to Google::Cloud::Storage::File#signed_url | ||||
* | | Revert "S3: slim down service implementation (#40)" (#41) | David Heinemeier Hansson | 2017-07-12 | 1 | -24/+36 |
|/ | | | This reverts commit 6d3962461fb8d35fc9538d685fee96267663acf2. | ||||
* | S3: slim down service implementation (#40) | Jeremy Daer | 2017-07-11 | 1 | -36/+24 |
| | | | | | | | * Use simple core API for duck-type compat with other clients * initialize: accept an existing client * initialize: accept arbitrary client args instead of a fixed, required set * download: use native get_object streaming, no need to implement range requests * exists?: use head_object (which returns immediately) rather than waiting for existence | ||||
* | Revert "Depend on Rails > 5.1" | George Claghorn | 2017-07-11 | 1 | -4/+4 |
| | | | | This reverts commit 53d5384ac265ead44b25eec5f8f5020568184da2. | ||||
* | Depend on Rails > 5.1 | George Claghorn | 2017-07-11 | 1 | -4/+4 |
| | |||||
* | Expose chunked downloads | George Claghorn | 2017-07-10 | 3 | -6/+19 |
| | |||||
* | Scope aws-skd to version 2 (#34) | Dino Maric | 2017-07-10 | 2 | -2/+2 |
| | | | | | Since we use new aws-sdk API, I've scoped aws-sdk version so someone doesn't accidentaly installs wrong version during the development. | ||||
* | Configurator tests: work against test-local config | Jeremy Daer | 2017-07-09 | 1 | -3/+3 |
| | | | | | | So tests pass when service configs aren't set up. References #28 | ||||
* | Tests: Dir.mktmpdir neatly wraps up tmpdir + join | Jeremy Daer | 2017-07-09 | 3 | -6/+5 |
| | |||||
* | Add basic tests to the Configurator#build (#28) | Dino Maric | 2017-07-09 | 1 | -0/+15 |
| | |||||
* | Accept sgids for existing blobs created via direct upload as an attachable | David Heinemeier Hansson | 2017-07-09 | 2 | -0/+9 |
| | |||||
* | Direct uploads for S3 | David Heinemeier Hansson | 2017-07-09 | 16 | -21/+138 |
| | |||||
* | Copypasta comments | David Heinemeier Hansson | 2017-07-09 | 1 | -3/+0 |
| | | | | | | | | | | # Conflicts: # lib/active_storage/engine.rb # lib/active_storage/service.rb # lib/active_storage/service/disk_service.rb # lib/active_storage/service/s3_service.rb # test/service/s3_service_test.rb # test/test_helper.rb | ||||
* | Proper logging is now in place | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+0 |
| | |||||
* | Test URL generation for S3 and Disk | David Heinemeier Hansson | 2017-07-09 | 2 | -0/+10 |
| | |||||
* | Instrument and log the services | David Heinemeier Hansson | 2017-07-09 | 7 | -32/+169 |
| | |||||
* | Merge pull request #27 from dixpac/fix_configuration_keys_symbolization | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+1 |
|\ | | | | | Symbolize all keys inside configuration nested hash | ||||
| * | Symbolize all keys inside configuration nested hash | dixpac | 2017-07-09 | 1 | -1/+1 |
| | | | | | | | | | | Since configuration is a nested hash we need to symbolize all keys of the hash. Othervise fetcing will fail on start | ||||
* | | Example of keyfile specification | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+12 |
| | | |||||
* | | Ensure binary encoding for downloading | David Heinemeier Hansson | 2017-07-09 | 1 | -1/+1 |
|/ | |||||
* | Use class methods scope now that we have multiple | David Heinemeier Hansson | 2017-07-09 | 1 | -14/+16 |
| | |||||
* | Merge pull request #26 from jeremy/service-configurator | David Heinemeier Hansson | 2017-07-09 | 5 | -38/+39 |
|\ | | | | | Clarify how a service can build other composed services | ||||
| * | Clarify how a service can build other composed services | Jeremy Daer | 2017-07-09 | 5 | -38/+39 |
| | | | | | | | | | | | | | | | | | | * Service.build takes the literal YAML config hash for the service and a reference to the Configurator that's doing the building. * Services that compose additional services can use the Configurator to look them up and build them by name. See MirrorService for an example. References #23 | ||||
* | | Match new configurator needs | David Heinemeier Hansson | 2017-07-09 | 1 | -0/+2 |
|/ | |||||
* | Service: clarify Service.build arguments | Jeremy Daer | 2017-07-09 | 2 | -5/+5 |
| | | | | | | | First arg is config for the service we're instantiating. Second arg is service configurations so we can look up and configure other services by name. | ||||
* | Travis CI 💡 | Jeremy Daer | 2017-07-08 | 1 | -0/+15 |
| | |||||
* | Configure services that reference other services | Jeremy Daer | 2017-07-08 | 10 | -43/+89 |
| | | | | | | | | * Move service configuration from the Engine to Service * Delegate configuration mechanics to internal Service::Configurator * Delegate service building to the concrete Service classes, allowing them to configure composed services. * Implement for the Mirror service. | ||||
* | Mirror: explicit primary service and list of mirrors | Jeremy Daer | 2017-07-08 | 2 | -15/+22 |
| | | | | | | | | | | | | Pass separate primary service and list of mirrors rather than treating the first of the services list as the primary. Nice fit for keyword args, and something we've long wanted in the equivalent Basecamp file repository. Upload returns the results of the underlying service uploads rather than the io.rewind result. Rewind before uploading rather than afterward, and demonstrate that behavior with a test. Test that more than one mirror works. | ||||
* | Merge pull request #21 from jeremy/disk-binary-io | David Heinemeier Hansson | 2017-07-09 | 2 | -14/+8 |
|\ | | | | | Disk service: use binary IO throughout, not UTF-8 | ||||
| * | Disk service: use binary IO throughout, not UTF-8 | Jeremy Daer | 2017-07-08 | 2 | -14/+8 |
| | | |||||
* | | Merge pull request #22 from jeremy/disk-filename-url | David Heinemeier Hansson | 2017-07-09 | 5 | -9/+9 |
|\ \ | |/ |/| | Disk storage: ensure URLs end with the blob filename | ||||
| * | Disk storage: ensure URLs end with the blob filename since some user agents ↵ | Jeremy Daer | 2017-07-08 | 5 | -9/+9 |
|/ | | | | don't respect Content-Disposition filename | ||||
* | Tests: skip GCS/AWS service tests if unconfigured | Jeremy Daer | 2017-07-08 | 1 | -0/+1 |
| |