aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* since a lot of people use Ubuntu, document specific aptitude calls for some ↵Xavier Noria2010-12-291-2/+17
| | | | C dependencies in the contrib guide
* Do not use primary key on insertion when it's nilSantiago Pastorino2010-12-291-2/+2
|
* while defining callbacks option :rescuable => trueNeeraj Singh2010-12-291-1/+30
| | | | | | | can be passed. There were no tests for this case. This patch adds a test for :rescuable => true option.
* complete revision of the Contributing to Ruby on Rails guideXavier Noria2010-12-282-311/+355
| | | | | | | | | | | | | * adds instructions for PostgreSQL * adds references to mysql2 here and there * puts documentation contributions on par with code contributions * adds a section about Rails Contributors * documents C dependencies for Nokogiri and the database libs * everything double-checked and revised step by step * adds a section about warnings in the test suite * removes section about the Rails wiki * title and filename renamed * overall rewording
* Simplify inspect implementationSantiago Pastorino2010-12-281-1/+1
| | | | | After 304d38c0536dc32a8a1595ba34370ebf69a0d50d we don't need the new_record? check anymore.
* Allow primary_key to be an attribute when the model is a new recordSantiago Pastorino2010-12-283-4/+4
|
* I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2.Aaron Patterson2010-12-273-15/+3
|
* Clean up PathSet.José Valim2010-12-271-19/+4
|
* No need to symbolize these.José Valim2010-12-274-6/+8
|
* Final tidy up on templates inheritance.José Valim2010-12-275-17/+15
|
* Speed up template inheritance and remove template inheritance optionwycats2010-12-262-28/+17
|
* A bunch of cleanup on the inherited template patchwycats2010-12-266-21/+36
|
* all tests passartemave2010-12-269-40/+40
|
* #948 make template inheritance optionalartemave2010-12-262-4/+23
|
* #948 template_inheritanceartemave2010-12-2612-42/+129
|
* try not to make so many funcallsAaron Patterson2010-12-261-3/+6
|
* make our hash of klasses and ids actually have classes for keysAaron Patterson2010-12-261-8/+6
|
* stop calling deprecated apisAaron Patterson2010-12-262-5/+5
|
* Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵Jon Leighton2010-12-2610-52/+41
| | | | other things
* small rewording of my entry in the creditsXavier Noria2010-12-261-1/+1
|
* no docs credits are written in first person, thanks to Vijay Dev for ↵Xavier Noria2010-12-261-1/+1
| | | | spotting this
* Add a HasAssociation module for common code for has_* associationsJon Leighton2010-12-268-61/+69
|
* Remove AssociationProxy#dependent? - it's badly named and only used in one placeJon Leighton2010-12-262-6/+1
|
* Associations: DRY up the code which is generating conditions, and make it ↵Jon Leighton2010-12-267-65/+50
| | | | all use arel rather than SQL strings
* Fix dodgy tests which were effectively asserting nil == nilJon Leighton2010-12-262-3/+4
|
* Remove custom_select param from construct_select, as it isn't usedJon Leighton2010-12-261-3/+3
|
* Remove construct_from from ThroughAssociationScope - it's not called from ↵Jon Leighton2010-12-261-4/+0
| | | | anywhere
* Set the create scope to an empty hash in ThroughAssociationScope. For ↵Jon Leighton2010-12-261-1/+5
| | | | reasoning please see the inline code comments.
* Use conditionals and implicit returns rather than explicit returns and ↵Jon Leighton2010-12-261-3/+7
| | | | postfix ifs (it's easier to read)
* Remove has_cached_counter? and cached_counter_attribute_name from ↵Jon Leighton2010-12-261-8/+0
| | | | HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation
* Remove pointless use of 'private'Jon Leighton2010-12-261-1/+0
|
* Use the through association proxy for operations on the through record, so ↵Jon Leighton2010-12-263-17/+17
| | | | that those operations are automatically scoped and therefore construct_join_attributes does not need to use construct_owner_attributes.
* Remove target_obsolete? which is not called from anywhereJon Leighton2010-12-261-4/+0
|
* scoped.where_values_hash is never nilJon Leighton2010-12-261-1/+1
|
* Update JQuery UJSSantiago Pastorino2010-12-261-26/+48
|
* Update Prototype UJSSantiago Pastorino2010-12-261-29/+43
|
* use https to fetch files from GitHubAkira Matsuda2010-12-261-2/+2
| | | | | | | | see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere [#6223 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* refactor to use group_byAaron Patterson2010-12-251-3/+3
|
* arel will deal with casting the ids, so we can delete thisAaron Patterson2010-12-251-13/+1
|
* use arel to determine selection columnAaron Patterson2010-12-251-2/+1
|
* refactoring method selectionAaron Patterson2010-12-251-10/+5
|
* using arel to compile sql statementsAaron Patterson2010-12-254-10/+21
|
* use sql literal factory methodAaron Patterson2010-12-251-1/+1
|
* take more advantage of arel sql compilerAaron Patterson2010-12-252-13/+21
|
* refactoring AST buildingAaron Patterson2010-12-251-5/+3
|
* use arel to compile SQL statementsAaron Patterson2010-12-251-6/+15
|
* stop redifining methods on every call to set_primary_keyAaron Patterson2010-12-243-8/+23
|
* use the sql literal factory methodAaron Patterson2010-12-241-1/+1
|
* stop the recursive insanityAaron Patterson2010-12-241-5/+10
|
* setting the primary key on the update managerAaron Patterson2010-12-241-0/+1
|