| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| | | | | |
| | | | | | |
Previews when `mail` wasn't called (NullMail instances).
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
While this was true before when every `dd` had a value,
this patch makes sure that everything keeps lining up even
when the `dd` node is blank.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Make sure you execute rake rdoc from rails root directory [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1. Make clear where rake rdoc is executed
2. Make clear where the generated HTML files for the guides are stored
3. Use bundler 1.3.5 or later
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clarify test_order default configuration behaviour [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Explain config.active_support.test_order defaults
to :random in newly-generated applications thanks
to generated config/environments/test.rb, otherwise
default is :sorted (until Rails 5.0).
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fixed typo in documentation
|
| | |_|/ / /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
templates [ci skip]
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
AUTH PLAIN is Base64 encoded [ci skip]
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Contrary to what the name suggests, PLAIN SMTP authentication is not
sent in plain text but is Base64 encoded like the LOGIN method. Their
difference is described in the third link below.
* https://tools.ietf.org/html/rfc4954
* https://en.wikipedia.org/wiki/SMTP_Authentication
* http://www.samlogic.net/articles/smtp-commands-reference-auth.htm
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rails has different naming conventions for the inverse assertion
methods. While minitest uses `refute` we use `_not`. We should have a
table listing the common assertions that you want to use in the Rails
context.
Refs #18305.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Unlock sneakers adapter version
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | | |
Fix unscope for less than
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Code such as the following will be corrected.
Developer.where(id: -Float::INFINITY...2).unscope(where: :id)
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | | |
Raise ArgumentError when find_by receives no arguments
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It fixes the strange error saying undefined method `take'.
```
RelationTest#test_find_by_without_arg_behaves_same_with_find_by({}):
NoMethodError: undefined method `take' for #<ActiveRecord::QueryMethods::WhereChain:0x007f9c55db1d68>
```
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Updated request_forgery_protection docs [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Changed Javascript to JavaScript.
- Added full-stop which was missing, also wrapped the sentence to 80 chars.
- Changed proc to Proc and oauth to OAuth.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Small punctuation fixes [ci skip]
|
|/ / / / / |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Add note about sti column value to becomes method [ci skip]
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[see #18392]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Correct route requirements by overriding defaultls
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add a test-case to make sure that `create_table` with
a `foreign_key: true` and an adapter without foreign key support
does not blow up.
Motivated by #19794.
Originating from: https://github.com/rails/rails/commit/99a6f9e60ea55924b44f894a16f8de0162cf2702#commitcomment-10855210
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
calebthompson/dont-rely-on-environment-task-for-schema-load"
This reverts commit 08ff4ccbbb3fb143a02e6752efb974a4bcfcd3bb, reversing
changes made to 6c9ed6dbc62450cdb87559afd15798305e069146.
Caused by #17920.
Closes #19545.
This patch introduced regressions because initializers were no longer
loaded. Specifically missing inflections result in broken restores of
the database.
|
| |_|_|/ /
|/| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also added reference for to_date, as it belongs historically.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Update ActiveSupport::Rails and ActiveSupport::Rescuable docs
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[Dave Moore]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Rm route wrapper internal hacks
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
sprockets-rails will only add `Rails.application.assets` if compile is
no false. See change on sprockets-rails
https://github.com/rails/sprockets-rails/commit/d7c7ee19991c565eb77ee143be2d009ba4472122
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
See the behaviour change on sprockets-rails
https://github.com/rails/sprockets-rails/commit/56725e5843662189c6701478f7598db306d5fb02
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We need to ignore the `assets_prefix` when running a command like `rake
routes`. However we cannot reference asserts_prefix from action_pack as
that is a sprockets-rails concern.
See this is now implemented on sprockets-rails
https://github.com/rails/sprockets-rails/commit/85b89c44ad40af3056899808475e6e4bf65c1f5a
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Removed unused code from request_forgery_protection tests
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Escape README in Plugin builder API documentation
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
- So that RDoc will not generate link for README.
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Uncomment byebug in framework Gemfile
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
History:
1. `debugger` was there until d2ed433b where it was commented out, and I
couldn't figure out why
2. Since then we inherited that when switching to `byebug` in 93559da4
Reasons:
1. It's nice to have a debugger when working on framework bugs
2. It's an uncommented dependency in app Gemfiles since Rails 4.2 (see fbe38c9e)
|