| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Related with 38d2bf5fd1f3e014f2397898d371c339baa627b1.
cc @tenderlove
|
|\
| |
| |
| | |
Add upcase_first method
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
To move Action Cable logging to a LoggingSubscriber we need to pass the
log tags in the notification payload since Action Cable logging use the
Channel instance to tag the logs.
|
| |\ \
| | | |
| | | |
| | | | |
Add ActiveSupport::Notification to Channel::Base#perform_action
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit adds ActiveSupport::Notifications instrumentation hooks
and a LogSuscriber to ActionCable::Channel::Base.
|
|\ \ \ \
| | | | |
| | | | | |
Add a test case for create a record with primary key as zero
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Remove `except` helper for test schema
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Add changelog for #24305
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Forgot to add, sigh.
Closes #24273
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update compatibility.rb
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
update `assert_no_performed_jobs` doc to use `assert_no_performed_jobs` method [ci skip]
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
method [ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Delegate some additional methods in querying.rb
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix typo in headers comment [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Update how to clear the association cache
|
|/ / / /
| | | |
| | | | |
Passing `true` to the association has been deprecated.
|
|\ \ \ \
| | | | |
| | | | | |
Update `numericality` validation docs
|
|/ / / /
| | | |
| | | |
| | | | |
Add `:other_than` option documentation.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/show_correct_command_name_in_help_of_rails_runner
show correct command name in help of rails runner
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If use rails together with `spring`, `spring` is rewrite `$0` in the interior
command name. Therefore, for `$0` correct command name does not appear, `$0` has
been modified so that it does not use.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] relations inside <tt> tag
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
s removed
objects added
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix description for method ActiveRecord::ConnectionAdapters::SchemaStatements#add_timestamps [ci skip]
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
ActiveRecord::ConnectionAdapters::SchemaStatements#add_timestamps [ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove old-dead link
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
add `:index_errors` option to example [ci skip]
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`skip` raises an exception to abort the execution of the test, so
`super` would never be called and thus `@rx_adapter` and `@tx_adapter`
would never have been defined at the time of teardown.
Define them just before skipping and zap the warnings.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
EM::Hiredis were spewing screenfuls of warnings when running the Action Cable tests.
Copied over the technique that shushes up faye-websocket in the client tests, so
we can reduce the noise ratio.
Note: there's still warnings spewed after tests have finished when EM::Hiredis shuts
down. I haven't been able to shush them up yet.
|
|\ \ \ \
| | | | |
| | | | | |
Highlight the dynamic method finder 'find_by_' [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
development.rb file always exists so we don't need a check for it
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Correct typos in "Active Record Query Interface" guide
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Do not create a hash key when calling ActiveModel::Errors#include?
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
From: https://github.com/rails/rails/issues/24279
Problem:
By doing `record.errors.include? :foo`, it adds a new key to the
@messages hash that defaults to an empty array.
This happens because of a combination of these 2 commits:
https://github.com/rails/rails/commit/b97035df64f5b2f912425c4a7fcb6e6bb3ddab8d
(Added in Rails 4.1)
and
https://github.com/rails/rails/commit/6ec8ba16d85d5feaccb993c9756c1edcbbf0ba13#diff-fdcf8b65b5fb954372c6fe1ddf284c78R76
(Rails 5.0)
By adding the default proc that returns an array for non-existing keys,
ruby adds that key to the hash.
Solution:
Change `#include?` to check with `has_key?` and then check if that value is
`present?`.
Add test case for ActiveModels::Errors#include?
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Gaurav2728/remove_unused_set_in_action_view_template_type
set in no more used in ActionView::Template::Types
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
initially set is used for template type https://github.com/rails/rails/commit/67f55e28
after this commit https://github.com/rails/rails/commit/91f2ad36 it’s not require
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix typo in Action Pack changelog [ci skip]
|
|/ / / / / |
|