| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
activemodel/lib/active_model/errors.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should mention that the ordering matters with regards
to timestamps, and not imply that it's just for uniqueness
purposes.
Closes #8610.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
quote column names in generated fixture files
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
paukul/validate_on_condition_on_transaction_callbacks
Validate :on option on after_commit and after_rollback callbacks
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
is false.
If it is nil we can't raise the exception
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
more descriptive return parameters
|
| | | | | | | | |
|
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
want you to check those in!
This reverts commit 35c554f0bf518e1068e79002a462c3deba649e9b.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
senny/8576_cant_inherit_from_deprecated_buffered_logger
deprecation warning when BufferedLogger is instantiated
|
| | |/ / / / /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
replace AS::BufferedLogger doc mentions with AS::Logger
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
senny/8576_cant_inherit_from_deprecated_buffered_logger
ActiveSupport::BufferedLogger can be subclassed
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove warning of intance variable not initialized
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
minor grammar fix
|
|/ / / / / / / |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The AS utility silence_warnings does not really silence this
one, because it is issued at parse-time. It seemed to in
some places because the constant was the only expression in
the block and therefore it was its return value, that could
potentially be used by silence_warnings are return value of
the yield call.
To bypass the warning we assign to a variable. The chosen
variable is "_" because it is special-cased in parse.c not
to issue an "assigned but unused variable" warning in turn.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
chmod -x from non-script files
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
"warning: ambiguous first argument; put parentheses or even spaces"
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
I don't think we're supporting SQLite 2
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
command
Closes #8545
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
another little documentation fix
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix Migration#reversible by not using `transaction`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Fix Migration#reversible by not using `transaction`.
* Adapt mysql adapter to updated api for remove_column
* Update test after aedcd683684d08eaf30623a4b48ce31a31426372
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
if format is unknown NullMimeTypeObject is returned
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If a request has an unknown format, the methods html?, xml?, json? ...etc
not raise an Exception.
This patch add a class Mime::NullType, that is returned when request.format is unknown
and it responds false to the methods that ends with '?' and true to 'nil?'.
It refers to #7837, this issue is considered a improvement not a bug.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Digestor explicit dependency should not contain trailing whitespace
|
| | | | |
| | | | |
| | | | |
| | | | | |
test for rails/rails#8586
|
| | | | |
| | | | |
| | | | |
| | | | | |
with Rails 4.0.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
WIP Refactor xml conversion to hash
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Three basic refactors in this PR:
* We extracted the logic into a method object. We now don't define a tone of extraneous methods on Hash, even if they were private.
* Extracted blocks of the case statement into methods that do the work. This makes the logic more clear.
* Extracted complicated if clauses into their own query methods. They often have two or three terms, this makes it much easier to see what they _do_.
We took care not to refactor too much as to not break anything, and put comments where we suspect tests are missing.
We think ActiveSupport::XMLMini might be a good candidate to move to a plugin in the future.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Correctly shows RAILS_ENV=development even when ENV['RAILS_ENV'] is not set (e.g., in Pow)
|