aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Merge pull request #16544 from schneems/schneems/death-to-dir-globGuillermo Iguaran2014-08-276-20/+13
| |\ \ | | | | | | | | Refactor out Dir.glob from ActionDispatch::Static
| | * | Refactor out Dir.glob from ActionDispatch::Staticschneems2014-08-276-20/+13
| |/ / | | | | | | | | | | | | | | | | | | | | | Dir.glob can be a security concern. The original use was to provide logic of fallback files. Example a request to `/` should render the file from `/public/index.html`. We can replace the dir glob with the specific logic it represents. The glob {,index,index.html} will look for the current path, then in the directory of the path with index file and then in the directory of the path with index.html. This PR replaces the glob logic by manually checking each potential match. Best case scenario this results in one less file API request, worst case, this has one more file API request. Related to #16464 Update: added a test for when a file of a given name (`public/bar.html` and a directory `public/bar` both exist in the same root directory. Changed logic to accommodate this scenario.
| * | Merge pull request #16723 from rubys/mention_assert_select_changesZachary Scott2014-08-271-0/+13
| |\ \ | | | | | | | | [ci skip] mention assert_select in release notes
| | * | [ci skip] mention assert_select in release notesSam Ruby2014-08-271-0/+13
| |/ /
| * | Merge pull request #16717 from splattael/keygeneratorSantiago Pastorino2014-08-271-1/+1
| |\ \ | | | | | | | | Use less iterations for KeyGenerator in tests
| | * | Use less iterations for KeyGenerator in testsPeter Suschlik2014-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit improves performance of cookie tests: Ruby | After | Before ----- | --------:| --------: MRI | 5.03s | 9.28s JRuby | 25.45s | 1648.23s Please note the improvement for JRuby.
| * | | Merge pull request #16707 from katmutua/masterSantiago Pastorino2014-08-271-3/+3
| |\ \ \ | | | | | | | | | | update 4_2_release_notes
| | * | | [ci skip] Update 4_2_release notesJackie Mutua2014-08-271-3/+3
| | | | |
| * | | | Merge pull request #16702 from sgrif/sg-binary-serializedRafael Mendonça França2014-08-273-0/+31
| |\ \ \ \ | | | | | | | | | | | | Correctly detect mutation on serialized columns mapping to binary
| | * | | | Correctly detect mutation on serialized columns mapping to binarySean Griffin2014-08-273-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #16701
| * | | | | Merge pull request #16722 from yui-knk/fix/guides_association_basics2Rafael Mendonça França2014-08-271-4/+4
| |\ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Fix typo of `collection_singular_ids=` method.
| | * | | | | [ci skip] Fix typo of `collection_singular_ids=` method.yui-knk2014-08-271-4/+4
| | | | | | |
| * | | | | | Merge pull request #16721 from yui-knk/fix/guides_association_basicsRafael Mendonça França2014-08-271-4/+4
| |\ \ \ \ \ \ | | |/ / / / / | |/| | | | | [ci skip] Fix typo of `collection=` method.
| | * | | | | [ci skip] Fix typo of `collection=` method.yui-knk2014-08-271-4/+4
| |/ / / / /
| * | | | | Merge pull request #16719 from tgxworld/fix_spelling_in_changelogArun Agrawal2014-08-271-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Fix spelling. [CI SKIP]
| | * | | | | Fix spelling. [CI SKIP]Guo Xiang Tan2014-08-271-1/+1
| |/ / / / /
| * | | | | fix broken `gem` method with non-String arguments. Closes #16709.Yves Senn2014-08-273-4/+23
| | | | | | | | | | | | | | | | | | | | | | | | This was caused by #15327.
| * | | | | minor changelog formatting changes.Yves Senn2014-08-273-9/+11
| | | | | |
| * | | | | Merge pull request #16661 from edogawaconan/doc-fixYves Senn2014-08-271-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Update documentation to match change in #5942 [ci skip]
| | * | | | | Update documentation to match change in #5942 [ci skip]edogawaconan2014-08-241-1/+1
| | | | | | |
| * | | | | | Merge pull request #16715 from y-yagi/update_4_2_release_notesZachary Scott2014-08-271-1/+1
| |\ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | [ci skip] Modify a web-console PR link for release noted
| | * | | | | [ci skip] Modify a web-console PR linkyuuji.yaginuma2014-08-271-1/+1
| |/ / / / /
| * | | | | Merge pull request #16713 from tomkadwill/documented_eqls_other_paramZachary Scott2014-08-271-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Updated documentation syntax of other parameter for rdoc
| | * | | | | [ci skip] Updated documentation syntax of other parameter for rdocTom Kadwill2014-08-271-1/+1
| |/ / / / /
| * | | | | Merge pull request #16708 from zzak/bcjordan-patch-1Zachary Scott2014-08-261-16/+16
| |\ \ \ \ \ | | | | | | | | | | | | | | Adjusted punctuation and grammar for Form Helpers guide [ci skip]
| | * | | | | Adjusted punctuation and grammar for Form Helpers guide [ci skip]Brian Jordan2014-08-261-16/+16
| |/ / / / /
| * | | | | Merge pull request #16705 from tomkadwill/documented_many_block_paramZachary Scott2014-08-261-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
| | * | | | | [ci skip] Updated documentation syntax of block parameter for rdoc Tom Kadwill2014-08-261-1/+1
| | | | | | |
| * | | | | | Merge pull request #16706 from tomkadwill/documented_include_record_paramZachary Scott2014-08-261-1/+1
| |\ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | [ci skip] Updated include to reference record parameter for rdoc
| | * | | | | [ci skip] Updated include to reference record parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ / / / /
| * | | | | Merge pull request #16703 from tomkadwill/documented_any_block_paramZachary Scott2014-08-261-1/+1
| |\| | | | | | | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
| | * | | | [ci skip] Updated documentation syntax of block parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ / / /
| * | | | Merge pull request #16700 from seuros/autoloadRafael Mendonça França2014-08-263-2/+18
| |\ \ \ \ | | | | | | | | | | | | [ActiveJob] Autoload adapters
| | * | | | [ActiveJob] Autoload adaptersAbdelkader Boudih2014-08-263-2/+18
| | | |/ / | | |/| |
| * | | | Merge pull request #16613 from splattael/masterMatthew Draper2014-08-271-7/+10
| |\ \ \ \ | | | | | | | | | | | | | | | | | | Speed up JRuby tests by improving the startup time
| | * | | | Speed up JRuby tests by improving its startup timePeter Suschlik2014-08-251-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Emulate `jruby --dev` which improves JRuby's startup time. See https://github.com/jruby/jruby/wiki/Improving-startup-time#use-the---dev-flag Follow @headius' idea and give Java more memory to reduce GC time.
| * | | | | Keep the first string we fetchMatthew Draper2014-08-271-1/+1
| | |/ / / | |/| | | | | | | | | | | | | Otherwise, it's possible for GC to run in between, and fail the test.
| * | | | Merge pull request #16697 from ↵Zachary Scott2014-08-261-0/+15
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tomkadwill/has_and_belongs_to_many_documenting_extension_param [ci skip] Added documentation for has_and_belongs_to_many extension parameter
| | * | | | [ci skip] Added documentation for has_and_belongs_to_many extension parameterTom Kadwill2014-08-261-0/+15
| |/ / / /
| * | | | Merge pull request #16646 from sgrif/sg-perf-regressionJeremy Kemper2014-08-251-1/+20
| |\ \ \ \ | | | | | | | | | | | | Cache the value of `changed_attributes` when calling `changes_applied`
| | * | | | Cache the value of `changed_attributes` when calling `changes_applied`Sean Griffin2014-08-221-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `changes_applied` calles `changes`, which will call `changed_attributes` multiple times in a loop. This method actually performs work now, so we should cache the results while looping over it when we know it cannot change.
| * | | | | Override #find_by! in core to enable AST cachingGodfrey Chan2014-08-252-0/+26
| | | | | |
| * | | | | Fixed find_by("sql fragment without bindings") on masterGodfrey Chan2014-08-254-17/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Also duplicated find_by tests from relations_test.rb to finder_test.rb now that we have a completely different implementation on the class (in core.rb with AST caching stuff). * Also removed a (failing) test that used mocks. Now that we have tests for the behavior, there's no point having another test that tests the implementation (that it delegates). Further, what the test was implying is nolonger true with the current implementation, because Class.find_by is a real method now.
| * | | | | Merge pull request #16695 from ericbrooke/patch-1Rafael Mendonça França2014-08-251-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Added web links
| | * | | | | Added web linksEric Brooke2014-08-251-1/+1
| |/ / / / / | | | | | | | | | | | | Added web links to resque, delayed_job and sidekiq
| * | | | | Merge pull request #16689 from ankit1910/improve-englishEileen M. Uchitelle2014-08-251-2/+2
| |\ \ \ \ \ | | | | | | | | | | | | | | [ci skip] make assert messages consistent
| | * | | | | [ci skip] make assert messages consistentankit19102014-08-251-2/+2
| | | | | | |
| * | | | | | Merge pull request #16682 from untidy-hair/use_activesupport_concernJeremy Kemper2014-08-251-7/+7
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Use ActiveSupport::Concern
| | * | | | | | Use ActiveSupport::Concern instead of the traditinal wayYukio Mizuta2014-08-251-7/+7
| | | | | | | |
| * | | | | | | Quick pass through the 4.2 release notes [ci skip]Robin Dupret2014-08-251-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a few typos and made some tiny improvements. Refs #16576. [Zachary Scott & Robin Dupret]