aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Further encapsulate dirty checking on `Attribute`Sean Griffin2015-10-026-51/+99
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can skip the allocation of a full `AttributeSet` by changing the semantics of how we structure things. Instead of comparing two separate `AttributeSet` objects, and `Attribute` is now a singly linked list of every change that has happened to it. Since the attribute objects are immutable, to apply the changes we simply need to copy the head of the list. It's worth noting that this causes one subtle change in the behavior of AR. When a record is saved successfully, the `before_type_cast` version of everything will be what was sent to the database. I honestly think these semantics make more sense, as we could have just as easily had the DB do `RETURNING *` and updated the record with those if we had things like timestamps implemented at the DB layer. This brings our performance closer to 4.2, but we're still not quite there.
* | | | | Merge pull request #21838 from jeremy/response-add-headerJeremy Daer2015-10-012-0/+79
|\ \ \ \ \ | |_|/ / / |/| | | | Response#add_header for adding to multi-valued headers like Vary
| * | | | Response#add_header for adding to multi-valued headers like VaryJeremy Daer2015-10-012-0/+79
|/ / / /
* | | | Merge pull request #21836 from jeremy/no-nil-set-cookie-headersJeremy Daer2015-10-012-75/+96
|\ \ \ \ | | | | | | | | | | Don't set a nil Set-Cookie header when there aren't any cookies
| * | | | Don't set a nil Set-Cookie header when there aren't any cookies. Omit the ↵Jeremy Daer2015-10-012-75/+96
|/ / / / | | | | | | | | | | | | header.
* | | | Merge pull request #21757 from Gaurav2728/gaurav-adding_x_frame_testKasper Timm Hansen2015-10-011-1/+11
|\ \ \ \ | | | | | | | | | | adding test for content type with default charset
| * | | | adding test for content type with default charsetGaurav Sharma2015-10-021-1/+11
|/ / / / | | | | | | | | | | | | | | | | * first test is for `default_charset` i.e `ActionDispatch::Response.default_charset = “utf-8”` * In below test we are passing `ActionDispatch::Response.default_charset = 'utf-16’` so name of the test is irrelevant — “read content type without charset”
* | | | Merge pull request #20599 from aliaksandrb/regex_fix_for_mattr_accessorArthur Nogueira Neves2015-10-012-2/+16
|\ \ \ \ | | | | | | | | | | Regex fix for mattr_accessor validation
| * | | | Regex fix for mattr_accessor validationAliaksandr Buhayeu2015-10-012-2/+16
|/ / / / | | | | | | | | | | | | | | | | Change ^ and $ operators to \A and \z to prevent code injection after the line breaks
* | | | Merge pull request #21760 from repinel/refactor-as-callbacks-halt-configKasper Timm Hansen2015-10-019-36/+38
|\ \ \ \ | | | | | | | | | | Refactor AS::Callbacks halt config and fix the documentation
| * | | | Refactor AS::Callbacks halt config and fix the documentationRoque Pinel2015-10-019-36/+38
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false` to `AS::Callbacks.halt_and_display_warning_on_return_false` base on [this discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580) Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
* | | | Merge pull request #21823 from prakashlaxkar/test_casesKasper Timm Hansen2015-10-011-0/+12
|\ \ \ \ | | | | | | | | | | Added test cases for checkbox_tag
| * | | | Add test cases for checkbox_tagPrakash Laxkar2015-10-011-0/+12
|/ / / /
* | | | make sure exceptions are marshalable when returning test resultsAaron Patterson2015-09-301-1/+17
| | | | | | | | | | | | | | | | | | | | this should fix the error where isolation tests raise an exception and we just get a marshal error
* | | | Merge pull request #21821 from akshay-vishnoi/fix-test-casesKasper Timm Hansen2015-09-301-1/+7
|\ \ \ \ | | | | | | | | | | Add test cases for text_field_tag
| * | | | Add test case for text_field_tagAkshay Vishnoi2015-10-011-1/+7
|/ / / /
* | | | only construct one request in an engineAaron Patterson2015-09-302-14/+17
| | | |
* | | | run against edge sass to eliminate circular require warningsAaron Patterson2015-09-303-7/+11
|/ / /
* | | Merge pull request #20574 from repinel/fix-db-fixtures-loadYves Senn2015-09-308-14/+130
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow fixtures YAML files to set the model class in the file itself Conflicts: activerecord/CHANGELOG.md
| * | | Allow fixtures YAML files to set the model class in the file itselfRoque Pinel2015-09-119-12/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `set_fixture_class` is only available using the `TestFixtures` concern and it is ignored for `rake db:fixtures:load`. Using the correct model class, it is possible for the fixture load to also load the associations from the YAML files (e.g., `:belongs_to` and `:has_many`).
* | | | Merge pull request #21817 from jdantonio/clear-concurrent-ruby-warningsKasper Timm Hansen2015-09-303-6/+6
|\ \ \ \ | | | | | | | | | | Fixed concurrent-ruby warnings.
| * | | | Fixed concurrent-ruby warnings.Jerry D'Antonio2015-09-293-6/+6
|/ / / / | | | | | | | | | | | | | | | | Bumped version of concurrent-ruby to 1.0.0.pre3, which fixes all interpreter warnings.
* | | | Bump concurrent-ruby to shush circular require warningJeremy Daer2015-09-291-1/+1
| | | |
* | | | call `default_middleware_stack` before merging stacksAaron Patterson2015-09-291-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `default_middleware_stack` seems to kick off the `on_load` calls that may mutate the middleware stack. We have to call that method before merging middleware stacks, otherwise the middleware stacks get mutated *after* the app middleware stack is built.
* | | | Engines get different middleware than appsAaron Patterson2015-09-293-4/+29
| | | | | | | | | | | | | | | | | | | | We shouldn't merge the app middleware in to the config middleware for engines.
* | | | Merge pull request #21794 from ↵Jeremy Daer2015-09-2911-191/+262
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jeremy/sprockets/move-asset-manifest-from-toplevel-to-config-subdir Eliminate overlapping `app/assets` load path
| * | | | Eliminate overlapping `app/assets` load pathJeremy Daer2015-09-2911-191/+262
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move `app/assets/manifest.js` to `app/assets/config/manifest.js`. Avoid the suggestion that you can/should deep-link `stylesheets/foo`. * Pull in all toplevel stylesheets and JavaScripts, not just `application.js` and `.css`. Demonstrate how to use `link_directory` with a specified `.js`/`.css` type. * Fix RAILS_ENV handling in assets tests. * Shush warnings spam from third-party libs that distract from tests.
* | | | Make app building threadsafeeileencodes2015-09-291-4/+8
| | | |
* | | | Stop modifying global variableseileencodes2015-09-293-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | Allocating a new middleware proxy in each application configuration and then merging the app specific config with the global config when the app is built.
* | | | Merge pull request #21813 from prakashlaxkar/doc_changesRafael Mendonça França2015-09-296-6/+6
|\ \ \ \ | | | | | | | | | | Improve readability of docs by using code tag [ci skip]
| * | | | Improve readability of docs by using code tag [ci skip]Prakash Laxkar2015-09-296-6/+6
| | | | |
* | | | | Merge pull request #21816 from nburkley/has-many-documentationArthur Nogueira Neves2015-09-291-1/+4
|\ \ \ \ \ | |/ / / / |/| | | | Fix documentation for has_many dependant options.
| * | | | Fix documentation for has_many dependant options.Niall Burkley2015-09-291-1/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | * A `has_many` dependant association accepts `[:destroy, :delete_all, :nullify, :restrict_with_error, :restrict_with_exception]` as options. Currently the documentation references `delete` instead of `delete_all` * Adds documentation for other options
* | | | Merge pull request #21430 from kaspth/test-runner-fail-fastKasper Timm Hansen2015-09-295-6/+197
|\ \ \ \ | | | | | | | | | | Add fail fast reporting to test runner.
| * | | | Add fail fast to test runner.Kasper Timm Hansen2015-09-295-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | Passing `--fail-fast` to the test runner will now abort the test run on the first failure. The run continues on any unexpected errors.
| * | | | Add inline failure reporting to test runner.Kasper Timm Hansen2015-09-285-6/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any failures or errors will be reported inline during the run by default. Skipped tests will be reported if run in verbose mode. Any result is output with failure messages and a rerun snippet for that test. Rerun snippets won't be output after a run, unless `--defer-output` is passed.
* | | | | Merge pull request #21661 from akshay-vishnoi/submit_tag_testsRafael Mendonça França2015-09-292-1/+9
|\ \ \ \ \ | | | | | | | | | | | | Fix - Prevent adding of `data-disable-with` option twice in html.
| * | | | | Fix - Prevent adding of `data-disable-with` option twice in html.Akshay Vishnoi2015-09-182-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Earlier when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." data-disable-with="Processing..." /> ``` Now when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." /> ```
* | | | | | Merge pull request #21811 from akihiro17/remove-unused-test-codeRafael Mendonça França2015-09-291-11/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove TestRouter#add_routes
| * | | | | | Remove TestRouter#add_routesakihiro172015-09-291-11/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now, we use the mapper to build the routing table related to https://github.com/rails/rails/commit/703275ba70efbefb3358052b6ba750443eff1a28
* | | | | | Merge pull request #21810 from akshay-vishnoi/form-tag-testsRafael Mendonça França2015-09-291-3/+3
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Fix names of test cases
| * | | | | Fix names of test casesAkshay Vishnoi2015-09-291-3/+3
|/ / / / /
* | | | | Merge pull request #21807 from ronakjangir47/fix_formatted_offset_docsRafael Mendonça França2015-09-293-3/+10
|\ \ \ \ \ | | | | | | | | | | | | Update docs for `formatted_offset`
| * | | | | Update docs for `formatted_offset` Ronak Jangir2015-09-293-3/+10
| | | | | | | | | | | | | | | | | | Output of `formatted_offset` is depends on input so it’s not always in +HH:MM format. Possible outputs are “+5:30”, “+530” or provided alternate UTC string [ci skip]
* | | | | | remove useless methodAaron Patterson2015-09-281-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the caller of `handle_conditional_get!` checks the committed state of the response, so we don't need to in the subclass.
* | | | | | Separate `dup` from `deep_dup` in the attributes hashSean Griffin2015-09-285-6/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm looking to move towards a tree-like structure for dirty checking that involves an attribute holding onto the attribute that it was created from. This means that `changed?` can be fully encapsulated on that object. Since the objects are immutable, in `changes_applied`, we can simply perform a shallow dup, instead of a deep one. I'm not sure if that will actually end up in a performance boost, but I'd like to semantically separate these concepts regardless
* | | | | | Inline `Attribute#original_value`Sean Griffin2015-09-281-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The external uses of this method have been removed, and I'd like to internally re-use that name, as I'm planning to encapsulate `changed?` into the attribute object itself.
* | | | | | Merge pull request #21800 from ↵Rafael Mendonça França2015-09-281-2/+1
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | Gaurav2728/no_more_class_methods_for_JoinDependency no more class methods for JoinDependency [ci skip]
| * | | | | no more class methods for JoinDependency [ci skip]Gaurav Sharma2015-09-291-2/+1
| | | | | | | | | | | | | | | | | | `ActiveRecord::Associations::JoinDependency` now it’s own class` and `ActiveRecord::Associations::ThroughAssociationScope` doesn’t exists
* | | | | | Merge pull request #21782 from ronakjangir47/transform_values_docsRafael Mendonça França2015-09-282-8/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | Updated docs for transform_keys & transform_values
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 00:37:39 +0000