| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| | |
paukul/validate_on_condition_on_transaction_callbacks
Validate :on option on after_commit and after_rollback callbacks
|
| | |
|
| |
| |
| |
| |
| |
| | |
is false.
If it is nil we can't raise the exception
|
|\ \
| | |
| | | |
more descriptive return parameters
|
| | | |
|
| |/
|/|
| |
| |
| |
| | |
want you to check those in!
This reverts commit 35c554f0bf518e1068e79002a462c3deba649e9b.
|
|\ \
| | |
| | |
| | |
| | | |
senny/8576_cant_inherit_from_deprecated_buffered_logger
deprecation warning when BufferedLogger is instantiated
|
| | | |
|
|\ \ \
| |/ /
|/| | |
replace AS::BufferedLogger doc mentions with AS::Logger
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
senny/8576_cant_inherit_from_deprecated_buffered_logger
ActiveSupport::BufferedLogger can be subclassed
|
|/ / |
|
|\ \
| | |
| | | |
Remove warning of intance variable not initialized
|
| | | |
|
|\ \ \
| | | |
| | | | |
minor grammar fix
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The AS utility silence_warnings does not really silence this
one, because it is issued at parse-time. It seemed to in
some places because the constant was the only expression in
the block and therefore it was its return value, that could
potentially be used by silence_warnings are return value of
the yield call.
To bypass the warning we assign to a variable. The chosen
variable is "_" because it is special-cased in parse.c not
to issue an "assigned but unused variable" warning in turn.
|
|\ \ \
| |_|/
|/| | |
chmod -x from non-script files
|
|/ / |
|
|\ \
| | |
| | | |
"warning: ambiguous first argument; put parentheses or even spaces"
|
|/ / |
|
|\ \
| | |
| | | |
I don't think we're supporting SQLite 2
|
| |/ |
|
| |
| |
| |
| |
| |
| | |
command
Closes #8545
|
|\ \
| |/
|/| |
another little documentation fix
|
|/ |
|
|\
| |
| | |
Fix Migration#reversible by not using `transaction`.
|
| |
| |
| |
| |
| |
| |
| |
| | |
* Fix Migration#reversible by not using `transaction`.
* Adapt mysql adapter to updated api for remove_column
* Update test after aedcd683684d08eaf30623a4b48ce31a31426372
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
if format is unknown NullMimeTypeObject is returned
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a request has an unknown format, the methods html?, xml?, json? ...etc
not raise an Exception.
This patch add a class Mime::NullType, that is returned when request.format is unknown
and it responds false to the methods that ends with '?' and true to 'nil?'.
It refers to #7837, this issue is considered a improvement not a bug.
|
|\ \
| |/
|/| |
Digestor explicit dependency should not contain trailing whitespace
|
| |
| |
| |
| | |
test for rails/rails#8586
|
| |
| |
| |
| | |
with Rails 4.0.
|
|\ \
| | |
| | | |
WIP Refactor xml conversion to hash
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Three basic refactors in this PR:
* We extracted the logic into a method object. We now don't define a tone of extraneous methods on Hash, even if they were private.
* Extracted blocks of the case statement into methods that do the work. This makes the logic more clear.
* Extracted complicated if clauses into their own query methods. They often have two or three terms, this makes it much easier to see what they _do_.
We took care not to refactor too much as to not break anything, and put comments where we suspect tests are missing.
We think ActiveSupport::XMLMini might be a good candidate to move to a plugin in the future.
|
|\ \ \
| | | |
| | | | |
Correctly shows RAILS_ENV=development even when ENV['RAILS_ENV'] is not set (e.g., in Pow)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
(e.g., in Pow)
* Fixes #8025
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit b3125c89f42968bec6ee0b92ab93e36dbc36d5c3.
* It is not desirable to set `ENV['RAILS_ENV']`; otherwise, it will leak
through to rake tasks such as `rake test` or `rake spec`. See #7175
for more details.
|
|\ \ \ \
| |/ / /
|/| | | |
Http token parser bug
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adding a test for the equal trun bug
Adding a test for the after equal trunc bug
Adding a test for the slash bug
Adding a test for the slash quote bug
Adding a helper method for creating a sample request object with token
Writing a method to create params array from raw params
Writing a method to rewrite param values in the params
Writing a method to get the token params from an authorization value
Refactoring the token_and_options method to fix bugs
Removing unnessecary test
A constant for this shared regex seemed appropriate
Wanting to split up this logic
Adding small documentation pieces
|
| | | | |
|