aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge commit 'alloy/master-nested_attributes_and_autosave'Michael Koziarski2009-09-1315-94/+424
|\
| * Removed the version of ActiveRecord::Base#destroyed? that was added in ↵Eloy Duran2009-09-122-7/+0
| | | | | | | | | | | | a44a1257d879311d88c2d10c366ab0d6561f903a. Because José Valim was cheeky enough to already add it to the master branch.
| * Removed some superfluous conditionals from the autosave association ↵Eloy Duran2009-09-121-5/+3
| | | | | | | | | | | | validation methods. Which are unneeded now that we only define them when needed.
| * Define autosave association validation methods only when needed. [#3161 ↵Alexey Kovyrin2009-09-124-7/+132
| | | | | | | | | | | | state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Added some documentation about setting :autosave => false on an association.Eloy Duran2009-09-121-3/+4
| |
| * During autosave, ignore records that already have been destroyed. [#2537 ↵Eloy Duran2009-09-122-2/+28
| | | | | | | | state:resolved]
| * Fix has_one with foreign_key and primary_key association bug which caused ↵Graeme Porteous2009-09-126-5/+20
| | | | | | | | | | | | | | | | the associated object being lost when saving the owner. [#1756 state:resolved] Mixed in a bit from patch by ransom-briggs. [#2813 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Rename nested attributes _delete to _destroy to reflect its actual behavior ↵José Valim2009-09-122-54/+71
| | | | | | | | | | | | and DSL (:allow_destroy). Deprecation warning added. [#2889 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Fix autosave association to skip validation if it is marked for destruction. ↵Dmitry Polushkin2009-09-122-8/+11
| | | | | | | | | | | | [#2064 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Explicitely setting `autosave => false' should override new_record ↵Eloy Duran2009-09-124-6/+75
| | | | | | | | | | | | autosaving. [#2214 state:resolved] Original author is Jacob.
| * Allow fields_for on a nested_attributes association to accept an explicit ↵Andrew France2009-09-122-7/+55
| | | | | | | | | | | | collection to be used. [#2648 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Don't cascade autosave validation to destroyed children. [#2761 state:resolved]Lance Ivy2009-09-124-0/+20
| | | | | | | | Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
| * Raise an exception with friendlier error message when attempting to build a ↵Mike Breen2009-09-123-1/+16
| | | | | | | | | | | | polymorphic belongs_to with accepts_nested_attributes_for. [#2318 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
* | Memoize in the endpoint.Yehuda Katz2009-09-123-100/+11
| |
* | Get ActionPack's test running on bundled gems. This should make running ↵Yehuda Katz2009-09-1212-12/+127
| | | | | | | | tests on new machines, as well as CI, work well.
* | Revert "ruby 1.9 friendly secure_compare" because it breaks CI and Sam ↵Yehuda Katz2009-09-121-6/+9
| | | | | | | | | | | | Ruby's suite This reverts commit 5de75398c495f109772b622291362a98bc6c21d1.
* | Add per-controller middlewareYehuda Katz2009-09-122-1/+91
|/
* Fix habtm associations when using multiple databasessdsykes2009-09-121-2/+2
| | | | | | [#3128] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Revert "Allow frameworks to be required by their gem name"Jeremy Kemper2009-09-126-6/+0
| | | | | | | This has just been confusing. Better to educate than band-aid. This reverts commit 18a24274ec823ded4ffa29bf33fd3d76816aab7e. Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
* Ruby 1.9 compat: Avoid using the return value of FileUtils.mkdir_p, as it ↵Akira Matsuda2009-09-111-1/+1
| | | | | | | | does not return a String but an Array in Ruby 1.9 [#2018 state:committed milestone:2.3.5] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Ensure validation errors to be ordered in declared orderAkira Matsuda2009-09-112-1/+18
| | | | | | [#2301 state:committed milestone:2.3.5] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix default_error_messages back to the original messageAkira Matsuda2009-09-111-3/+6
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* ruby 1.9 friendly secure_compareJakub Kuźma2009-09-121-9/+6
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Removed the copyright notice not to show it in the result of 'ri ActiveRecord'.Shugo Maeda2009-09-111-22/+0
|
* Add gem load paths after loading environmentJoshua Peek2009-09-111-9/+9
|
* Fix filtering parameters when there are Fixnum or other un-dupable values.Nathaniel Talbott2009-09-102-1/+2
| | | | | | [#3184 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Remove redundant checks for valid character regexp in ↵Beau Harrington2009-09-101-2/+2
| | | | | | | | ActiveSupport::Multibyte#clean and #verify. [#3181 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix callbacks on ActionPack.José Valim2009-09-081-1/+1
| | | | Signed-off-by: Yehuda Katz <wycats@gmail.com>
* Refactor new callbacks and AR implementation.José Valim2009-09-0811-160/+155
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Changed ActiveRecord to use new callbacks and speed up observers by only ↵José Valim2009-09-0827-461/+376
| | | | | | notifying events that are actually being consumed. Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Ruby 1.9: fix MessageVerifier#secure_compareJeremy Kemper2009-09-081-9/+27
|
* Please 1.8.6 CIJoshua Peek2009-09-071-0/+3
|
* Start running AS isolated tests on CIJoshua Peek2009-09-071-0/+1
|
* Use draw/connect mapper api instead of directly using add_named_routeJoshua Peek2009-09-061-12/+34
|
* Need to reset session for AR session tests after altering the route setJoshua Peek2009-09-061-0/+1
|
* Add fake controllers for url rewriter testsJoshua Peek2009-09-062-0/+6
|
* Cleanup hacky routing with controller_path in url helper tests. This doesn't ↵Joshua Peek2009-09-063-64/+58
| | | | work in real life anyway.
* Need to reset session in internal integration tests after altering the route setJoshua Peek2009-09-061-0/+1
|
* Fix isolated running of AddressesTestJoshua Peek2009-09-062-6/+3
|
* Fix isolated running of ActionPackAssertionTestJoshua Peek2009-09-062-1/+2
|
* Fix failing isolated routing testJoshua Peek2009-09-051-16/+16
|
* Fix failing ARes isolated testsJoshua Peek2009-09-053-2/+6
|
* Fix warnings in AMoJoshua Peek2009-09-058-51/+10
|
* Fix failing AMo isolated testsJoshua Peek2009-09-054-0/+7
|
* Fix failing AS isolated testsJoshua Peek2009-09-054-3/+14
|
* Turn warnings on for AS isolated testsJoshua Peek2009-09-051-1/+1
|
* Fix a messed up merge commitMichael Koziarski2009-09-041-4/+0
|
* Clean tag attributes before passing through the escape_once logic.Michael Koziarski2009-09-041-1/+1
| | | | Addresses CVE-2009-3009
* Add verify and clean methods to ActiveSupport::Multibyte.Michael Koziarski2009-09-044-18/+239
| | | | | | | | | | | | When accepting character input from outside of your application you can't blindly trust that all strings are properly encoded. With these methods you can check incoming strings and clean them up if necessary. Signed-off-by: Michael Koziarski <michael@koziarski.com> Conflicts: activesupport/lib/active_support/multibyte.rb
* Fix timing attack vulnerability in ActiveSupport::MessageVerifier.Coda Hale2009-09-041-3/+16
| | | | | | Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC. Signed-off-by: Michael Koziarski <michael@koziarski.com>