| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The types that are affected by `time_zone_aware_attributes` (which is on
by default) have been made configurable, in case this is a breaking
change for existing applications.
|
|
|
|
|
|
| |
While we don't want to change the form input when validations fail,
blindly using `_before_type_cast` will cause the input to display the
wrong data for any type which does additional work on database values.
|
|
|
|
|
|
|
| |
If you entered incorrect input into a form (particularly with a
numericality validation), we should not replace what you typed in with
`0`, since clicking submit a second time would essentially be the same
as erroneously accepting the junk input as 0.
|
|
|
|
| |
This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
|
|
|
|
|
|
|
|
|
|
|
| |
We should never be ignoring valuable information that the types may need
to give us. The reason that it originally used `_before_type_cast` is
unclear, but appears to date back long enough that the reasons may not
be relevant today. There is only one test that asserts that it uses the
before type cast version, but it gives no context as to why and uses a
mock which does not simulate the real world.
Fixes #18523.
|
|
|
|
|
|
| |
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
|
|
|
|
|
|
| |
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
|
|
|
|
|
|
|
| |
This behavior exists only to support fixtures, so we should handle it
there. Leaving it in `#quote` can cause very subtle bugs to slip
through, by things appearing to work when they should be blowing up
loudly, such as #18385.
|
|\
| |
| | |
Correct the views that the mail method sends in API docs.
|
| | |
|
|\ \
| | |
| | | |
Changed "in GitHub" to "on GitHub" [ci skip]
|
| | |
| | |
| | |
| | | |
- Followup of https://github.com/rails/rails/pull/18503.
|
|\ \ \
| |/ /
|/| | |
Fix typo in ActionView CHANGELOG [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
Changed `IN` to `ON` in markdown renderer condition
|
| | |
| | |
| | |
| | | |
- Changed `IN` to `ON` in all note sentences in guides.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Grammar: "By default, Rails loads generators from your load path." [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Extract `Date` header to string constant in Http Response, similar to other headers
|
| |/ / /
| | | |
| | | |
| | | | |
headers
|
|\ \ \ \
| |/ / /
|/| | | |
fix link in autoloading guide [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
yoshiokatsuneo/active_record_connection_pool_error_disconnect
ActiveRecord: On reconnection failure, release only failed connetion.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
On reconnection failure, all the connection was released.
But, it is better to release only failed connection.
This patch changes not to release all the connection but release
only failed connection.
|
|\ \ \ \
| | | | |
| | | | | |
Fix form_for guide binding a form to an object. [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The HTML generated using
url: { action: :create}
will not generate the form action "/articles/create", it should generate
the form action "/articles" for a new object.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Add missing time zone definitions for Russian Federation
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also sync Russian Federation time zones with `zone.tab` file from tzdata version 2014j.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Guides: Removing reference to blog that is not updated anymore [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Clean up grammar in scaffold index view, by removing the word 'Listing' ...
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
list title.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #18473
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
deserve that billing)
|
| | | | | | | |
|
| |_|/ / / /
|/| | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Added the SQL equivalent of the find_by method. [ci skip]
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Added the SQL equivalent of the find_by method
Update active_record_querying.md
Update active_record_querying.md
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update asset pipeline guide
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Change a to an for HTML word [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
allow '1' or true for acceptance validation.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Removing :en in favor of default locale for duration#inspect
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Hi there,
i have an app without english as available locale. So i got an error when we try to inspect something like 1.day. This is done automatically when we use the dalli cache.
I would like to change the :en to ::I18n.default_locale to be sure that this is always constant and is an available locale.
Tests are all green with this change.
Calculating -------------------------------------
:locale => :en 2.024k i/100ms
:locale => ::I18n.default_locale 2.236k i/100ms
-------------------------------------------------
:locale => :en 25.758k (±26.3%) i/s - 117.392k
:locale => ::I18n.default_locale 26.311k (±18.1%) i/s - 127.452k
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Rack is very carefully released, we should be able to upgrade minor
versions without much effort. We are a bunch of Rails core who are also
Rack core members so there won't be any issue with that. And in case
there's something wrong, we should fix on both sides.
Even though, doesn't seem like we will have a 1.7 version, this will be
useful as an example for when we go with Rack 2.0. We should ~> 2.0.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix description for ActiveModel::Errors#generate_message [skip ci]
|
|/ / / / / |
|