aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Deterministic comparisons pleaseDavid Heinemeier Hansson2017-08-031-3/+3
| | | | |
| * | | | Do not change the entire codebase style only because of active_storageRafael Mendonça França2017-08-032-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
| * | | | Merge pull request #30041 from dixpac/change_azure_core_dependecyRafael França2017-08-032-13/+4
| |\ \ \ \ | | | | | | | | | | | | Change azure core dependency
| | * | | | Depend on offical azure-coredixpac2017-08-032-13/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No need to depend on my fork anymore, they've just release fix officially.
| * | | | | Fix all rubocop violationsRafael Mendonça França2017-08-032-6/+5
| | | | | |
| * | | | | Merge pull request #30061 from claudiob/ast-rubocopRafael França2017-08-035-5/+5
| |\ \ \ \ \ | | | | | | | | | | | | | | Make Rubocop happy about ActiveStorage
| | * | | | | Make Rubocop happier about ActiveStorageclaudiob2017-08-035-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
| * | | | | | We need to require the top file before individual oneRafael Mendonça França2017-08-031-0/+1
| | | | | | |
| * | | | | | Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-036-22/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
| * | | | | | Merge branch 'active-storage-import' of github.com:rails/rails into ↵David Heinemeier Hansson2017-08-035-7/+85
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | active-storage-import
| | * | | | | | Remove duplicated convert_direct_upload_option_to_urlRafael Mendonça França2017-08-032-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | FormHelper includes FormTagHelper so we don't need to define two methods
| | * | | | | | Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-032-3/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| | * | | | | | Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-033-1/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
| * | | | | | | Active Storage routes are now part of the default routesDavid Heinemeier Hansson2017-08-031-9/+37
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
| * | | | | | Same issue from AR getting loaded earlierDavid Heinemeier Hansson2017-08-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | cc @rafaelfranca
| * | | | | | Including new default classes in loading testDavid Heinemeier Hansson2017-08-031-3/+3
| | | | | | |
| * | | | | | Active Storage loads AR earlier to extend it so require env laterDavid Heinemeier Hansson2017-08-031-3/+7
| | | | | | |
| * | | | | | There is no reason to single line methods hereRafael Mendonça França2017-08-031-4/+12
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify.
| * | | | | Generating the app is where the exception is now raisedDavid Heinemeier Hansson2017-08-031-1/+1
| | | | | |
| * | | | | Can't initialize a message verifier without a key baseDavid Heinemeier Hansson2017-08-031-1/+3
| | | | | |
| * | | | | Merge pull request #30053 from ffmike/patch-2Richard Schneeman2017-08-031-1/+2
| |\ \ \ \ \ | | |/ / / / | |/| | | | Add Azure gems to README
| | * | | | Tweak requiresMike Gunderloy2017-08-021-1/+1
| | | | | | | | | | | | | | | | | | Omit azure-core (it's required by azure-storage), remove require:false to match other points.
| | * | | | Use release azure-core gemMike Gunderloy2017-08-021-1/+1
| | | | | |
| | * | | | Update README.mdMike Gunderloy2017-08-021-1/+1
| | | | | |
| | * | | | Add Azure gems to READMEMike Gunderloy2017-08-021-1/+2
| |/ / / /
| * | | | Merge pull request #30046 from ↵Rafael França2017-08-0217-28/+27
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_string_literals_violations_for_active_storage Fix `Style/StringLiterals` violations for Active Storage
| | * | | | Fix `Style/StringLiterals` violations for Active StorageRyuta Kamizono2017-08-0317-28/+27
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` % be rubocop -a --only Style/StringLiterals activestorage Inspecting 74 files ........................................CCCCCCCCCC.C........CC.......C.C.. (snip) 74 files inspected, 31 offenses detected, 31 offenses corrected ```
| * | | | Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-0238-110/+211
| |\ \ \ \
| * \ \ \ \ Merge pull request #30040 from rbarysas/active-storage-importRyuta Kamizono2017-08-021-0/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Add Azure to the available services list [ci skip]
| | * | | | | Add Azure to the available services listRolandas Barysas2017-08-021-0/+1
| |/ / / / /
| * | | | | Merge pull request #30035 from ytbryan/patch-1Ryuta Kamizono2017-08-021-3/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Add Azure to readme [ci skip]
| | * | | | | Add Azure to readme Bryan Lim2017-08-021-3/+1
| |/ / / / / | | | | | | | | | | | | previously https://github.com/rails/activestorage/pull/86
| * | | | | Skip if credentials aren't providedDavid Heinemeier Hansson2017-08-012-2/+2
| | | | | |
| * | | | | Fix dummy app for inclusion in RailsDavid Heinemeier Hansson2017-08-011-2/+1
| | | | | |
| * | | | | Remove circular dependencyDavid Heinemeier Hansson2017-08-011-2/+0
| | | | | |
| * | | | | Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-0117-35/+71
| |\ \ \ \ \
| * | | | | | Prevent interpolation of ERB elementsDavid Heinemeier Hansson2017-08-011-6/+6
| | | | | | |
| * | | | | | Add the storage.yml file by defaultDavid Heinemeier Hansson2017-08-011-0/+1
| | | | | | |
| * | | | | | Follow same format as action_cableDavid Heinemeier Hansson2017-08-011-1/+3
| | | | | | |
| * | | | | | Cut down on installation adviceDavid Heinemeier Hansson2017-08-011-8/+4
| | | | | | |
| * | | | | | Drop README terms no longer relevantDavid Heinemeier Hansson2017-08-011-12/+0
| | | | | | |
| * | | | | | Add requireDavid Heinemeier Hansson2017-08-011-0/+1
| | | | | | |
| * | | | | | We moved to storage.ymlDavid Heinemeier Hansson2017-08-012-35/+1
| | | | | | |
| * | | | | | Rely on top-level filesDavid Heinemeier Hansson2017-08-012-150/+0
| | | | | | |
| * | | | | | Merge pull request #30034 from ffmike/patch-1Guillermo Iguaran2017-08-011-0/+8
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Add Azure configuration to Active Storage template
| | * | | | | | Add Azure configuration to Active Storage templateMike Gunderloy2017-08-011-0/+8
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | With Active Storage supporting Azure, we should show people how to set it up. Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well
| * | | | | | Merge pull request #30030 from claudiob/only-diskGuillermo Iguaran2017-08-011-1/+3
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Let ActiveStorage tests pass only for Disk
| | * | | | | | Let ActiveStorage tests pass only for Diskclaudiob2017-08-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you have a "service/configurations.yml" file, but every single line is commented out, then an error occurs when running tests: ``` git:active-storage-import~/code/rails/activestorage$ rake ~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError) from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require' ``` The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`. This PR fixes this behavior so tests can also run when no remote service is available.
| * | | | | | | Merge pull request #30032 from claudiob/remove-httpartyGuillermo Iguaran2017-08-015-21/+18
| |\ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | | Remove HTTParty dependency
| | * | | | | | Don't depend on HTTPartyclaudiob2017-08-015-21/+18
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "httparty" is only added in #30020 to write two tests to make PUT requests against S3 and GCS. The same requests can be made with net/http, removing a dependency from the Gemfile.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-21 15:06:13 +0000