| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
[ci skip] correct output of select
|
|/ |
|
|\
| |
| | |
[CI SKIP] Correct output of options_for_select
|
|/ |
|
|\
| |
| | |
Fix typo in the Testing Your Mailers docs
|
|/
|
| |
* [ci skip]
|
|\
| |
| | |
Use request.session.id instead of request.session_options[:id]
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As of the upgrade to Rack 1.5, request.session_options[:id] is no
longer populated. Reflect this change in the tests by using
request.session.id instead.
Related change in Rack:
https://github.com/rack/rack/commit/83a270d6
|
|\ \
| | |
| | | |
Use a more conservative `const_get` over `constantize`
|
| | | |
|
|\ \ \
| |/ /
|/| | |
304 response should not include Content-Type header
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Rack::Lint raises an error saying "Content-Type header found in 304
response, not allowed".
|
|\ \ \
| | | |
| | | | |
[ci skip] Take NOTE: as paragraph to make NOTE block
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Isolate access to .default_scopes in ActiveRecord::Scoping::Default
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Instead use .scope_attributes? consistently in ActiveRecord to check whether
there are attributes currently associated with the scope.
Move the implementation of .scope_attributes? and .scope_attributes to
ActiveRecord::Scoping because they don't particularly have to do specifically
with Named scopes and their only dependency, in the case of
.scope_attributes?, and only caller, in the case of .scope_attributes is
contained in Scoping.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`setup do` creates unnecessary allocations of proc objects in callbacks.
This prevents that from happening and results in faster code.
|
|\ \ \ \
| | | | |
| | | | | |
add `DateTime.now` to list of `TimeHelpers#travel_to` stubbing [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Require pg ~> 0.18 to ensure Ruby 2.2 compatibility
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Versions of the pg gem earlier than 0.18.0 cannot be used safely with Ruby 2.2.
Specifically, pg 0.17 when used with Ruby 2.2 has a known bug that causes
random bits to be added to the end of strings. Further explanation here:
https://bitbucket.org/ged/ruby-pg/issue/210/crazy-bytes-being-added-to-record
|
|\ \ \ \
| |/ / /
|/| | | |
ActiveJob: queue_adapter can be inherited
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This allows different `queue_adapters` to be used in each `ActiveJob`
class heirarchy. Previously, all subclasses used a single global queue
adapter.
|
|\ \ \ \
| |/ / /
|/| | | |
Action Controller guide edits for grammar and clarity
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
`ActiveJob::QueueAdapters::*` are no longer singletons
|
| | | | | |
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This introduces undesirable `Rails.logger` formatters (such as the syslog
formatter) onto a `Logger.new(STDERR)` for the console. The production
logger may be going elsewhere than standard io, so we can't presume to
reuse its formatter.
With syslog, this causes missing newlines in the console, so irb prompts
start at the end of the last log message.
We can work to expose the console formatter in another way to address
the original issue.
This reverts commit 026ce5ddf11c4cda0aae7f33a9266e54117db318, reversing
changes made to 6f0a69c5899ebdc892e2aa23e68e2604fa70fb73.
|
|\ \ \
| | | |
| | | | |
Unnecessary usage of self in the guides [ci skip]
|
| | | |
| | | |
| | | | |
I deleted self from the callbacks guides code example because it's unnecessary and this way it's more like the other examples where self was not used.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Change to code element
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
This change was prompted by 598b841.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There was a typo in the `:requires_new` option. This led
to `#<ArgumentError: unknown keyword: require_new>` leaving all the
triggers in a disabled state.
|
|\ \ \ \
| | | | |
| | | | | |
Upd pg json_test
|
|/ / / / |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Let strip_tags leave HTML escaping to Rails.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Prevents double escaping errors, such as "&" becoming "&amp;".
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As of Ruby 2.2, Psych can handle any object which is marshallable. This
was not true on previous versions of Ruby, so our delegator types had to
provide their own implementation of `init_with` and `encode_with`.
Unfortunately, this doesn't match up with what Psych will do today.
Since by the time we hit this layer, the objects will have already been
created, I think it makes the most sense to just grab the current type
from the class.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I should have done this in the first place. We are now serializing an
explicit version so we can make more careful changes in the future. This
will load Active Record objects which were serialized in Rails 4.1.
There will be bugs, as YAML serialization was at least partially broken
back then. There will also be edge cases that we might not be able to
handle, especially if the type of a column has changed.
In addition, we're passing this as `from_database`, since that is
required for serialized columns at minimum. All other types were
serializing the cast value. At a glance, there should be no types for
which this is a problem.
Finally, dirty checking information will be lost on records serialized
in 4.1, so no columns will be marked as changed.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove unnecessary autoload path parameters
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Gaurav2728/gaurav-remove_test_after_commit_gem_msg
‘test_after_commit’ gem is not require in Rails 5, remove note from doc ...
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Changed 'blank space' to 'blank line'
|
|/ / / /
| | | |
| | | | |
Line 85 stated that fixtures are typically separated by a blank space. I changed the wording to blank line because blank space could be misinterpreted as a non-breaking space character when in reality, each fixture record (in YAML) is separated by a blank line.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The table is being modified in tests, without reloading the column
information on the appropriate class. This is leading to incorrect
column information in many cases.
The failures fixed by this commit can be replicated with:
ARCONN=postgresql ruby -Itest test/cases/adapters/postgresql/hstore_test.rb --seed 21574
|