Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Bring abstract_controller up to date with rails/master | Carl Lerche & Yehuda Katz | 2009-04-13 | 622 | -41616/+31620 | |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion. | |||||
| | * | Fix for TestResponse.cookies returning cookies unescaped [#1867 state:resolved] | Doug McInnes | 2009-04-07 | 3 | -1/+16 | |
| | | | | | | | | | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
| | * | added tests for session options being defaulted correctly to rack defaults ↵ | Kenny Ortmann | 2009-04-07 | 3 | -5/+42 | |
| | | | | | | | | | | | | | | | | | | [#2403 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Improve tests and code for Rails::InfoController and Rails::Info [#2411 ↵ | Manfred Stienstra | 2009-04-07 | 3 | -32/+41 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | state:resolved] - Refactor Rails::InfoController tests. - Return forbidden status from the InfoController for remote requests instead of a 500. - Add tests for displaying middleware in Rails::Info. Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Test cleanup | Geoff Buesing | 2009-04-05 | 1 | -3/+3 | |
| | | | ||||||
| | * | Hash::XML_TYPE_NAMES: no longer a need for a TimeWithZone entry; this class ↵ | Geoff Buesing | 2009-04-05 | 1 | -2/+1 | |
| | | | | | | | | | | | | will now match "Time" | |||||
| | * | TimeWithZone.name returns 'Time', to further thwart type checking | Geoff Buesing | 2009-04-05 | 3 | -0/+11 | |
| | | | ||||||
| | * | Support multiple schemas in table names for postgresql [#390 state:resolved] | Max Lapshin | 2009-04-05 | 2 | -1/+74 | |
| | | | | | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| | * | Merge docrails | Pratik Naik | 2009-04-05 | 9 | -169/+154 | |
| | | | ||||||
| | * | Object names with underscore do the wrong lookup in I18n on error_messages_for. | José Valim | 2009-04-05 | 2 | -4/+7 | |
| | | | | | | | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2390 state:committed] | |||||
| | * | Ensure SqlBypass use ActiveRecord::Base connection | Luca Guidi | 2009-04-05 | 2 | -18/+29 | |
| | | | | | | | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#https://rails.lighthouseapp.com/attachments/106066/0001-Ensure-SqlBypass-use-ActiveRecord-Base-connection.patch state:committed] | |||||
| | * | Nicer name for anonymous local cache middleware class | Joshua Peek | 2009-04-02 | 1 | -0/+5 | |
| | | | ||||||
| | * | Additional template render test for backup files [#2367 state:resolved] | Cezary Baginski | 2009-04-02 | 4 | -0/+10 | |
| | | | | | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Show installed middleware in builtin rails info (/rails/info/properties) ↵ | Michael Schuerig | 2009-04-02 | 2 | -2/+16 | |
| | | | | | | | | | | | | | | | | | | [#2396 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Enhance Time #since and #ago DST tests. | Geoff Buesing | 2009-03-29 | 1 | -16/+57 | |
| | | | ||||||
| | * | Time.local instances: Adding 24.hours across the DST boundary adds 24 hours ↵ | Michael Curtis | 2009-03-29 | 4 | -27/+36 | |
| | | | | | | | | | | | | instead of one day [#2066 state:resolved] | |||||
| | * | adding session_options initialization and test [#2303 state:resolved] | Ryan Angilly | 2009-03-24 | 2 | -0/+5 | |
| | | | | | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Fix template extension parsing. [#2315 state:resolved] [#2284 state:resolved] | thedarkone | 2009-03-24 | 2 | -30/+46 | |
| | | | | | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Simplify handling of absolute path templates. [#2276 state:resolved] | thedarkone | 2009-03-24 | 2 | -4/+9 | |
| | | | | | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Updates tests to cause the tests for the Request class not to proxy through ↵ | David Dollar | 2009-03-24 | 1 | -230/+218 | |
| | | | | | | | | | | | | | | | | | | a fake TestRequest object [#2278 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | Reset request_parameters in TestRequest#recycle! to avoid multiple posts ↵ | Peter Marklund | 2009-03-24 | 2 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | clobbering each other [#2271 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| | * | just kill brittle test | Joshua Peek | 2009-03-24 | 1 | -21/+0 | |
| | | | ||||||
| | * | Merge docrails | Pratik Naik | 2009-03-24 | 15 | -66/+141 | |
| | | | ||||||
| * | | Revert rspec-runner change. TODO: Add back support for the rspec T::U runner. | Carl Lerche & Yehuda Katz | 2009-04-09 | 2 | -310/+306 | |
| | | | ||||||
| * | | Updated old AC::Base for small changes to AV | Yehuda Katz and Carl Lerche | 2009-04-08 | 6 | -6/+8 | |
| | | | ||||||
| * | | Temporarily modifies setup to call super directly. This can support more ↵ | Yehuda Katz and Carl Lerche | 2009-04-08 | 28 | -4/+54 | |
| | | | | | | | | | | | | T::U runners. | |||||
| * | | Reverts changes made to AS::TC | Yehuda Katz and Carl Lerche | 2009-04-08 | 0 | -0/+0 | |
| | | | ||||||
| * | | Get Base2 layouts to work :) | Yehuda Katz and Carl Lerche | 2009-04-07 | 7 | -22/+121 | |
| | | | ||||||
| * | | Layouts work in AbstractController. Add support for the rspec runner for T::U | Yehuda Katz and Carl Lerche | 2009-04-07 | 5 | -84/+172 | |
| | | | ||||||
| * | | Add depends_on, use, and setup to abstract up ideas about module inheritance. | Yehuda Katz and Carl Lerche | 2009-04-07 | 15 | -73/+82 | |
| | | | ||||||
| * | | Merge branch 'abstract_controller' of git@github.com:wycats/rails into ↵ | Yehuda Katz and Carl Lerche | 2009-04-06 | 5 | -21/+155 | |
| |\ \ | | | | | | | | | | | | | abstract_controller | |||||
| | * | | In the middle of some refactoring... some fails due to changes in ↵ | Yehuda Katz and Carl Lerche | 2009-03-23 | 5 | -21/+155 | |
| | | | | | | | | | | | | | | | | AbstractController not yet reflected in ActionController tests | |||||
| * | | | Changes necessary to run the T::U tests with the rspec runner | Yehuda Katz and Carl Lerche | 2009-04-06 | 2 | -8/+25 | |
| |/ / | ||||||
| * | | Checkpoint | Yehuda Katz and Carl Lerche | 2009-03-23 | 6 | -62/+139 | |
| | | | ||||||
| * | | Add a bunch of tests for various render :action, layout combinations | Yehuda Katz | 2009-03-23 | 5 | -113/+242 | |
| | | | ||||||
| * | | Adding render :layout tests | Carl Lerche | 2009-03-23 | 1 | -0/+0 | |
| | | | ||||||
| * | | Finished implementing :layout for most of the render options | Carl Lerche | 2009-03-23 | 5 | -75/+132 | |
| | | | ||||||
| * | | Finished implementing layout for render :text | Carl Lerche | 2009-03-23 | 7 | -16/+67 | |
| | | | ||||||
| * | | Working on being able to render :text with layouts | Carl Lerche | 2009-03-23 | 8 | -15/+59 | |
| | | | ||||||
| * | | Modified the action layout tests to use the new FixtureTemplate class | Carl Lerche | 2009-03-23 | 10 | -26/+89 | |
| | | | ||||||
| * | | Temporary runner | Yehuda Katz | 2009-03-20 | 1 | -0/+8 | |
| | | | ||||||
| * | | Hacked up fixture view paths to simplify tests for a bit | Yehuda Katz | 2009-03-20 | 1 | -0/+69 | |
| | | | ||||||
| * | | Test controller layout | Yehuda Katz | 2009-03-19 | 8 | -2/+40 | |
| | | | ||||||
| * | | Get very basic layouts working. | Yehuda Katz | 2009-03-19 | 10 | -28/+104 | |
| | | | | | | | | | * Required small architecture change | |||||
| * | | Started implementing render :action | Yehuda Katz | 2009-03-19 | 7 | -65/+192 | |
| | | | ||||||
| * | | Implemented basic template rendering in AC::Base2: | Yehuda Katz | 2009-03-18 | 6 | -90/+289 | |
| | | | | | | | | | | | | | | | | | | | | | * Created several macros for writing simpler specs * Finished making Rack::Test work right * Implemented render_to_string * Status Codes * render :text => nil | |||||
| * | | Rework NewCallbacks to not require method_missing | Yehuda Katz | 2009-03-17 | 1 | -1/+9 | |
| | | | ||||||
| * | | Temporarily reraise to simplify debugging | Yehuda Katz | 2009-03-17 | 1 | -0/+1 | |
| | | | ||||||
| * | | Working toward getting a basic AbstractController framework | Yehuda Katz | 2009-03-17 | 9 | -247/+244 | |
| | | | ||||||
| * | | Try to build a new AC::Base on top of AbstractController | Yehuda Katz | 2009-03-12 | 5 | -0/+416 | |
| | | |